From patchwork Fri Oct 13 16:24:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 115790 Delivered-To: patch@linaro.org Received: by 10.140.22.163 with SMTP id 32csp922134qgn; Fri, 13 Oct 2017 09:29:52 -0700 (PDT) X-Received: by 10.55.24.73 with SMTP id j70mr2520501qkh.310.1507912192412; Fri, 13 Oct 2017 09:29:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1507912192; cv=none; d=google.com; s=arc-20160816; b=eG7waj5tljyAeiKwcYgGnh0288ZsPf10+cMOjG9gU8/cazSYnC7xTPpJNYgdJqmvmR cVEpS9vIxbbPF0z9yXIvWLboromsEGspCDBQtHk2kLCqt6RIDEBpYD/N7pKHRnf0pZck GjJyxh71cZnXTQ4XMVvJPFATm5ayDTgHOIM5ayw9r1b/8WcY6Ph8dwJGqT5LeYNfFIJ5 nicTbJQOLNPmUidRHA46w6evRq/aDzixv1yjebLzZb4iJ6U/IoJ48ClN8zPZW9T58Pmx TKtciGl4ck2rO3UTEo4zzt97jkcOfRgYzjGec+ejgKmlQ6pN5+J+dQV0FklCqUc/5Rz/ W7Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=mOzMaLth9wCvMkVFiw3xeor0i6CYV3CwTGYP8bXsncg=; b=NR1OSCtRT+yVM15vruWad1zqegCmfe+EpHlYoooB7/GpaV806f8HqJpQXvRM0a3yl9 ZZFxeImxO7n9tZg9/HCcvjQjh9kUlNpYOAKogPJAOd9xcagNOklX0GE8O9ke17mezIIl U+z82Wbxo5/g+qrp5dLvyUNuCq/Iv051lwWT5tvPnyjQUdgF/UEPmMTpQz2GsCidZsl9 PWUdk+AEqMF2DQ+owM4qKyrguB+0Nt6UMZRODK725SHgyfPR3AjLx6MdDHO8CbssEVSA wp5pF5hTLxbOijppX2s88hg3FIEqjXUrUMnOzwzGqg/CJiU5SpMQl/d8PR85q9PEs3Vx KN7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=CFp4wIid; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id t82si988744qkl.35.2017.10.13.09.29.52 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 13 Oct 2017 09:29:52 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=CFp4wIid; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:51043 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e32qL-0006NU-T0 for patch@linaro.org; Fri, 13 Oct 2017 12:29:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e32ld-0002d1-Qk for qemu-devel@nongnu.org; Fri, 13 Oct 2017 12:24:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e32lb-0006da-M6 for qemu-devel@nongnu.org; Fri, 13 Oct 2017 12:24:57 -0400 Received: from mail-wr0-x236.google.com ([2a00:1450:400c:c0c::236]:45927) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e32lb-0006cy-Fk for qemu-devel@nongnu.org; Fri, 13 Oct 2017 12:24:55 -0400 Received: by mail-wr0-x236.google.com with SMTP id k7so1417671wre.2 for ; Fri, 13 Oct 2017 09:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mOzMaLth9wCvMkVFiw3xeor0i6CYV3CwTGYP8bXsncg=; b=CFp4wIidehUi8xLK8uZeT51HFRKFhY+BmFRzoFCet96E4HkLQ7jUYtWArGP5+NUvEI UPatHilG5QAWEO1vWH5MiBneXWMV5zBtxcR7PjJKeNXx6mREG1Ykuu0I8r/SG6kDVN+1 E8QtNCRjZlQ93NHAlmFVlhG7+YX8NGgAHasOw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mOzMaLth9wCvMkVFiw3xeor0i6CYV3CwTGYP8bXsncg=; b=naDyxlD1Gu+7NcIz0fyw0QUULKvqpef9W6zto2/T1NQbRKk1UZKH8rtQdtkl56ix1T jCJC6+wB4HZ381bvIxaOLYfW+p6I3LzVRT+vEzMNxEhQnxOAImecoy7rqqMxoxIlMOw4 Hru3nutaDQUQJRdkMrGw6pQHMR5hf1ONJ7QjV43LuXCLLxR+sr59Bm1qvPpAI/rgIaph beYcoxmF32vCodC6juZA0ZYoMGcGeGciUkBfjQ/PsmWbOdAWqVQ2k7+d+xurzzWAkWir 3XcIKHTUbSGaFlDlRsNPP1QYp09uWiEvoutt4s1DKwiccDFt1bjXolATgTM+iu6mA9Ee L0+g== X-Gm-Message-State: AMCzsaUuRfgTkSH/TdADy2I45eikTgtW251meRVaXWgAMWBirx4F8Dr3 Y0PHLWwAzLX1vUeWOL2DSmtcIg== X-Google-Smtp-Source: AOwi7QCP4oFYaj5VdaXrM3NiQoepY/jHpO9cV1Q79z2fHMhGfxpERb/baiMlsPo5WWVUHliNe/V6UQ== X-Received: by 10.223.129.41 with SMTP id 38mr2116372wrm.57.1507911894512; Fri, 13 Oct 2017 09:24:54 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id r123sm1144216wmf.41.2017.10.13.09.24.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Oct 2017 09:24:48 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id 243893E08CD; Fri, 13 Oct 2017 17:24:39 +0100 (BST) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: richard.henderson@linaro.org Date: Fri, 13 Oct 2017 17:24:18 +0100 Message-Id: <20171013162438.32458-11-alex.bennee@linaro.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20171013162438.32458-1-alex.bennee@linaro.org> References: <20171013162438.32458-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::236 Subject: [Qemu-devel] [RFC PATCH 10/30] softfloat: improve comments on ARM NaN propagation X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, =?utf-8?q?Alex_Benn?= =?utf-8?b?w6ll?= , qemu-devel@nongnu.org, Aurelien Jarno Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Mention the pseudo-code fragment from which this is based and correct the spelling of signalling. Signed-off-by: Alex Bennée --- fpu/softfloat-specialize.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) -- 2.14.1 Reviewed-by: Richard Henderson diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h index c8282b8bf7..2ccd4abe11 100644 --- a/fpu/softfloat-specialize.h +++ b/fpu/softfloat-specialize.h @@ -445,14 +445,14 @@ static float32 commonNaNToFloat32(commonNaNT a, float_status *status) #if defined(TARGET_ARM) static int pickNaN(flag aIsQNaN, flag aIsSNaN, flag bIsQNaN, flag bIsSNaN, - flag aIsLargerSignificand) + flag aIsLargerSignificand) { - /* ARM mandated NaN propagation rules: take the first of: - * 1. A if it is signaling - * 2. B if it is signaling + /* ARM mandated NaN propagation rules (see FPProcessNaNs()), take the first of: + * 1. A if it is signalling + * 2. B if it is signalling * 3. A (quiet) * 4. B (quiet) - * A signaling NaN is always quietened before returning it. + * A signalling NaN is always quietened before returning it. */ if (aIsSNaN) { return 0;