From patchwork Tue Mar 7 15:50:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 95008 Delivered-To: patch@linaro.org Received: by 10.140.82.71 with SMTP id g65csp1953451qgd; Tue, 7 Mar 2017 08:09:29 -0800 (PST) X-Received: by 10.31.36.151 with SMTP id k145mr643052vkk.29.1488902969331; Tue, 07 Mar 2017 08:09:29 -0800 (PST) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 9si211400uag.21.2017.03.07.08.09.28 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 07 Mar 2017 08:09:29 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:51425 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clHfy-0001nQ-GP for patch@linaro.org; Tue, 07 Mar 2017 11:09:26 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45834) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clHO5-0002UE-RQ for qemu-devel@nongnu.org; Tue, 07 Mar 2017 10:51:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clHO4-0005qy-My for qemu-devel@nongnu.org; Tue, 07 Mar 2017 10:50:57 -0500 Received: from mail-wr0-x232.google.com ([2a00:1450:400c:c0c::232]:34192) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1clHO4-0005qO-A1 for qemu-devel@nongnu.org; Tue, 07 Mar 2017 10:50:56 -0500 Received: by mail-wr0-x232.google.com with SMTP id l37so4381792wrc.1 for ; Tue, 07 Mar 2017 07:50:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8lpWRwy8UPmdlWUz+lQvEwbITj3/HElyc7FbfuzGx+A=; b=PWIkZqDdumMdh5+pl9juMsYyIS2PPZZM5o0ypCLw5s4e5afNjyL8QNW8PE2UYFb7sA Uy3745WAbtrFAdOYqjhE0OwpTUWUvJB3rvQMwbLvrNAEaAc9vOlnh0RgfnLQYIJQjf28 MbnloXXuVG0HLNz2cZeqb5ANM+PWkxrx2+t7c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8lpWRwy8UPmdlWUz+lQvEwbITj3/HElyc7FbfuzGx+A=; b=DJMwkoh2i4f+HGWs9j2WuqTyo6k5EenjXZYfn9f+7IOo9aJi/kkv8nRelkNMd9P8kL sfgtsfHbzxEJJg4+rcfzzKYDxLFXsBswB9WD8EQ3aA/5RC/jS6aeza9KsJX8VZWoK0Oc JxnrPFHtOrVHCEWH85VNUlSYONxwin+wLCDvwWaaAAUdBpvonOIuKV9KlmGNgEj+KYmO vQGDiS6ep1IiY8pCtx9BAIEnns8IRFfKtRoKVrnnXGAxkblBo50UzoCdiBYgPpgjBV3f 149o2xXobmtOkGbJJAScIDEK3f+693TWpMF9HjfSbWbNMkS+M5eca2KAL8JfjcIuLref kjrQ== X-Gm-Message-State: AMke39kilWMhgZ/bcbcFVqe1tKoufpqZqQweiWAnIUnRUiFeF7L4VNFgpH3b4PoeXcrgq40U X-Received: by 10.223.160.9 with SMTP id k9mr944046wrk.123.1488901855119; Tue, 07 Mar 2017 07:50:55 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id u145sm9170142wmu.1.2017.03.07.07.50.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Mar 2017 07:50:53 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id DD75E3E3029; Tue, 7 Mar 2017 15:50:54 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org, rth@twiddle.net, pbonzini@redhat.com Date: Tue, 7 Mar 2017 15:50:49 +0000 Message-Id: <20170307155054.5833-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170307155054.5833-1-alex.bennee@linaro.org> References: <20170307155054.5833-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::232 Subject: [Qemu-devel] [PATCH v3 06/11] target/xtensa: hold BQL for interrupt processing X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mttcg@listserver.greensocs.com, nikunj@linux.vnet.ibm.com, a.rigo@virtualopensystems.com, qemu-devel@nongnu.org, Max Filippov , cota@braap.org, bobby.prani@gmail.com, =?utf-8?q?Alex_Benn=C3=A9e?= , fred.konrad@greensocs.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Make sure we have the BQL held when processing interrupts. Reported-by: Thomas Huth Signed-off-by: Alex Bennée Acked-by: Max Filippov --- target/xtensa/helper.c | 1 + target/xtensa/op_helper.c | 7 +++++++ 2 files changed, 8 insertions(+) -- 2.11.0 diff --git a/target/xtensa/helper.c b/target/xtensa/helper.c index c67d715c4b..bcd0b7738d 100644 --- a/target/xtensa/helper.c +++ b/target/xtensa/helper.c @@ -217,6 +217,7 @@ static void handle_interrupt(CPUXtensaState *env) } } +/* Called from cpu_handle_interrupt with BQL held */ void xtensa_cpu_do_interrupt(CPUState *cs) { XtensaCPU *cpu = XTENSA_CPU(cs); diff --git a/target/xtensa/op_helper.c b/target/xtensa/op_helper.c index af2723445d..519fbeddd6 100644 --- a/target/xtensa/op_helper.c +++ b/target/xtensa/op_helper.c @@ -26,6 +26,7 @@ */ #include "qemu/osdep.h" +#include "qemu/main-loop.h" #include "cpu.h" #include "exec/helper-proto.h" #include "qemu/host-utils.h" @@ -381,7 +382,11 @@ void HELPER(waiti)(CPUXtensaState *env, uint32_t pc, uint32_t intlevel) env->pc = pc; env->sregs[PS] = (env->sregs[PS] & ~PS_INTLEVEL) | (intlevel << PS_INTLEVEL_SHIFT); + + qemu_mutex_lock_iothread(); check_interrupts(env); + qemu_mutex_unlock_iothread(); + if (env->pending_irq_level) { cpu_loop_exit(CPU(xtensa_env_get_cpu(env))); return; @@ -426,7 +431,9 @@ void HELPER(update_ccompare)(CPUXtensaState *env, uint32_t i) void HELPER(check_interrupts)(CPUXtensaState *env) { + qemu_mutex_lock_iothread(); check_interrupts(env); + qemu_mutex_unlock_iothread(); } void HELPER(itlb_hit_test)(CPUXtensaState *env, uint32_t vaddr)