From patchwork Tue Mar 7 15:50:46 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 95005 Delivered-To: patch@linaro.org Received: by 10.140.82.71 with SMTP id g65csp1952294qgd; Tue, 7 Mar 2017 08:07:16 -0800 (PST) X-Received: by 10.31.102.135 with SMTP id a129mr552836vkc.60.1488902836369; Tue, 07 Mar 2017 08:07:16 -0800 (PST) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [208.118.235.17]) by mx.google.com with ESMTPS id j7si201979vkf.99.2017.03.07.08.07.15 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 07 Mar 2017 08:07:16 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) client-ip=208.118.235.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 208.118.235.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:51412 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clHdp-0007rV-L5 for patch@linaro.org; Tue, 07 Mar 2017 11:07:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1clHO2-0002R2-K1 for qemu-devel@nongnu.org; Tue, 07 Mar 2017 10:50:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1clHO1-0005os-Ay for qemu-devel@nongnu.org; Tue, 07 Mar 2017 10:50:54 -0500 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:38555) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1clHO1-0005n8-5l for qemu-devel@nongnu.org; Tue, 07 Mar 2017 10:50:53 -0500 Received: by mail-wm0-x22c.google.com with SMTP id t189so8503912wmt.1 for ; Tue, 07 Mar 2017 07:50:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0GOTDX+AElx29ttE0BJjThzMCfmU4ClQA+AJ7HMsjtc=; b=PkUCvw190IXLxlxA5jwNEZwvxHhaOAOqYJrFoWWx4aSXVsnTtqRGMy4+/SUucpdo9n 4mGxxYCpskL5ErLwGIcjmhWmBYFz6P/OI9Kg6s4Sw5HhhK/t1ssPce1h5qCYKxqFMpr8 swReuSbVvpe5SlOb77g/HjZGoKdmrFfqfwVwI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0GOTDX+AElx29ttE0BJjThzMCfmU4ClQA+AJ7HMsjtc=; b=f65QSA2/MRQZ6MzyklaGst3K3BTEdO4GcTtA7KMtet7qTTpuKgq9g0CpDzc6jvnHD5 b+aj2utapDbOwjAGcaI4N4zCZDBRPaDpPbRWP8Dwi1++UASgwG4EWT62WWfm+ii1HpI3 jkwCSVGGMGEQZPLGz5g09V2TrTKx+DUsBeWCs851KgIPepxzGX/od1wwrNCjGdQsXv95 nrIPIIACG7VZ/y55ykw6eMK/0ZWyu7hITe2DtkeFHhgcMXkZSpgrWevEafoZuJMB+vFt Yi+7Rlnjddv7H4A+sZycCqsNBJ0YTODrBOmsJqjyPZaQD+ma0HiUqYBYW4+6usj3IO6W AEPA== X-Gm-Message-State: AMke39kP6tPdzt125trHNUTd94Sq8gggZotxK2AwMza9NzUQgOhIE8qlnqEP+WU0iuZ5UzoJ X-Received: by 10.28.93.68 with SMTP id r65mr1524078wmb.133.1488901852024; Tue, 07 Mar 2017 07:50:52 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id e72sm1072124wma.5.2017.03.07.07.50.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Mar 2017 07:50:48 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id A4B913E3006; Tue, 7 Mar 2017 15:50:54 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: peter.maydell@linaro.org, rth@twiddle.net, pbonzini@redhat.com Date: Tue, 7 Mar 2017 15:50:46 +0000 Message-Id: <20170307155054.5833-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170307155054.5833-1-alex.bennee@linaro.org> References: <20170307155054.5833-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22c Subject: [Qemu-devel] [PATCH v3 03/11] cpus.c: add additional error_report when !TARGET_SUPPORT_MTTCG X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mttcg@listserver.greensocs.com, nikunj@linux.vnet.ibm.com, Peter Crosthwaite , a.rigo@virtualopensystems.com, qemu-devel@nongnu.org, cota@braap.org, bobby.prani@gmail.com, =?utf-8?q?Alex_Benn=C3=A9e?= , fred.konrad@greensocs.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" While we may fail the memory ordering check later that can be confusing. So in cases where TARGET_SUPPORT_MTTCG has yet to be defined we should say so specifically. Signed-off-by: Alex Bennée Reviewed-by: Richard Henderson --- cpus.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.11.0 Reviewed-by: Philippe Mathieu-Daudé diff --git a/cpus.c b/cpus.c index 6a817fec13..69e21858b8 100644 --- a/cpus.c +++ b/cpus.c @@ -202,6 +202,10 @@ void qemu_tcg_configure(QemuOpts *opts, Error **errp) } else if (use_icount) { error_setg(errp, "No MTTCG when icount is enabled"); } else { +#ifndef TARGET_SUPPORT_MTTCG + error_report("Guest not yet converted to MTTCG - " + "you may get unexpected results"); +#endif if (!check_tcg_memory_orders_compatible()) { error_report("Guest expects a stronger memory ordering " "than the host provides");