From patchwork Tue Feb 28 15:07:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 94640 Delivered-To: patch@linaro.org Received: by 10.140.20.113 with SMTP id 104csp1370966qgi; Tue, 28 Feb 2017 07:29:07 -0800 (PST) X-Received: by 10.176.90.147 with SMTP id w19mr1351775uae.0.1488295747248; Tue, 28 Feb 2017 07:29:07 -0800 (PST) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id y14si758864vkc.153.2017.02.28.07.29.06 for (version=TLS1 cipher=AES128-SHA bits=128/128); Tue, 28 Feb 2017 07:29:07 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:33913 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciji4-0004lY-O2 for patch@linaro.org; Tue, 28 Feb 2017 10:29:04 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52280) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cijMy-0003eD-84 for qemu-devel@nongnu.org; Tue, 28 Feb 2017 10:07:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cijMx-0002n7-EQ for qemu-devel@nongnu.org; Tue, 28 Feb 2017 10:07:16 -0500 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:35555) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cijMx-0002mt-8S for qemu-devel@nongnu.org; Tue, 28 Feb 2017 10:07:15 -0500 Received: by mail-wm0-x231.google.com with SMTP id v186so87825517wmd.0 for ; Tue, 28 Feb 2017 07:07:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GBzMg0Bu+xAy+YqM6RO8K4/10f4EHMvced4QEwwuZu8=; b=hOC+6gsPJN4PrtUqbFIK33PxCJYVyrEG4mVfswmyr3wG/bfgk8MKodcfqY4V5kYvUJ 4wX/ZpB9GFxHjMbVGcuKk1V3Z2kpipzRsSWq1FhyGqOQx2XGPYnjggB9bhhb9bdf/yH/ ycnDnSfmBZVFaeXLul6ZyU7hMIbG6h05Imlzk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GBzMg0Bu+xAy+YqM6RO8K4/10f4EHMvced4QEwwuZu8=; b=EUpwaoqRa8ien6pIloWNTpId8kFp7/1XR5l5qxgmOAxveSEB1lmir6/KZnPyRS5bwt IJQqIZU2acyWkTmlo0S5VoSz+TCJArZ+byuxktblcQg4Rlew9D1odG/OFWxexu/Oc6Qb DPh0gZ+Evro5MBERyWc15HMIAp6bhvTRz5s6M6HE6GzLcbRQXjXnsVUO+VySWwISDHAV 5qh7CIqXd0hJDyWUy/M0nEacLnRWxwXOdwDuyvcvLL//CXA3aPGMP2omhJukXhnLc6WN a3+ulZ7g/d46XZ57uNXCGI00F3yN2tBvvqVMEAwKJFFla1fg9drUh7Y2MwCeDKlFNDHf xX4g== X-Gm-Message-State: AMke39kRQPqNvyfPdcDhotZARPNi+jABA6Qrd4MjrTpcfZOZQC/7bI7zyhSd3BYF8TuD9Umz X-Received: by 10.28.8.213 with SMTP id 204mr2947157wmi.100.1488294434195; Tue, 28 Feb 2017 07:07:14 -0800 (PST) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id q4sm2709130wrc.35.2017.02.28.07.07.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Feb 2017 07:07:10 -0800 (PST) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id B7FC03E0813; Tue, 28 Feb 2017 15:07:09 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: rth@twiddle.net Date: Tue, 28 Feb 2017 15:07:09 +0000 Message-Id: <20170228150709.27453-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170228150709.27453-1-alex.bennee@linaro.org> References: <20170228150709.27453-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::231 Subject: [Qemu-devel] [PATCH v1 3/3] cpus.c: add additional error_report when !TARGET_SUPPORT_MTTCG X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mttcg@listserver.greensocs.com, peter.maydell@linaro.org, nikunj@linux.vnet.ibm.com, Peter Crosthwaite , a.rigo@virtualopensystems.com, qemu-devel@nongnu.org, cota@braap.org, Paolo Bonzini , bobby.prani@gmail.com, =?utf-8?q?Alex_Benn?= =?utf-8?b?w6ll?= , fred.konrad@greensocs.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" While we may fail the memory ordering check later that can be confusing. So in cases where TARGET_SUPPORT_MTTCG has yet to be defined we should say so specifically. Signed-off-by: Alex Bennée --- cpus.c | 4 ++++ 1 file changed, 4 insertions(+) -- 2.11.0 diff --git a/cpus.c b/cpus.c index e9aab9f70f..2459f564ea 100644 --- a/cpus.c +++ b/cpus.c @@ -206,6 +206,10 @@ void qemu_tcg_configure(QemuOpts *opts, Error **errp) } else if (use_icount) { error_setg(errp, "No MTTCG when icount is enabled"); } else { +#ifndef TARGET_SUPPORT_MTTCG + error_report("Guest not yet converted to MTTCG - " + "you may get unexpected results"); +#endif if (!check_tcg_memory_orders_compatible()) { error_report("Guest expects a stronger memory ordering " "than the host provides");