From patchwork Fri Sep 30 21:30:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 77181 Delivered-To: patch@linaro.org Received: by 10.140.106.72 with SMTP id d66csp514687qgf; Fri, 30 Sep 2016 14:38:23 -0700 (PDT) X-Received: by 10.237.32.205 with SMTP id 71mr9484828qtb.22.1475271503869; Fri, 30 Sep 2016 14:38:23 -0700 (PDT) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 140si13430779qke.107.2016.09.30.14.38.23 for (version=TLS1 cipher=AES128-SHA bits=128/128); Fri, 30 Sep 2016 14:38:23 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:47055 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bq5Vf-0003KH-Dm for patch@linaro.org; Fri, 30 Sep 2016 17:38:23 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49624) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bq5Ou-0006Rb-DF for qemu-devel@nongnu.org; Fri, 30 Sep 2016 17:31:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bq5Or-0006Vf-NQ for qemu-devel@nongnu.org; Fri, 30 Sep 2016 17:31:23 -0400 Received: from mail-wm0-x22e.google.com ([2a00:1450:400c:c09::22e]:37273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bq5Or-0006VL-Hf for qemu-devel@nongnu.org; Fri, 30 Sep 2016 17:31:21 -0400 Received: by mail-wm0-x22e.google.com with SMTP id b80so66255069wme.0 for ; Fri, 30 Sep 2016 14:31:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9kQ5D2yD9bh6HIZ9sbKArqWGvPFDE9KbCgrZv/pNjKY=; b=Z1gQh5U+aG3No9+jWWPN+1mCKRGOFoxbWsRr96knLlhQwBdJty0uFH3/yn60N6UqM8 Azgxo/KKxNyYpwmlkQ1TNxNqx1zMrpUW5kTyvIqdEgjJtH3EUc6bQiqJQd5eXn/z7v2G BUTsva6MQ2+IO9k2sx9sR7CYsof2IfkAVER/o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9kQ5D2yD9bh6HIZ9sbKArqWGvPFDE9KbCgrZv/pNjKY=; b=DxOfSuX9mimQ77B6eCF0rQlY3AOUZvfUg51QqlkJiM1XpYkYSH33B8UFz5tSF6ib9l VMbKPAOU64PTofCF8697DQkffDN08CTwAVkcD2g2P5WbnR/ZX43x9nOkq13OA/ZYYJ2s ibJpGzgxICD6GFZUmGUIUlyyLnPJQNNH5Rx2UU8TLl9FFihS84x3LZUwvklYd6jPU71Q HxAZd0ha1hUgGASYMCqMQhGRnumDKCG9r7YTZqQL2vCg2z9n2da6hqtdg1MkaXrUCFoR HCZS8cIdbWSMoOklm4IAtQEPU6/qMON1unlmTt7V+wFAQcuFdCZh0068Os70aUaGxAkq 2LiA== X-Gm-Message-State: AA6/9Rn0VQcxgKqVNeGqKAYT8LZF2uMfOfCFYuyiZa9oqNouGEFpVkgqvCimYU8Bb+EUvpNQ X-Received: by 10.28.23.210 with SMTP id 201mr5523092wmx.58.1475271080829; Fri, 30 Sep 2016 14:31:20 -0700 (PDT) Received: from zen.linaro.local ([81.128.185.34]) by smtp.gmail.com with ESMTPSA id n5sm21441744wjv.35.2016.09.30.14.31.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 30 Sep 2016 14:31:19 -0700 (PDT) Received: from zen.linaroharston (localhost [127.0.0.1]) by zen.linaro.local (Postfix) with ESMTP id A9EAE3E0320; Fri, 30 Sep 2016 22:31:17 +0100 (BST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org, pbonzini@redhat.com Date: Fri, 30 Sep 2016 22:30:54 +0100 Message-Id: <20160930213106.20186-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20160930213106.20186-1-alex.bennee@linaro.org> References: <20160930213106.20186-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::22e Subject: [Qemu-devel] [PATCH v3 03/15] exec-all.h: revert tb_page_addr_t to target_ulong X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mttcg@listserver.greensocs.com, peter.maydell@linaro.org, claudio.fontana@huawei.com, nikunj@linux.vnet.ibm.com, Peter Crosthwaite , jan.kiszka@siemens.com, mark.burton@greensocs.com, a.rigo@virtualopensystems.com, cota@braap.org, serge.fdrv@gmail.com, bobby.prani@gmail.com, rth@twiddle.net, =?UTF-8?q?Alex=20Benn=C3=A9e?= , fred.konrad@greensocs.com Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Commit b480d9b74 converted tb_page_addr_t to abi_ulong which while the right size imposes additional alignment restrictions on the type. This gets in the way of using atomic accesses on certain guest platforms which allow finer alignments. As tb_page_addr_t isn't actually visible to the guest we can revert the change. This is potentially less efficient for ILP32 style guests but it is the simpler change to make. Signed-off-by: Alex Bennée --- include/exec/exec-all.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.9.3 Signed-off-by: Alex Bennée diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 336a57c..c3596a6 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-all.h @@ -30,7 +30,7 @@ addresses in userspace mode. Define tb_page_addr_t to be an appropriate type. */ #if defined(CONFIG_USER_ONLY) -typedef abi_ulong tb_page_addr_t; +typedef target_ulong tb_page_addr_t; #else typedef ram_addr_t tb_page_addr_t; #endif