From patchwork Tue Jun 16 07:06:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Riku Voipio X-Patchwork-Id: 49950 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f199.google.com (mail-wi0-f199.google.com [209.85.212.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8612A205DE for ; Tue, 16 Jun 2015 07:10:03 +0000 (UTC) Received: by wifx6 with SMTP id x6sf2653809wif.1 for ; Tue, 16 Jun 2015 00:10:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=c5jPlsUjYwErRriwqluiRqu4gRAeBoH8HgnRsqT6FLA=; b=ZGd6sqsqqfOYQ/NjA2xRjnaUyD2Kvm3e49GXGjo6PwTTJ8yTSP4M15haqWkEd2h9Sq B881RlcUtrAATG6Sd0i3z41net3HKmRA4rtaX1V2BoWkSe901nlzaV6uBW2vsmsxo62i Gf8TyMYZlEtcv8DsFX+hHW0uz3IEO1Anfk+jMdXCYHEuCgKXL4l6AbCYJpLRiGT8OD/f zEKTIvn8FyU6mOYHDXhH21DqIAtfgmZgqpXwjEHYqC1BUspR5mQbGDtsrMZmhLR7zDna RuGuIye+ANE7X4ZFe6lfCxn6R0z5qDb+upgZggOhfmF2nP6O97QFSeWcPoPJEEfYnket DNiw== X-Gm-Message-State: ALoCoQkwYElAHl+iRLw+P6BstRt4ctc/S1U2/Hc9AIzVNaF4CCCgRpYBsUliTidxbTfdyLpQaOPD X-Received: by 10.112.118.162 with SMTP id kn2mr4195872lbb.22.1434438602382; Tue, 16 Jun 2015 00:10:02 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.6.130 with SMTP id b2ls39628laa.4.gmail; Tue, 16 Jun 2015 00:10:02 -0700 (PDT) X-Received: by 10.152.5.65 with SMTP id q1mr31555729laq.110.1434438602233; Tue, 16 Jun 2015 00:10:02 -0700 (PDT) Received: from mail-la0-f43.google.com (mail-la0-f43.google.com. [209.85.215.43]) by mx.google.com with ESMTPS id h7si104328lbs.29.2015.06.16.00.10.02 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Jun 2015 00:10:02 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.43 as permitted sender) client-ip=209.85.215.43; Received: by labbc20 with SMTP id bc20so4870294lab.1 for ; Tue, 16 Jun 2015 00:10:02 -0700 (PDT) X-Received: by 10.152.1.40 with SMTP id 8mr32119447laj.56.1434438602145; Tue, 16 Jun 2015 00:10:02 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp1914214lbb; Tue, 16 Jun 2015 00:10:00 -0700 (PDT) X-Received: by 10.55.16.74 with SMTP id a71mr67862970qkh.15.1434438599252; Tue, 16 Jun 2015 00:09:59 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id w104si110837qgd.2.2015.06.16.00.09.57 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 16 Jun 2015 00:09:59 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:38180 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4l0P-0000kD-H1 for patch@linaro.org; Tue, 16 Jun 2015 03:09:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4kxG-0004EN-PD for qemu-devel@nongnu.org; Tue, 16 Jun 2015 03:06:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4kxD-0006oP-Jj for qemu-devel@nongnu.org; Tue, 16 Jun 2015 03:06:42 -0400 Received: from mail-lb0-f182.google.com ([209.85.217.182]:33243) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4kxD-0006o2-DZ for qemu-devel@nongnu.org; Tue, 16 Jun 2015 03:06:39 -0400 Received: by lblr1 with SMTP id r1so4733242lbl.0 for ; Tue, 16 Jun 2015 00:06:38 -0700 (PDT) X-Received: by 10.152.43.69 with SMTP id u5mr30955920lal.119.1434438398878; Tue, 16 Jun 2015 00:06:38 -0700 (PDT) Received: from localhost.localdomain (91-157-196-38.elisa-laajakaista.fi. [91.157.196.38]) by mx.google.com with ESMTPSA id wc8sm27104lbb.37.2015.06.16.00.06.37 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 16 Jun 2015 00:06:38 -0700 (PDT) From: riku.voipio@linaro.org To: qemu-devel@nongnu.org Date: Tue, 16 Jun 2015 10:06:31 +0300 Message-Id: <1d085f6cae51b1a0fb92ad03ce8bf038e29c9750.1434438233.git.riku.voipio@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.217.182 Cc: peter.maydell@linaro.org, Thierry Bultel Subject: [Qemu-devel] [PULL v2 5/6] linux-user: fix the breakpoint inheritance in spawned threads X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: riku.voipio@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.43 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Thierry Bultel When a thread is spawned, cpu_copy re-initializes the bp & wp lists of current thread, instead of the ones of the new thread. The effect is that breakpoints are no longer hit. Signed-off-by: Thierry Bultel Signed-off-by: Riku Voipio --- linux-user/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index a0d3e58..c855bcc 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -3459,8 +3459,8 @@ CPUArchState *cpu_copy(CPUArchState *env) /* Clone all break/watchpoints. Note: Once we support ptrace with hw-debug register access, make sure BP_CPU break/watchpoints are handled correctly on clone. */ - QTAILQ_INIT(&cpu->breakpoints); - QTAILQ_INIT(&cpu->watchpoints); + QTAILQ_INIT(&new_cpu->breakpoints); + QTAILQ_INIT(&new_cpu->watchpoints); QTAILQ_FOREACH(bp, &cpu->breakpoints, entry) { cpu_breakpoint_insert(new_cpu, bp->pc, bp->flags, NULL); }