From patchwork Wed Nov 11 13:11:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jason Wang X-Patchwork-Id: 322923 Delivered-To: patch@linaro.org Received: by 2002:a05:6e02:5ce:0:0:0:0 with SMTP id l14csp389019ils; Wed, 11 Nov 2020 05:27:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJwhNR/MeTVVovy3cLH6rVVY2hkkfiNweomkSXBOLPRviMc2kKSWB7y6jo5xqqXPXZ/11so0 X-Received: by 2002:a25:57d6:: with SMTP id l205mr33009160ybb.117.1605101230127; Wed, 11 Nov 2020 05:27:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605101230; cv=none; d=google.com; s=arc-20160816; b=YHjtKi2EcO9Ap38+LUw3gJByDgGh2zuNSJRp1CfmqXqGzzQiof4Qwq62jOgZYk2ZpJ 4PSLqlYxWZDWf3vL1mnYKwi7EctmhjO79nJE5SnbVKDsj4AkZ50ay4PKCHXaGDsN223T 0MW9UzCH36C3k+lfmhiPckko26ujeWZbCy0PGyU8A5LIrngDEVDQJO3XaEIvKyBfUxLC lLyc/MLn3g59S7SYOc1PR0fLmLhvPUq2oiwYbiU77qXcY9Y9iwYRGpP5UJ0K3391EiO8 BigA3DifgnUcy4G5UHcw38NVPNQSYKAjvCR41lg2e60TI8ttWZmzRvngh76BcQV1avvC aBBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=0tRk+VsAm5cXSsSJkpxworVPoJ+oOeYmX9krht8arW8=; b=yK3Hvucl6LfZFLngu+VAI4P3GxQ3TaAfRJu1X7BYstojNo5bvzQh4BVMjg9XDayQOY UM3VF7U9s5N2qFkzyEkZxw0Eo4f1zkouFBY2XQrjkFwwD1jnRahnMFIkz1Sni0wsXI7e 8a979IAJlLOPkBU5Oq2BGG6BUTxga+16PIrm5jQkVePSzdncq/6RKJ5wrFnQ/w7L/1vh 8X+py4TYNBtPXRtLgnIDfzL+HFw0kLUdZ0WNzoWcROhBirixypWRWCysVv2WA+pD6Xx2 lV97tnrBStZlaFxrgQm3wd4FZyElLY8CK9tet9B9Hlk+25l50fEIALh+B3GGckukO1HU j7dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=S0m1BOS8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id w9si1931097ybk.401.2020.11.11.05.27.10 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Nov 2020 05:27:10 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=S0m1BOS8; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:34928 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcq9V-0003qH-Ki for patch@linaro.org; Wed, 11 Nov 2020 08:27:09 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44654) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcpvJ-0007N7-Dx for qemu-devel@nongnu.org; Wed, 11 Nov 2020 08:12:30 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:58902) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kcpvG-0002GS-7n for qemu-devel@nongnu.org; Wed, 11 Nov 2020 08:12:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1605100345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0tRk+VsAm5cXSsSJkpxworVPoJ+oOeYmX9krht8arW8=; b=S0m1BOS8ElXD2wxtKFQhFPoZf7rJahApcD6czacSeVZTCjtZT1ptm7N0VZvMEPX9xa8DZB k4Fzaydw0oLQq7S0miqBUIqMtasgqw6BfLAHbZBEmlbbHnat8cmpOtVI+DP+3lGwRYBd8i iFOHAVE9lfdAWJYPLdEjzADOVlOd5ck= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-554-k9mv4xeLMUuJrXZYnkUKFw-1; Wed, 11 Nov 2020 08:12:23 -0500 X-MC-Unique: k9mv4xeLMUuJrXZYnkUKFw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8701C1087D63; Wed, 11 Nov 2020 13:12:22 +0000 (UTC) Received: from jason-ThinkPad-T430s.redhat.com (ovpn-12-61.pek2.redhat.com [10.72.12.61]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3411D55760; Wed, 11 Nov 2020 13:12:20 +0000 (UTC) From: Jason Wang To: qemu-devel@nongnu.org, peter.maydell@linaro.org Subject: [PULL 16/17] hw/net/can/ctucan_core: Handle big-endian hosts Date: Wed, 11 Nov 2020 21:11:40 +0800 Message-Id: <1605100301-11317-17-git-send-email-jasowang@redhat.com> In-Reply-To: <1605100301-11317-1-git-send-email-jasowang@redhat.com> References: <1605100301-11317-1-git-send-email-jasowang@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Received-SPF: pass client-ip=63.128.21.124; envelope-from=jasowang@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/11 01:42:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Wang Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell The ctucan driver defines types for its registers which are a union of a uint32_t with a struct with bitfields for the individual fields within that register. This is a bad idea, because bitfields aren't portable. The ctu_can_fd_regs.h header works around the most glaring of the portability issues by defining the fields in two different orders depending on the setting of the __LITTLE_ENDIAN_BITFIELD define. However, in ctucan_core.h this is unconditionally set to 1, which is wrong for big-endian hosts. Set it only if HOST_WORDS_BIGENDIAN is not set. There is no need for a "have we defined it already" guard, because the only place that should set it is ctucan_core.h, which has the usual double-inclusion guard. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Acked-by: Pavel Pisa Tested-by: Pavel Pisa Signed-off-by: Jason Wang --- hw/net/can/ctucan_core.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.7.4 diff --git a/hw/net/can/ctucan_core.h b/hw/net/can/ctucan_core.h index f21cb1c..bbc09ae 100644 --- a/hw/net/can/ctucan_core.h +++ b/hw/net/can/ctucan_core.h @@ -31,8 +31,7 @@ #include "exec/hwaddr.h" #include "net/can_emu.h" - -#ifndef __LITTLE_ENDIAN_BITFIELD +#ifndef HOST_WORDS_BIGENDIAN #define __LITTLE_ENDIAN_BITFIELD 1 #endif