From patchwork Mon Feb 5 19:28:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Bonzini X-Patchwork-Id: 126925 Delivered-To: patch@linaro.org Received: by 10.46.124.24 with SMTP id x24csp2257522ljc; Mon, 5 Feb 2018 11:39:18 -0800 (PST) X-Google-Smtp-Source: AH8x227DFMbb/+4pSlKAWzfnw7yw0VXT0xaVTBvn7266QAUof9KwDRtdqhL7wBhCvrY4jAbM2TJv X-Received: by 10.37.184.20 with SMTP id v20mr29896093ybj.521.1517859557921; Mon, 05 Feb 2018 11:39:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1517859557; cv=none; d=google.com; s=arc-20160816; b=lPXVvY6VhtGtHBobGqVaCLgSG/h16b0dSHXN6qZH09Y/XPX4AqDu/wWjclNEsVTusc fQWwpMjpQ78hJznfME93GoGNagWZdLOIcK1QG9qLm09FRhWVkP7Q+ZGausOXMpxjDsvA QLGr0pyyk5DCF/sP28C7E6FaEst8LZlMdPo/zg/N40O+zswpXucteYdey8W2bRztPQ7D u7LW7z5jRpDGZi6Lo/EK+6sZdPOIISCMkaMzNpwG3aYGLFrmpSTD7ckeD+B8Slr6rMHC 1HYoZ6PYoCsRZb8XoRqo0kTDooZgMzDHZMxGA1wRGCWyJPsegkubCmdUH8XlLMCAI0mE WgiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature:arc-authentication-results; bh=pBNw2N2PYmDefLURfSD+jyg9E2oNRgCbEmbV6JqF4oc=; b=zGmYiiaT/eoGPv/Wt7PeFMPEreyqUn+UYb0Pm/nx1KjY8FNaGuR9QvzYhk4zGH+S68 ssnb8Kwy+IY0ItMsd6rutJxn2mmzOn8pz2+qzBPmTXoRoNk6+Q69vVBymF+jyKMR/8dc peDzPiFU86qAPIgBgkujo+XMfvxum72gQSNiKvpGQg4kCTyiZtCtRstRrteeKC9PgoHs d+buTwMVRU+8fZXhewxHQc/jcEtKm8T/zB6ns3ETMDC+siJG7kwMfJp97Q9pAfK7mRl3 cYqwst8JtU4lOuxXOSVNGHCnEtnQe54eK4MHGffAKKD1lxpNMoXjCXuFGlwXngKNb8hQ Usvg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=sWWX1hUQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id y14si975913ybg.279.2018.02.05.11.39.17 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 05 Feb 2018 11:39:17 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=sWWX1hUQ; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:54818 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eimbl-0005GH-B7 for patch@linaro.org; Mon, 05 Feb 2018 14:39:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44567) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eimSA-0004Lp-5G for qemu-devel@nongnu.org; Mon, 05 Feb 2018 14:29:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eimS8-0004vs-UY for qemu-devel@nongnu.org; Mon, 05 Feb 2018 14:29:22 -0500 Received: from mail-wm0-x241.google.com ([2a00:1450:400c:c09::241]:39626) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eimS8-0004vJ-My for qemu-devel@nongnu.org; Mon, 05 Feb 2018 14:29:20 -0500 Received: by mail-wm0-x241.google.com with SMTP id b21so28072091wme.4 for ; Mon, 05 Feb 2018 11:29:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=pBNw2N2PYmDefLURfSD+jyg9E2oNRgCbEmbV6JqF4oc=; b=sWWX1hUQNh5l72qKkDBbun/gU6Z5tuoPCgitbSFlOgiH6SPPtZ3hbSxe6W6RoWoV6Y YbNfjV036yNQTYXkSxGj+idUBePFXXFf3Hj1hVyCNeBGsYk14LJ0Jadxls0ROk18KZMh Srjj4mebsYQhOszurcvvEQ/GmTA0S0Dz8HcQFkbozrmuxdK6TpTKOMor58j+xuzicAiT vOfX+npkXX007TOB3kUkyO97fl8fZ4DzQHGitvlAuMuI6vwTdPUrTeddzNMoa5EaJZVf nqkIPxB0GLcGFQQskz4Rw5bgw6aS8z+12c2HRV0skE+AFc1vgaSWd+p8bQo6EKtUf6M6 25xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=pBNw2N2PYmDefLURfSD+jyg9E2oNRgCbEmbV6JqF4oc=; b=JEFxdz71n7tFr3ri/HgOTtqwe8bB/bt7cfATcpKnAjeF0NcRPKpxSwE5QDz4PrRg27 T1Yr3Uh5wCNg+uctw3DmHt3qeMXnubqrtoQO3g//7IrnuzlHpFCLOfsnDRC3BE3HZ7DI qmi+//tF+TZttCGcSvYYWoRWY0s7olyRHZvdt5XybYNT3HGRPZFHhDX+m4yBK4cDl63R nnIYZUq/35XV0NyX9KkOiFJyM1zN5nEYn5Kq42439M7lgwfYHuizv9hDvkFUgHmu3BAC 5S/H6bSiMOh+UrngIiNA2zWfk7sPYO5rGLg/mMp3LE8IajIDH4OTMLVq5NTmmARjlP/Y DJNw== X-Gm-Message-State: APf1xPBsno+F8AFhfmK+ttn2qNeY5C1Qv1Sw+j4rNejQIkre/D4IWrP3 s88U5TG3nGoCCfBMKCIaMV8OH5LN X-Received: by 10.28.29.130 with SMTP id d124mr322748wmd.139.1517858959317; Mon, 05 Feb 2018 11:29:19 -0800 (PST) Received: from 640k.lan ([82.84.122.246]) by smtp.gmail.com with ESMTPSA id g8sm20029891wra.18.2018.02.05.11.29.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 05 Feb 2018 11:29:18 -0800 (PST) From: Paolo Bonzini To: qemu-devel@nongnu.org Date: Mon, 5 Feb 2018 20:28:26 +0100 Message-Id: <1517858941-5538-13-git-send-email-pbonzini@redhat.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1517858941-5538-1-git-send-email-pbonzini@redhat.com> References: <1517858941-5538-1-git-send-email-pbonzini@redhat.com> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c09::241 Subject: [Qemu-devel] [PULL 12/47] memory-internal.h: Remove obsolete claim that header is obsolete X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell The memory-internal.h header claims that it is for "obsolete exec.c functions" which "will be removed soon". This statement was added in 2011, six years ago, but the header is still here. (Admittedly none of the prototypes added in commit 67d95c153bef55f6 are still in the header.) It's convenient to have a place to put prototypes for functions which are used internally to the various .c files of the memory system or by the accel/tcg code, which is inevitably fairly closely coupled. So keep the header but update the comments to reflect what we're actually using it for. Signed-off-by: Peter Maydell Message-Id: <1511276888-17834-1-git-send-email-peter.maydell@linaro.org> Signed-off-by: Paolo Bonzini --- include/exec/memory-internal.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 1.8.3.1 diff --git a/include/exec/memory-internal.h b/include/exec/memory-internal.h index 98d8296..4162474 100644 --- a/include/exec/memory-internal.h +++ b/include/exec/memory-internal.h @@ -1,5 +1,5 @@ /* - * Declarations for obsolete exec.c functions + * Declarations for functions which are internal to the memory subsystem. * * Copyright 2011 Red Hat, Inc. and/or its affiliates * @@ -12,8 +12,9 @@ */ /* - * This header is for use by exec.c and memory.c ONLY. Do not include it. - * The functions declared here will be removed soon. + * This header is for use by exec.c, memory.c and accel/tcg/cputlb.c ONLY, + * for declarations which are shared between the memory subsystem's + * internals and the TCG TLB code. Do not include it from elsewhere. */ #ifndef MEMORY_INTERNAL_H