From patchwork Mon Jun 13 17:05:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Hajnoczi X-Patchwork-Id: 69904 Delivered-To: patch@linaro.org Received: by 10.140.106.246 with SMTP id e109csp1648057qgf; Mon, 13 Jun 2016 10:15:48 -0700 (PDT) X-Received: by 10.200.40.181 with SMTP id i50mr14693300qti.89.1465838148127; Mon, 13 Jun 2016 10:15:48 -0700 (PDT) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id u63si5396105qkh.176.2016.06.13.10.15.48 for (version=TLS1 cipher=AES128-SHA bits=128/128); Mon, 13 Jun 2016 10:15:48 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:57940 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCVSl-00029P-M9 for patch@linaro.org; Mon, 13 Jun 2016 13:15:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCVJD-0001X2-1U for qemu-devel@nongnu.org; Mon, 13 Jun 2016 13:05:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCVJ7-0001rH-63 for qemu-devel@nongnu.org; Mon, 13 Jun 2016 13:05:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCVJ7-0001r5-0E for qemu-devel@nongnu.org; Mon, 13 Jun 2016 13:05:49 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9B57985540; Mon, 13 Jun 2016 17:05:48 +0000 (UTC) Received: from localhost (ovpn-112-61.ams2.redhat.com [10.36.112.61]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5DH5lZP028943; Mon, 13 Jun 2016 13:05:48 -0400 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Date: Mon, 13 Jun 2016 18:05:25 +0100 Message-Id: <1465837535-30067-6-git-send-email-stefanha@redhat.com> In-Reply-To: <1465837535-30067-1-git-send-email-stefanha@redhat.com> References: <1465837535-30067-1-git-send-email-stefanha@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Mon, 13 Jun 2016 17:05:48 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: [Qemu-devel] [PATCH v3 05/15] target-i386: Add comment about do_interrupt_user() next_eip argument X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , Fam Zheng , Jeff Cody , mreitz@redhat.com, jjherne@linux.vnet.ibm.com, Paolo Bonzini Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell Add a comment to do_interrupt_user() along the same lines as the existing one for do_interrupt_all() noting that the next_eip argument is not used unless is_int is true or intno is EXCP_SYSCALL. Signed-off-by: Peter Maydell Reviewed-by: Sergey Fedorov Acked-by: Eduardo Habkost Acked-by: Riku Voipio Message-id: 1463494687-25947-6-git-send-email-peter.maydell@linaro.org --- target-i386/seg_helper.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.5.5 diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c index 97aee09..6cbdf17 100644 --- a/target-i386/seg_helper.c +++ b/target-i386/seg_helper.c @@ -1129,7 +1129,11 @@ static void do_interrupt_real(CPUX86State *env, int intno, int is_int, } #if defined(CONFIG_USER_ONLY) -/* fake user mode interrupt */ +/* fake user mode interrupt. is_int is TRUE if coming from the int + * instruction. next_eip is the env->eip value AFTER the interrupt + * instruction. It is only relevant if is_int is TRUE or if intno + * is EXCP_SYSCALL. + */ static void do_interrupt_user(CPUX86State *env, int intno, int is_int, int error_code, target_ulong next_eip) {