From patchwork Thu May 19 15:24:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Corey Minyard X-Patchwork-Id: 68170 Delivered-To: patch@linaro.org Received: by 10.140.92.199 with SMTP id b65csp3289531qge; Thu, 19 May 2016 09:09:34 -0700 (PDT) X-Received: by 10.140.25.193 with SMTP id 59mr14803590qgt.77.1463674174382; Thu, 19 May 2016 09:09:34 -0700 (PDT) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id m125si13170537qhc.127.2016.05.19.09.09.34 for (version=TLS1 cipher=AES128-SHA bits=128/128); Thu, 19 May 2016 09:09:34 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org Received: from localhost ([::1]:51198 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3QVx-0005VG-Qi for patch@linaro.org; Thu, 19 May 2016 12:09:33 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42123) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3Po9-0007Dn-EX for qemu-devel@nongnu.org; Thu, 19 May 2016 11:24:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3Po3-0001Bc-Cz for qemu-devel@nongnu.org; Thu, 19 May 2016 11:24:17 -0400 Received: from mail-oi0-x244.google.com ([2607:f8b0:4003:c06::244]:33231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3Po3-0001BW-6h for qemu-devel@nongnu.org; Thu, 19 May 2016 11:24:11 -0400 Received: by mail-oi0-x244.google.com with SMTP id t140so17393184oie.0 for ; Thu, 19 May 2016 08:24:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=Ni2FbOXl9Pg3w+2sWmDGaYIEkvVS0G6MgKp1gpfyLL0=; b=FyeybnBpxVhTmSEyu6jvDQ9nzULlY7hONf5UEL7wyHJmHGvq34J2Q67BrnV+yKD/j3 PWyz/EzZt+APSNmwFgQQaxh7e9wIEYQ1DfgseitNIqlUlcx6639LMfbuIhfOiOl4MeKt SCa/ewVj8xHQxlcPC8VEf8ffv9Kba62+8IaP6VQ30PlRcPYkfg+MLJJByat2Td4iqLRV x0aND3rn3/Ene6Fc/07G1LKDljt3cHVZpcn4Jc+UOeQ2FnWpR01FQa8MINovxZ0+qQp8 q6fcFJppYQWWNpHit3j3r29NMKXwsjMI0Jhi5hPteZIEMueiP19jt8EbVFUD+SKFNnNY AWfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=Ni2FbOXl9Pg3w+2sWmDGaYIEkvVS0G6MgKp1gpfyLL0=; b=Fc7GmPLboVcqDNa9mXADhjZ2D4HFFH2XAjBXdU4W/cS+Pxk212TamFAyz6l9fI9lvX jQ4l8NYHX69M42ViwbDcp8H7d4nlaTgDR46RDsFnYqQic3Ma15UYMfMlBjiyWyTaUgTB ypoWOCfiDwWY0hW3jHtVhcqPLZoHw5QrbMPpRcwcb5PGWzSfY/U2jSkizws4AI739Hcz UXv1QmannYzH0IoBqQwVd/4eAYN5VwPvSojsU0B7pp/JswsqrY0pMxoaxqUCI3gD3hmp JneQCTfxZe+aCVThpd5n5QzBMocxUU963bh8uxF6n4r7jd/3OHpSd4Sp3kzyis7zpKUt 1F8Q== X-Gm-Message-State: AOPr4FUTMjlsOU1xJm3MAK+D0/zkuI8RN1nikeIP6FNdcLaAIjj9hXAewK7hduIJ3Ta7DA== X-Received: by 10.157.42.199 with SMTP id e65mr8458269otb.135.1463671450835; Thu, 19 May 2016 08:24:10 -0700 (PDT) Received: from serve.minyard.net ([108.19.215.157]) by smtp.gmail.com with ESMTPSA id 93sm3967263otf.9.2016.05.19.08.24.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 May 2016 08:24:09 -0700 (PDT) Received: from t430.minyard.net (unknown [IPv6:2001:470:b8f6:1b:3cf1:867e:3c35:3c1b]) by serve.minyard.net (Postfix) with ESMTPA id 50B141D62; Thu, 19 May 2016 10:24:06 -0500 (CDT) Received: by t430.minyard.net (Postfix, from userid 1000) id 804CB300552; Thu, 19 May 2016 10:24:04 -0500 (CDT) From: minyard@acm.org To: Igor Mammedov , "Michael S . Tsirkin" , Paolo Bonzini , qemu-devel@nongnu.org, minyard@acm.org, cminyard@mvista.com Date: Thu, 19 May 2016 10:24:00 -0500 Message-Id: <1463671442-15631-5-git-send-email-minyard@acm.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1463671442-15631-1-git-send-email-minyard@acm.org> References: <1463671442-15631-1-git-send-email-minyard@acm.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c06::244 Subject: [Qemu-devel] [PATCH v5 4/6] ipmi: Add SMBIOS table entry X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" From: Corey Minyard Add an IPMI table entry to the SMBIOS. Signed-off-by: Corey Minyard Acked-by: Michael S. Tsirkin --- hw/smbios/Makefile.objs | 2 + hw/smbios/ipmi.c | 114 +++++++++++++++++++++++++++++++++++++++++++++++ hw/smbios/noipmi.c | 14 ++++++ hw/smbios/smbios.c | 2 + include/hw/smbios/ipmi.h | 15 +++++++ 5 files changed, 147 insertions(+) create mode 100644 hw/smbios/ipmi.c create mode 100644 hw/smbios/noipmi.c create mode 100644 include/hw/smbios/ipmi.h -- 2.7.4 diff --git a/hw/smbios/Makefile.objs b/hw/smbios/Makefile.objs index f69a92f..5578f51 100644 --- a/hw/smbios/Makefile.objs +++ b/hw/smbios/Makefile.objs @@ -1 +1,3 @@ common-obj-$(CONFIG_SMBIOS) += smbios.o +common-obj-$(call land,$(CONFIG_SMBIOS),$(CONFIG_IPMI)) += ipmi.o +common-obj-$(call land,$(CONFIG_SMBIOS),$(call lnot,$(CONFIG_IPMI))) += noipmi.o diff --git a/hw/smbios/ipmi.c b/hw/smbios/ipmi.c new file mode 100644 index 0000000..fd524b8 --- /dev/null +++ b/hw/smbios/ipmi.c @@ -0,0 +1,114 @@ +/* + * IPMI SMBIOS firmware handling + * + * Copyright (c) 2015 Corey Minyard, MontaVista Software, LLC + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + */ + +#include "qemu/osdep.h" +#include "hw/ipmi/ipmi.h" +#include "hw/smbios/ipmi.h" +#include "hw/smbios/smbios.h" +#include "qemu/error-report.h" +#include "smbios_build.h" + +/* SMBIOS type 38 - IPMI */ +struct smbios_type_38 { + struct smbios_structure_header header; + uint8_t interface_type; + uint8_t ipmi_spec_revision; + uint8_t i2c_slave_address; + uint8_t nv_storage_device_address; + uint64_t base_address; + uint8_t base_address_modifier; + uint8_t interrupt_number; +} QEMU_PACKED; + +static void ipmi_encode_one_smbios(IPMIFwInfo *info) +{ + uint64_t baseaddr = info->base_address; + SMBIOS_BUILD_TABLE_PRE(38, 0x3000, true); + + t->interface_type = info->interface_type; + t->ipmi_spec_revision = ((info->ipmi_spec_major_revision << 4) + | info->ipmi_spec_minor_revision); + t->i2c_slave_address = info->i2c_slave_address; + t->nv_storage_device_address = 0; + + /* or 1 to set it to I/O space */ + switch (info->memspace) { + case IPMI_MEMSPACE_IO: + baseaddr |= 1; + break; + case IPMI_MEMSPACE_MEM32: + case IPMI_MEMSPACE_MEM64: + break; + case IPMI_MEMSPACE_SMBUS: + baseaddr <<= 1; + break; + } + + t->base_address = cpu_to_le64(baseaddr); + + t->base_address_modifier = 0; + if (info->irq_type == IPMI_LEVEL_IRQ) { + t->base_address_modifier |= 1; + } + switch (info->register_spacing) { + case 1: + break; + case 4: + t->base_address_modifier |= 1 << 6; + break; + case 16: + t->base_address_modifier |= 2 << 6; + break; + default: + error_report("IPMI register spacing %d is not compatible with" + " SMBIOS, ignoring this entry.", info->register_spacing); + return; + } + t->interrupt_number = info->interrupt_number; + + SMBIOS_BUILD_TABLE_POST; +} + +static void search_for_ipmi_dev(BusState *bus) +{ + BusChild *kid; + + QTAILQ_FOREACH(kid, &bus->children, sibling) { + DeviceState *dev = kid->child; + Object *obj = object_dynamic_cast(OBJECT(dev), TYPE_IPMI_INTERFACE); + BusState *childbus; + + if (obj) { + IPMIInterface *ii; + IPMIInterfaceClass *iic; + IPMIFwInfo info; + + ii = IPMI_INTERFACE(obj); + iic = IPMI_INTERFACE_GET_CLASS(obj); + memset(&info, 0, sizeof(info)); + iic->get_fwinfo(ii, &info); + ipmi_encode_one_smbios(&info); + continue; + } + + QLIST_FOREACH(childbus, &dev->child_bus, sibling) { + search_for_ipmi_dev(childbus); + } + } +} + +void smbios_build_type_38_table(void) +{ + BusState *bus; + + bus = sysbus_get_default(); + if (bus) { + search_for_ipmi_dev(bus); + } +} diff --git a/hw/smbios/noipmi.c b/hw/smbios/noipmi.c new file mode 100644 index 0000000..ad669a4 --- /dev/null +++ b/hw/smbios/noipmi.c @@ -0,0 +1,14 @@ +/* + * IPMI SMBIOS firmware handling + * + * Copyright (c) 2015 Corey Minyard, MontaVista Software, LLC + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + */ + +#include "hw/smbios/ipmi.h" + +void smbios_build_type_38_table(void) +{ +} diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index 5dc3e43..74c7102 100644 --- a/hw/smbios/smbios.c +++ b/hw/smbios/smbios.c @@ -25,6 +25,7 @@ #include "hw/loader.h" #include "exec/cpu-common.h" #include "smbios_build.h" +#include "hw/smbios/ipmi.h" /* legacy structures and constants for <= 2.0 machines */ struct smbios_header { @@ -848,6 +849,7 @@ void smbios_get_tables(const struct smbios_phys_mem_area *mem_array, } smbios_build_type_32_table(); + smbios_build_type_38_table(); smbios_build_type_127_table(); smbios_validate_table(); diff --git a/include/hw/smbios/ipmi.h b/include/hw/smbios/ipmi.h new file mode 100644 index 0000000..fd53c96 --- /dev/null +++ b/include/hw/smbios/ipmi.h @@ -0,0 +1,15 @@ +/* + * IPMI SMBIOS firmware handling + * + * Copyright (c) 2015 Corey Minyard, MontaVista Software, LLC + * + * This work is licensed under the terms of the GNU GPL, version 2 or later. + * See the COPYING file in the top-level directory. + */ + +#ifndef QEMU_SMBIOS_IPMI_H +#define QEMU_SMBIOS_IPMI_H + +void smbios_build_type_38_table(void); + +#endif /* QEMU_SMBIOS_IPMI_H */