From patchwork Fri Feb 19 13:17:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Auger Eric X-Patchwork-Id: 62338 Delivered-To: patches@linaro.org Received: by 10.112.43.199 with SMTP id y7csp1163088lbl; Fri, 19 Feb 2016 05:17:37 -0800 (PST) X-Received: by 10.28.136.139 with SMTP id k133mr9391998wmd.103.1455887857414; Fri, 19 Feb 2016 05:17:37 -0800 (PST) Return-Path: Received: from mail-wm0-x234.google.com (mail-wm0-x234.google.com. [2a00:1450:400c:c09::234]) by mx.google.com with ESMTPS id g2si17853717wje.67.2016.02.19.05.17.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 19 Feb 2016 05:17:37 -0800 (PST) Received-SPF: pass (google.com: domain of eric.auger@linaro.org designates 2a00:1450:400c:c09::234 as permitted sender) client-ip=2a00:1450:400c:c09::234; Authentication-Results: mx.google.com; spf=pass (google.com: domain of eric.auger@linaro.org designates 2a00:1450:400c:c09::234 as permitted sender) smtp.mailfrom=eric.auger@linaro.org; dkim=pass header.i=@linaro.org Received: by mail-wm0-x234.google.com with SMTP id g62so75707279wme.1 for ; Fri, 19 Feb 2016 05:17:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+hgoi7lk5JE8yuGudR8QMBPqLwGzMQ6m4XeCvTw2G6A=; b=dk4k6AF0VFS1jEqwXK96Zynf7p4yWWkCKK9N9lwk4qNSktVC303ubZ/6GjFXKmE0j1 ZnrpPkkLJ4zTTrgU2eCribUNREK+v2L/3JS44J/GqznT6/CGs4+Td8R7G5ONLPKD/5o6 ohKQfx4YhBgAMAlkawbhB+InyUPFqlSnBt+hI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=+hgoi7lk5JE8yuGudR8QMBPqLwGzMQ6m4XeCvTw2G6A=; b=H/SftA1yrQOLr7hIxrLCOqkSrI219L9ui8V3MqGxVpmNOi4MM1JU5GKGmENrM7jZ9d xPbPPLWjbKimwq05VLwoSBe3LC2gfuLGjJ3TtkxQ090mOWPEkytdbvwHjie+0qyZhvn+ FjwC9bEW0yjU57bW3CB3r8yobG/GZ2W5FHqA04cQaJW1t0ukCIeglBGqyV5TJrTi1NQA 1re/YLyeO8mv5rvMLNu6UzgsND3V/OOidrRcK1A6j9uAOikm8XVDgkTF/sgsSf2vH7pA 22Yyha/cGafL0Vy4GCZjmc3GCnJc9zZlp02l3vcv50L+ujr5BR7yxhkjJO3yenk1kszh amoQ== X-Gm-Message-State: AG10YOT94+pmbvC4ct46VrVb9kaXvosdab00en7cxMdUVTfj3SF0tdpdgYEVs02er0GdKPWDmlg= X-Received: by 10.28.158.198 with SMTP id h189mr8988357wme.74.1455887857186; Fri, 19 Feb 2016 05:17:37 -0800 (PST) Return-Path: Received: from midway01-04-00.lavalab ([81.128.185.50]) by smtp.gmail.com with ESMTPSA id bg1sm11229846wjc.27.2016.02.19.05.17.35 (version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 19 Feb 2016 05:17:35 -0800 (PST) From: Eric Auger To: eric.auger@st.com, eric.auger@linaro.org, qemu-devel@nongnu.org, qemu-arm@nongnu.org, peter.maydell@linaro.org, alex.williamson@redhat.com, david@gibson.dropbear.id.au Cc: christoffer.dall@linaro.org, suravee.suthikulpanit@amd.com, alex.bennee@linaro.org, thuth@redhat.com, crosthwaitepeter@gmail.com, patches@linaro.org, pbonzini@redhat.com, b.reynal@virtualopensystems.com, thomas.lendacky@amd.com Subject: [PATCH v8 8/8] hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check Date: Fri, 19 Feb 2016 13:17:13 +0000 Message-Id: <1455887833-7306-9-git-send-email-eric.auger@linaro.org> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1455887833-7306-1-git-send-email-eric.auger@linaro.org> References: <1455887833-7306-1-git-send-email-eric.auger@linaro.org> qemu_fdt_setprop asserts in case of error hence no need to check the returned value. Signed-off-by: Eric Auger Reviewed-by: Peter Maydell --- v6 -> v7: - add Peter's R-b v3 -> v4: fix returned value --- hw/arm/sysbus-fdt.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) -- 1.8.3.2 diff --git a/hw/arm/sysbus-fdt.c b/hw/arm/sysbus-fdt.c index 9920388..04afeae 100644 --- a/hw/arm/sysbus-fdt.c +++ b/hw/arm/sysbus-fdt.c @@ -217,7 +217,7 @@ static int add_calxeda_midway_xgmac_fdt_node(SysBusDevice *sbdev, void *opaque) PlatformBusDevice *pbus = data->pbus; void *fdt = data->fdt; const char *parent_node = data->pbus_node_name; - int compat_str_len, i, ret = -1; + int compat_str_len, i; char *nodename; uint32_t *irq_attr, *reg_attr; uint64_t mmio_base, irq_number; @@ -242,12 +242,8 @@ static int add_calxeda_midway_xgmac_fdt_node(SysBusDevice *sbdev, void *opaque) reg_attr[2 * i + 1] = cpu_to_be32( memory_region_size(&vdev->regions[i]->mem)); } - ret = qemu_fdt_setprop(fdt, nodename, "reg", reg_attr, - vbasedev->num_regions * 2 * sizeof(uint32_t)); - if (ret) { - error_report("could not set reg property of node %s", nodename); - goto fail_reg; - } + qemu_fdt_setprop(fdt, nodename, "reg", reg_attr, + vbasedev->num_regions * 2 * sizeof(uint32_t)); irq_attr = g_new(uint32_t, vbasedev->num_irqs * 3); for (i = 0; i < vbasedev->num_irqs; i++) { @@ -257,17 +253,12 @@ static int add_calxeda_midway_xgmac_fdt_node(SysBusDevice *sbdev, void *opaque) irq_attr[3 * i + 1] = cpu_to_be32(irq_number); irq_attr[3 * i + 2] = cpu_to_be32(GIC_FDT_IRQ_FLAGS_LEVEL_HI); } - ret = qemu_fdt_setprop(fdt, nodename, "interrupts", + qemu_fdt_setprop(fdt, nodename, "interrupts", irq_attr, vbasedev->num_irqs * 3 * sizeof(uint32_t)); - if (ret) { - error_report("could not set interrupts property of node %s", - nodename); - } g_free(irq_attr); -fail_reg: g_free(reg_attr); g_free(nodename); - return ret; + return 0; } /* AMD xgbe properties whose values are copied/pasted from host */