From patchwork Mon Nov 2 10:39:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Graeme Gregory X-Patchwork-Id: 55871 Delivered-To: patch@linaro.org Received: by 10.112.61.134 with SMTP id p6csp1194238lbr; Mon, 2 Nov 2015 02:40:22 -0800 (PST) X-Received: by 10.55.79.68 with SMTP id d65mr28595095qkb.35.1446460822657; Mon, 02 Nov 2015 02:40:22 -0800 (PST) Return-Path: Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id f18si17527894qgd.56.2015.11.02.02.40.22 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 02 Nov 2015 02:40:22 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Authentication-Results: mx.google.com; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) smtp.mailfrom=qemu-devel-bounces+patch=linaro.org@nongnu.org; dkim=fail header.i=@linaro_org.20150623.gappssmtp.com Received: from localhost ([::1]:41312 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtCXG-0003FC-8F for patch@linaro.org; Mon, 02 Nov 2015 05:40:22 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45929) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtCWp-0002ur-0S for qemu-devel@nongnu.org; Mon, 02 Nov 2015 05:39:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtCWl-00035S-Ps for qemu-devel@nongnu.org; Mon, 02 Nov 2015 05:39:54 -0500 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:38505) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtCWl-00035K-Jr for qemu-devel@nongnu.org; Mon, 02 Nov 2015 05:39:51 -0500 Received: by wicll6 with SMTP id ll6so46882986wic.1 for ; Mon, 02 Nov 2015 02:39:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro_org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=vtvcmIDy30/g7/lcxZ0zCbLItaAOMYdvjyjLI7s97qc=; b=HoM/ne616l8yhPt2miKzrnRBYrizFjEK4OxEqDRwQw8Ef3Gaso9YDAPANFz71qBpQf T/IIoYnxHNFfH6N0dc1U69gS/ucz4niRtHbWshfauICygkgZkqXklqBdHxh0zvAqE9/r KnJbDY/lPwPGej7py2RHV2koI/DQb/Z2XTrnxXHjzavL8p2Wn9/7ch3hofWrU3q1UtNh 7e15aK9yY9fCBc4SL9NJnPduszScktVkGGWGabtiZG8l+9Opr3ES/8UxWsHLYcyfhRr7 H6fUaGBxWMWYjSiKqPOx9G3j9Gt55w/HYD61IOewfhMFuh4j07hWGVhw9cLw11gHNDJd K7wQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vtvcmIDy30/g7/lcxZ0zCbLItaAOMYdvjyjLI7s97qc=; b=QzHzju4HDRJ3PzgQzdmjbOLBLTbcHc4KuDBNEf5uBhMG5lwVOhuqAcIQ3289qhgf8/ CT6KlAECyWoZ3/qXNEPYYCiLM6D5KpXygdrHoph/KH//NXzG5wIlaRks0QTq8Gj6k3M9 PyXFx+aFYu8KntVRTVT2sgmqehi+gVBC2YJfNI6Xj05DXSSbLkRJogBAdGGjjv/BBqs3 9qSw666yv1MQ/pLHRp6H7+n3FSncazN7p6MQixkG4Wcf48PS/QGoVuvMqSUEsFAo94lE tl/A1okNXkvVJ7jOnWf1bfvqFlc0OY6kGKroDfEuoI59eqiHQlay7ChloC6UnblS5/SG dqnQ== X-Gm-Message-State: ALoCoQnO9k1lS7bVmdaFxVxYqKsho5FoUuoqPL2U+GG9DvUyts9iJ4L1gKgBd0LtY3ZONkxb03y2 X-Received: by 10.194.48.5 with SMTP id h5mr26772720wjn.41.1446460790802; Mon, 02 Nov 2015 02:39:50 -0800 (PST) Received: from xora-haswell.xora.org.uk.xora.org.uk (79-66-20-59.dynamic.dsl.as9105.com. [79.66.20.59]) by smtp.gmail.com with ESMTPSA id cr5sm21550681wjb.16.2015.11.02.02.39.49 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Nov 2015 02:39:50 -0800 (PST) From: Graeme Gregory To: qemu-devel@nongnu.org Date: Mon, 2 Nov 2015 10:39:46 +0000 Message-Id: <1446460786-13663-1-git-send-email-graeme.gregory@linaro.org> X-Mailer: git-send-email 2.4.3 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::22d Cc: Graeme Gregory , shannon.zhao@linaro.org, tomasz.nowicki@linaro.org Subject: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: _CCA attribute is compulsary X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org According to ACPI specification 6.2.17 _CCA (Cache Coherency Attribute) this attribute is compulsary on ARM systems. Add this attribute to the PCI host bridges as required. Without this the kernel will produce the error [Firmware Bug]: PCI device 0000:00:00.0 fail to setup DMA. Signed-off-by: Graeme Gregory --- hw/arm/virt-acpi-build.c | 1 + 1 file changed, 1 insertion(+) -- 2.4.3 Reviewed-by: Shannon Zhao diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index 1aaff1f..1430125 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -180,6 +180,7 @@ static void acpi_dsdt_add_pci(Aml *scope, const MemMapEntry *memmap, int irq, aml_append(dev, aml_name_decl("_ADR", aml_int(0))); aml_append(dev, aml_name_decl("_UID", aml_string("PCI0"))); aml_append(dev, aml_name_decl("_STR", aml_unicode("PCIe 0 Device"))); + aml_append(dev, aml_name_decl("_CCA", aml_int(1))); /* Declare the PCI Routing Table. */ Aml *rt_pkg = aml_package(nr_pcie_buses * PCI_NUM_PINS);