From patchwork Wed Oct 21 17:51:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Roth X-Patchwork-Id: 55395 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f198.google.com (mail-wi0-f198.google.com [209.85.212.198]) by patches.linaro.org (Postfix) with ESMTPS id 476F423024 for ; Wed, 21 Oct 2015 18:11:45 +0000 (UTC) Received: by wiyb4 with SMTP id b4sf23688085wiy.2 for ; Wed, 21 Oct 2015 11:11:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=UFmzzyN1ASTXQqa01AW2oiE5kBJ/mqDhQfLYOdPgCXM=; b=NwPCERpC9pE2YSaCLL/WvleVpZh4bXvhiSz6vQ3mvvwDqHqSyc2Qj3b9HCr55Nx56T 9ceQ3MNKeyIhiw84Swn0zQ0Auyg3bdbWED4W80vvM2euwlpBTF2YIF1/rMcCHU3RDcRV 7Vhjju7n4cPIfTsYf4wuUGRpgw2+G+pYL+94hyWBTkuzHEtkCb2iaMHqs9eHqcHbjNKM U9VyCmu9zhR6wCuvcqxPKeb3lfmZ/wrD07AbCqEfYGrtxgZ3+O0DpLC0eMJUsKMlR9lM KEGZEYBoNej5yIY7Brq+cUsyupkCym75AeSrJd7zSWVWOVGNstICnac/o8FPfOwYl/xp xjYg== X-Gm-Message-State: ALoCoQnLYuFr10tzVbsk0FKiMh2CQ7qyG9Pt7I5lywb5eQHfFhYDQbYviskTb6okjpEb/zVNxutT X-Received: by 10.112.16.229 with SMTP id j5mr2511077lbd.6.1445451104531; Wed, 21 Oct 2015 11:11:44 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.25.212.195 with SMTP id l186ls232698lfg.67.gmail; Wed, 21 Oct 2015 11:11:44 -0700 (PDT) X-Received: by 10.112.72.99 with SMTP id c3mr4674220lbv.113.1445451104342; Wed, 21 Oct 2015 11:11:44 -0700 (PDT) Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com. [209.85.217.181]) by mx.google.com with ESMTPS id o196si7301382lfb.9.2015.10.21.11.11.44 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Oct 2015 11:11:44 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) client-ip=209.85.217.181; Received: by lbbwb3 with SMTP id wb3so44588142lbb.1 for ; Wed, 21 Oct 2015 11:11:44 -0700 (PDT) X-Received: by 10.112.202.35 with SMTP id kf3mr6285360lbc.19.1445451104176; Wed, 21 Oct 2015 11:11:44 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.59.35 with SMTP id w3csp135474lbq; Wed, 21 Oct 2015 11:11:43 -0700 (PDT) X-Received: by 10.55.204.143 with SMTP id n15mr12950458qkl.16.1445451103161; Wed, 21 Oct 2015 11:11:43 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 90si9214591qgi.80.2015.10.21.11.11.42 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 21 Oct 2015 11:11:43 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:53333 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoxrS-0003Vb-Pr for patch@linaro.org; Wed, 21 Oct 2015 14:11:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44258) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zoxbd-0006JS-89 for qemu-devel@nongnu.org; Wed, 21 Oct 2015 13:55:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZoxbY-0006qm-8o for qemu-devel@nongnu.org; Wed, 21 Oct 2015 13:55:21 -0400 Received: from e19.ny.us.ibm.com ([129.33.205.209]:57778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZoxbY-0006qd-1O for qemu-devel@nongnu.org; Wed, 21 Oct 2015 13:55:16 -0400 Received: from localhost by e19.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 21 Oct 2015 13:55:09 -0400 Received: from d01dlp01.pok.ibm.com (9.56.250.166) by e19.ny.us.ibm.com (146.89.104.206) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 21 Oct 2015 13:55:08 -0400 X-IBM-Helo: d01dlp01.pok.ibm.com X-IBM-MailFrom: mdroth@linux.vnet.ibm.com X-IBM-RcptTo: qemu-devel@nongnu.org;qemu-stable@nongnu.org Received: from b01cxnp22036.gho.pok.ibm.com (b01cxnp22036.gho.pok.ibm.com [9.57.198.26]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id 2530438C806E; Wed, 21 Oct 2015 13:55:07 -0400 (EDT) Received: from d01av01.pok.ibm.com (d01av01.pok.ibm.com [9.56.224.215]) by b01cxnp22036.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t9LHt71m59637842; Wed, 21 Oct 2015 17:55:07 GMT Received: from d01av01.pok.ibm.com (localhost [127.0.0.1]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t9LHt64b026499; Wed, 21 Oct 2015 13:55:06 -0400 Received: from localhost ([9.80.97.229]) by d01av01.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t9LHt6u0026362; Wed, 21 Oct 2015 13:55:06 -0400 From: Michael Roth To: qemu-devel@nongnu.org Date: Wed, 21 Oct 2015 12:51:33 -0500 Message-Id: <1445449930-23525-4-git-send-email-mdroth@linux.vnet.ibm.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1445449930-23525-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1445449930-23525-1-git-send-email-mdroth@linux.vnet.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15102117-0057-0000-0000-0000020C76B0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 129.33.205.209 Cc: Peter Maydell , qemu-stable@nongnu.org, Michael Roth Subject: [Qemu-devel] [PATCH 03/40] target-arm/arm-semi.c: Fix broken SYS_WRITE0 via gdb X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: mdroth@linux.vnet.ibm.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.181 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Peter Maydell A spurious trailing "\n" in the gdb syscall format string used for SYS_WRITE0 meant that gdb would reject the remote syscall, with the effect that the output from the guest was silently dropped. Remove the newline so that gdb accepts the packet. Cc: qemu-stable@nongnu.org Signed-off-by: Peter Maydell (cherry picked from commit 857b55adb77004d9ec9202078b7f1f3a1a076112) Signed-off-by: Michael Roth --- target-arm/arm-semi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/arm-semi.c b/target-arm/arm-semi.c index a2a7369..42522a7 100644 --- a/target-arm/arm-semi.c +++ b/target-arm/arm-semi.c @@ -260,7 +260,7 @@ uint32_t do_arm_semihosting(CPUARMState *env) return (uint32_t)-1; len = strlen(s); if (use_gdb_syscalls()) { - gdb_do_syscall(arm_semi_cb, "write,2,%x,%x\n", args, len); + gdb_do_syscall(arm_semi_cb, "write,2,%x,%x", args, len); ret = env->regs[0]; } else { ret = write(STDERR_FILENO, s, len);