From patchwork Thu Oct 1 14:29:48 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 54371 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f200.google.com (mail-wi0-f200.google.com [209.85.212.200]) by patches.linaro.org (Postfix) with ESMTPS id CC32E205D0 for ; Thu, 1 Oct 2015 14:29:58 +0000 (UTC) Received: by wicmn1 with SMTP id mn1sf9026938wic.1 for ; Thu, 01 Oct 2015 07:29:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=FCJHjczmGJRqqlkRfW0q6eTfxeGgkwfsv5LT1h22W20=; b=Y/RTZF4WKCJQq2GX8LBcoL+I4X+jHeDS+ouvxCZeSkSOp2Fle1FUEugMMk4Q+qdFRE zwlr4DGWph2Bq7kxiiyKE3rOBBKbiYR4zgw4p0OP6NhBaZMLA4QOG4XpI1KOZO1MJZH+ c+MnKnyUynvFA8XERTekLuRztm6Szgu+Ib8VfLElJGmDPsDVbMpyjUzfc5yy3lVGvoPt POmj3YElUdF/+mmLG1aAiavXq94yT6l+9eTRhdxRlinTboiPEvYZHbFbLUvWNhmnkfhK NQ2XjHHSzTQL1I5ybn40uthPC+eAaMbrCjozq9FyS2ldv0hLfRzLnWW3o9FlD5Vr6hfg kscg== X-Gm-Message-State: ALoCoQmNFzWpN91fZrMYW8AwmdqJ0tWPY/boFHQKH1cI2V1WbWbS9VlOJnTdg6VhVXpnTXyxYGwe X-Received: by 10.152.9.65 with SMTP id x1mr1458484laa.7.1443709798087; Thu, 01 Oct 2015 07:29:58 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.25.16.92 with SMTP id f89ls105388lfi.25.gmail; Thu, 01 Oct 2015 07:29:57 -0700 (PDT) X-Received: by 10.25.147.76 with SMTP id v73mr1972962lfd.102.1443709797955; Thu, 01 Oct 2015 07:29:57 -0700 (PDT) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com. [209.85.215.41]) by mx.google.com with ESMTPS id o17si2982240lfo.78.2015.10.01.07.29.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 01 Oct 2015 07:29:57 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by laer8 with SMTP id r8so75703444lae.2 for ; Thu, 01 Oct 2015 07:29:57 -0700 (PDT) X-Received: by 10.25.19.21 with SMTP id j21mr1952267lfi.106.1443709797722; Thu, 01 Oct 2015 07:29:57 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.112.59.35 with SMTP id w3csp648030lbq; Thu, 1 Oct 2015 07:29:56 -0700 (PDT) X-Received: by 10.107.166.79 with SMTP id p76mr11548682ioe.163.1443709794607; Thu, 01 Oct 2015 07:29:54 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id ha9si2502820igb.82.2015.10.01.07.29.53 for (version=TLS1_2 cipher=AES128-SHA256 bits=128/128); Thu, 01 Oct 2015 07:29:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 2001:8b0:1d0::1 as permitted sender) client-ip=2001:8b0:1d0::1; Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1Zherm-0006Yf-PA; Thu, 01 Oct 2015 15:29:50 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Paolo Bonzini , "Edgar E. Iglesias" Subject: [PATCH v2 1/3] exec.c: Don't call cpu_reload_memory_map() from cpu_exec_init() Date: Thu, 1 Oct 2015 15:29:48 +0100 Message-Id: <1443709790-25180-2-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1443709790-25180-1-git-send-email-peter.maydell@linaro.org> References: <1443709790-25180-1-git-send-email-peter.maydell@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Currently we call cpu_reload_memory_map() from cpu_exec_init(), but this is not necessary: * KVM doesn't use the data structures maintained by cpu_reload_memory_map() (the TLB and cpu->memory_dispatch) * for TCG, we will call this function via tcg_commit() either as soon as tcg_cpu_address_space_init() registers the listener, or when the first MemoryRegion is added to the AddressSpace if the AS is empty when we register the listener The unnecessary call is awkward for adding support for multiple address spaces per CPU, so drop it. Signed-off-by: Peter Maydell Reviewed-by: Edgar E. Iglesias --- exec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/exec.c b/exec.c index 47ada31..f048c23 100644 --- a/exec.c +++ b/exec.c @@ -598,7 +598,6 @@ void cpu_exec_init(CPUState *cpu, Error **errp) #ifndef CONFIG_USER_ONLY cpu->as = &address_space_memory; cpu->thread_id = qemu_get_thread_id(); - cpu_reload_memory_map(cpu); #endif #if defined(CONFIG_USER_ONLY)