From patchwork Fri Sep 4 15:05:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 53115 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f199.google.com (mail-wi0-f199.google.com [209.85.212.199]) by patches.linaro.org (Postfix) with ESMTPS id E102C22E23 for ; Fri, 4 Sep 2015 15:18:10 +0000 (UTC) Received: by wicuu12 with SMTP id uu12sf7447229wic.2 for ; Fri, 04 Sep 2015 08:18:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=WrW8NujUY/L+zk93fkz3cwkzeIiJIAWf7NLRmTG+QeQ=; b=cy0WLZCaPg0EQT28SLaT+BEoAgxlWlzjACRGGyvBSSCvPNJQwQkyAjoBTqjwJwpnsR 5WPzZF5Ehjz5GsSoDQmh5z+z+icy5qZPLGORLK9bBsYY8JsPmRQBRBBQRs9QIVrg+FPY ef5g1GnCHJZAWpApIsvcwNwLU/XZr7W0O1Tfjba2J9egaU05V+sbQJu1nIgvhlee/ay5 zyLrc6rz/LwswKN8wwEWtloFIaxoK8j7SXj4pZJ5XWqGtH3LKrePUrMGx+0t/l8TnDen DUHnAI40dkWWDEUZxK18LWFLzZq+ZOlfGdp+74GR7ZBvIvpIwU9FkdjX39b57i8UGxgF yihg== X-Gm-Message-State: ALoCoQldEyShlgFzMmJ66yHOMFYKQW9WTKugs8guqSlgocjocagWxAXi4zThBPpG0CQFPxK0HIFL X-Received: by 10.112.17.106 with SMTP id n10mr1202140lbd.18.1441379889362; Fri, 04 Sep 2015 08:18:09 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.29.170 with SMTP id l10ls361868lah.82.gmail; Fri, 04 Sep 2015 08:18:09 -0700 (PDT) X-Received: by 10.112.138.170 with SMTP id qr10mr4228519lbb.14.1441379889083; Fri, 04 Sep 2015 08:18:09 -0700 (PDT) Received: from mail-la0-f52.google.com (mail-la0-f52.google.com. [209.85.215.52]) by mx.google.com with ESMTPS id dd5si2550220lad.159.2015.09.04.08.18.09 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Sep 2015 08:18:09 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.52 as permitted sender) client-ip=209.85.215.52; Received: by lagj9 with SMTP id j9so15893492lag.2 for ; Fri, 04 Sep 2015 08:18:09 -0700 (PDT) X-Received: by 10.112.166.2 with SMTP id zc2mr4154550lbb.29.1441379889003; Fri, 04 Sep 2015 08:18:09 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.164.42 with SMTP id yn10csp2052569lbb; Fri, 4 Sep 2015 08:18:08 -0700 (PDT) X-Received: by 10.55.201.83 with SMTP id q80mr5903019qki.58.1441379888176; Fri, 04 Sep 2015 08:18:08 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 87si3103676qkx.83.2015.09.04.08.18.07 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 04 Sep 2015 08:18:08 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:60641 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXskh-00050E-9H for patch@linaro.org; Fri, 04 Sep 2015 11:18:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38055) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXsZA-0008U8-Hd for qemu-devel@nongnu.org; Fri, 04 Sep 2015 11:06:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXsZ9-0000rY-Qh for qemu-devel@nongnu.org; Fri, 04 Sep 2015 11:06:12 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:35023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXsZ9-0000iE-Ks for qemu-devel@nongnu.org; Fri, 04 Sep 2015 11:06:11 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1ZXsYu-0006Ei-93 for qemu-devel@nongnu.org; Fri, 04 Sep 2015 16:05:56 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Fri, 4 Sep 2015 16:05:31 +0100 Message-Id: <1441379156-23939-3-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1441379156-23939-1-git-send-email-peter.maydell@linaro.org> References: <1441379156-23939-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Subject: [Qemu-devel] [PULL 02/27] target-arm/arm-semi.c: Fix broken SYS_WRITE0 via gdb X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.52 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 A spurious trailing "\n" in the gdb syscall format string used for SYS_WRITE0 meant that gdb would reject the remote syscall, with the effect that the output from the guest was silently dropped. Remove the newline so that gdb accepts the packet. Cc: qemu-stable@nongnu.org Signed-off-by: Peter Maydell --- target-arm/arm-semi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/arm-semi.c b/target-arm/arm-semi.c index a2a7369..42522a7 100644 --- a/target-arm/arm-semi.c +++ b/target-arm/arm-semi.c @@ -260,7 +260,7 @@ uint32_t do_arm_semihosting(CPUARMState *env) return (uint32_t)-1; len = strlen(s); if (use_gdb_syscalls()) { - gdb_do_syscall(arm_semi_cb, "write,2,%x,%x\n", args, len); + gdb_do_syscall(arm_semi_cb, "write,2,%x,%x", args, len); ret = env->regs[0]; } else { ret = write(STDERR_FILENO, s, len);