From patchwork Fri Sep 4 15:05:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 53096 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f72.google.com (mail-la0-f72.google.com [209.85.215.72]) by patches.linaro.org (Postfix) with ESMTPS id D61EA22E23 for ; Fri, 4 Sep 2015 15:07:17 +0000 (UTC) Received: by laeb10 with SMTP id b10sf8676589lae.1 for ; Fri, 04 Sep 2015 08:07:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=MGCEi41u2+yG8pZQ12oJCQLeaSdAVQ35DRaeJdKp840=; b=fXiDiYYA2TJi7UWQLJEjpMoKAPz7krVV95DgRQBkR2DgRKK76J2zInAu8ph7vQbL89 7td7mwL7QmnrXIbwFjCqP2uR91vtA4sSAjgMkcIrNdEAqog7Kpit00A508rc0Xf9c2aq V6Jtxadc3mtLoj9rOzoYD/+UtP8bwZyW1BxOUeppt7f05Nxjq7sMSbwq/UiPKwNXH89h Sk3aMkx0ENlYsoLISExg3QE/aaVfyYaUqh87Ti7k69AxwAyuLG4hlh8B3MKywMVBcb/j vY2xnfWIftSpgX9QJAdyAqZU1ewLgh4GeJhoZOgECVcAd+uRMc1+PgTZkJGtCmAXf9fX wxJg== X-Gm-Message-State: ALoCoQkEGMwSGzLB2w9cuHUPwyD/b2BorSYF9cYqLtVq601Km1yYc3ewbOHbDBmDCcM7iEZAznb2 X-Received: by 10.112.172.70 with SMTP id ba6mr1163924lbc.1.1441379236642; Fri, 04 Sep 2015 08:07:16 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.204.40 with SMTP id kv8ls341913lac.94.gmail; Fri, 04 Sep 2015 08:07:16 -0700 (PDT) X-Received: by 10.112.185.66 with SMTP id fa2mr4206796lbc.42.1441379236473; Fri, 04 Sep 2015 08:07:16 -0700 (PDT) Received: from mail-la0-f41.google.com (mail-la0-f41.google.com. [209.85.215.41]) by mx.google.com with ESMTPS id tk5si2565450lbb.14.2015.09.04.08.07.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Sep 2015 08:07:16 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) client-ip=209.85.215.41; Received: by laeb10 with SMTP id b10so15677050lae.1 for ; Fri, 04 Sep 2015 08:07:16 -0700 (PDT) X-Received: by 10.112.125.34 with SMTP id mn2mr3828282lbb.76.1441379236316; Fri, 04 Sep 2015 08:07:16 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.164.42 with SMTP id yn10csp2043553lbb; Fri, 4 Sep 2015 08:07:15 -0700 (PDT) X-Received: by 10.140.147.85 with SMTP id 82mr6207611qht.90.1441379235283; Fri, 04 Sep 2015 08:07:15 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id j132si3114493qhc.13.2015.09.04.08.07.14 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 04 Sep 2015 08:07:15 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:60541 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXsaA-0001EJ-Db for patch@linaro.org; Fri, 04 Sep 2015 11:07:14 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXsZ7-0008SZ-UZ for qemu-devel@nongnu.org; Fri, 04 Sep 2015 11:06:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXsZ6-0000pb-TA for qemu-devel@nongnu.org; Fri, 04 Sep 2015 11:06:09 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:35023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXsZ6-0000iE-MJ for qemu-devel@nongnu.org; Fri, 04 Sep 2015 11:06:08 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1ZXsYu-0006FU-Nw for qemu-devel@nongnu.org; Fri, 04 Sep 2015 16:05:56 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Fri, 4 Sep 2015 16:05:43 +0100 Message-Id: <1441379156-23939-15-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1441379156-23939-1-git-send-email-peter.maydell@linaro.org> References: <1441379156-23939-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Subject: [Qemu-devel] [PULL 14/27] arm: Remove hw_error() usages. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.41 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Peter Crosthwaite All of these hw_errors are fatal and indicate something wrong with QEMU implementation. Convert to g_assert_not_reached. Reviewed-by: Peter Maydell Signed-off-by: Peter Crosthwaite Message-id: 169194d09017e5725535d31a1507d454c0043706.1440842587.git.crosthwaite.peter@gmail.com Signed-off-by: Peter Maydell --- target-arm/cpu.c | 4 ++-- target-arm/helper.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/target-arm/cpu.c b/target-arm/cpu.c index 4ba5929..7da29f5 100644 --- a/target-arm/cpu.c +++ b/target-arm/cpu.c @@ -342,7 +342,7 @@ static void arm_cpu_set_irq(void *opaque, int irq, int level) } break; default: - hw_error("arm_cpu_set_irq: Bad interrupt line %d\n", irq); + g_assert_not_reached(); } } @@ -361,7 +361,7 @@ static void arm_cpu_kvm_set_irq(void *opaque, int irq, int level) kvm_irq |= KVM_ARM_IRQ_CPU_FIQ; break; default: - hw_error("arm_cpu_kvm_set_irq: Bad interrupt line %d\n", irq); + g_assert_not_reached(); } kvm_irq |= cs->cpu_index << KVM_ARM_IRQ_VCPU_SHIFT; kvm_set_irq(kvm_state, kvm_irq, level ? 1 : 0); diff --git a/target-arm/helper.c b/target-arm/helper.c index 114d56e..0df4dac 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -4990,7 +4990,7 @@ int bank_number(int mode) case ARM_CPU_MODE_MON: return 7; } - hw_error("bank number requested for bad CPSR mode value 0x%x\n", mode); + g_assert_not_reached(); } void switch_mode(CPUARMState *env, int mode)