From patchwork Thu Aug 13 16:35:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 52400 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f198.google.com (mail-wi0-f198.google.com [209.85.212.198]) by patches.linaro.org (Postfix) with ESMTPS id B27CA22EC6 for ; Thu, 13 Aug 2015 16:36:04 +0000 (UTC) Received: by wilj18 with SMTP id j18sf19130171wil.0 for ; Thu, 13 Aug 2015 09:36:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=rz5YMpByU/pweMUgUgKTr9PJiT2acLqNwjipYQZGvSc=; b=leyEUTKtSytUv00vEfwYmu2OgMQQQU5oe1XsnUL3UnW3Zh0o4fRlINq1cwl6PvZfjK Re95bOr5/D15cVRia9/4AvnlvXWtkL56M9aidw+2HNm6Da4e3v8PWhHPUdQrqDI1WPjW UupHEQ9HiKUmtigBK2Jxd3D/6LXZpc0fE4sBbScLb0ktS4cb9eILETwCwsmaB3F2QcLP bBo7lX6xJDtYXwSufQQUN1wnMZCdnKWCbLUiOVnZkzab9ufXOLM7nYPYyW6NvaDurlt8 svOr947NVh376xKEqOlTHuWpRdyEQJdIfeh93j1L5xScpOKqrMdOmezqj5nL3h1jlvLa IpLw== X-Gm-Message-State: ALoCoQn3kGkh77dwXgpfpTOUt7poJOL3N0RqKeYDhJnmFAqSSeOqMLAAbn0++JrSXg7iW8gveytN X-Received: by 10.180.77.105 with SMTP id r9mr1252650wiw.0.1439483763902; Thu, 13 Aug 2015 09:36:03 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.36.135 with SMTP id q7ls185063laj.77.gmail; Thu, 13 Aug 2015 09:36:03 -0700 (PDT) X-Received: by 10.112.91.196 with SMTP id cg4mr37581349lbb.10.1439483763748; Thu, 13 Aug 2015 09:36:03 -0700 (PDT) Received: from mail-la0-f46.google.com (mail-la0-f46.google.com. [209.85.215.46]) by mx.google.com with ESMTPS id d3si3069601laf.74.2015.08.13.09.36.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Aug 2015 09:36:03 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.46 as permitted sender) client-ip=209.85.215.46; Received: by lalv9 with SMTP id v9so29238472lal.0 for ; Thu, 13 Aug 2015 09:36:03 -0700 (PDT) X-Received: by 10.152.22.133 with SMTP id d5mr30621670laf.112.1439483763661; Thu, 13 Aug 2015 09:36:03 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.112.7.198 with SMTP id l6csp1052714lba; Thu, 13 Aug 2015 09:36:02 -0700 (PDT) X-Received: by 10.68.233.228 with SMTP id tz4mr78903382pbc.152.1439483751424; Thu, 13 Aug 2015 09:35:51 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id my7si4594086pbc.24.2015.08.13.09.35.49 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 13 Aug 2015 09:35:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 2001:8b0:1d0::1 as permitted sender) client-ip=2001:8b0:1d0::1; Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1ZPvTl-0007UG-Fc; Thu, 13 Aug 2015 17:35:45 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Christopher Covington Subject: [PATCH 1/9] target-arm/arm-semi.c: Fix broken SYS_WRITE0 via gdb Date: Thu, 13 Aug 2015 17:35:37 +0100 Message-Id: <1439483745-28752-2-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1439483745-28752-1-git-send-email-peter.maydell@linaro.org> References: <1439483745-28752-1-git-send-email-peter.maydell@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.46 as permitted sender) smtp.mailfrom=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , A spurious trailing "\n" in the gdb syscall format string used for SYS_WRITE0 meant that gdb would reject the remote syscall, with the effect that the output from the guest was silently dropped. Remove the newline so that gdb accepts the packet. Cc: qemu-stable@nongnu.org --- target-arm/arm-semi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/arm-semi.c b/target-arm/arm-semi.c index a2a7369..42522a7 100644 --- a/target-arm/arm-semi.c +++ b/target-arm/arm-semi.c @@ -260,7 +260,7 @@ uint32_t do_arm_semihosting(CPUARMState *env) return (uint32_t)-1; len = strlen(s); if (use_gdb_syscalls()) { - gdb_do_syscall(arm_semi_cb, "write,2,%x,%x\n", args, len); + gdb_do_syscall(arm_semi_cb, "write,2,%x,%x", args, len); ret = env->regs[0]; } else { ret = write(STDERR_FILENO, s, len);