From patchwork Thu Aug 6 11:24:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leif Lindholm X-Patchwork-Id: 52008 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by patches.linaro.org (Postfix) with ESMTPS id 1EC1D20539 for ; Thu, 6 Aug 2015 14:54:13 +0000 (UTC) Received: by labia3 with SMTP id ia3sf6577213lab.1 for ; Thu, 06 Aug 2015 07:54:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:cc:subject:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:errors-to:sender :x-original-sender:x-original-authentication-results:mailing-list; bh=JHQ7a2jp5uw1gDlNPkF6oVihVHCM5ZSm8XIl38HYWHM=; b=g9qbdx3+VDssq75RUZ0UsqfnR3WgIufpZ7F0Ji949qRpnwZAUqNvdnrnL3I8W1V3R0 y2eiTN4Je7iKYt6kBWkjfaBs4Msn5YoCkMXzopHvD3a7jYaK2390fcMid+3eJ2w+ruw/ 0d64GwUEMohHLgiVKJ9WjV/rJNBGr7bHWRrU5r24Oer7wcMNd5VVplicaBJvIZf2WeIx HL67rX7+QaMvZ5JFPs4vsSWMdghH4WDT5cuU/SBT0GW021hcCy5sCiQONSVBF1N4mfAL yYPoQblEX+wj4hXGV8s/82Ih9a98hcV2T+Ystq35Wb+VItoBEgs27EskRhLyEDrxIua4 h7jA== X-Gm-Message-State: ALoCoQmXW3VgyzCDq9ZT5LpTDI6EnNI8BrPU/vP7YB7lpCD3abnGvoGq7AKE7CMuAo9UzwVUcJXF X-Received: by 10.180.106.10 with SMTP id gq10mr1090030wib.0.1438872852076; Thu, 06 Aug 2015 07:54:12 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.206.8 with SMTP id lk8ls43251lac.26.gmail; Thu, 06 Aug 2015 07:54:11 -0700 (PDT) X-Received: by 10.152.22.99 with SMTP id c3mr2406504laf.32.1438872851913; Thu, 06 Aug 2015 07:54:11 -0700 (PDT) Received: from mail-la0-f47.google.com (mail-la0-f47.google.com. [209.85.215.47]) by mx.google.com with ESMTPS id r5si5057252lbp.16.2015.08.06.07.54.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Aug 2015 07:54:11 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.47 as permitted sender) client-ip=209.85.215.47; Received: by labjt7 with SMTP id jt7so33008811lab.0 for ; Thu, 06 Aug 2015 07:54:11 -0700 (PDT) X-Received: by 10.112.133.72 with SMTP id pa8mr2277582lbb.117.1438872851661; Thu, 06 Aug 2015 07:54:11 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.7.198 with SMTP id l6csp997768lba; Thu, 6 Aug 2015 07:54:10 -0700 (PDT) X-Received: by 10.55.33.35 with SMTP id h35mr3440197qkh.75.1438872850253; Thu, 06 Aug 2015 07:54:10 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id f98si12164368qki.125.2015.08.06.07.54.09 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 06 Aug 2015 07:54:10 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:45081 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNKv9-0003OO-G8 for patch@linaro.org; Thu, 06 Aug 2015 09:09:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNJHr-0006uE-BU for qemu-devel@nongnu.org; Thu, 06 Aug 2015 07:24:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZNJHo-00021D-3Y for qemu-devel@nongnu.org; Thu, 06 Aug 2015 07:24:39 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:35318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZNJHn-000214-Tq for qemu-devel@nongnu.org; Thu, 06 Aug 2015 07:24:36 -0400 Received: by wibxm9 with SMTP id xm9so18258852wib.0 for ; Thu, 06 Aug 2015 04:24:34 -0700 (PDT) X-Received: by 10.181.12.111 with SMTP id ep15mr5222163wid.15.1438860274711; Thu, 06 Aug 2015 04:24:34 -0700 (PDT) Received: from mohikan.mushroom.smurfnet.nu (cpc4-cmbg17-2-0-cust71.5-4.cable.virginm.net. [86.14.224.72]) by smtp.gmail.com with ESMTPSA id di7sm2775188wib.23.2015.08.06.04.24.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 06 Aug 2015 04:24:34 -0700 (PDT) From: Leif Lindholm To: qemu-devel@nongnu.org Date: Thu, 6 Aug 2015 12:24:27 +0100 Message-Id: <1438860267-3401-1-git-send-email-leif.lindholm@linaro.org> X-Mailer: git-send-email 2.1.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.212.169 X-Mailman-Approved-At: Thu, 06 Aug 2015 09:06:46 -0400 Cc: drjones@redhat.com, shannon.zhao@linaro.org Subject: [Qemu-devel] [PATCH] hw/arm/virt-acpi-build: drop _ADR entry from SPCR X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: leif.lindholm@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.47 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 The _ADR entry in SPCR is optional and redundant. The same information is already provided in _CRS (which is mandatory). Signed-off-by: Leif Lindholm --- So, this _ADR entry is only consumed by a set of not-widely-circulated patches for the Linux kernel. And while the ARM Server Base Boot Requirements specification mandates SPCR, it does not mandate this _ADR entry. In the interest of not propagating non-standard extensions, I would be really happy if we could consider dropping this from 2.4. I do realize that this is a completely unreasonable request this late in the release process, but I only spotted this yesterday, and it is a very isolated change with very quantifiable effects. The patch at https://git.linaro.org/leg/acpi/leg-kernel.git/commitdiff/46eeec7b7332bdd104941703696d3812afd934c8 converts the non-upstream kernel SPCR handling code to use the _CRS information instead. hw/arm/virt-acpi-build.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index f365140..85eb48c 100644 --- a/hw/arm/virt-acpi-build.c +++ b/hw/arm/virt-acpi-build.c @@ -84,12 +84,6 @@ static void acpi_dsdt_add_uart(Aml *scope, const MemMapEntry *uart_memmap, aml_interrupt(AML_CONSUMER, AML_LEVEL, AML_ACTIVE_HIGH, AML_EXCLUSIVE, uart_irq)); aml_append(dev, aml_name_decl("_CRS", crs)); - - /* The _ADR entry is used to link this device to the UART described - * in the SPCR table, i.e. SPCR.base_address.address == _ADR. - */ - aml_append(dev, aml_name_decl("_ADR", aml_int(uart_memmap->base))); - aml_append(scope, dev); }