From patchwork Fri Jul 3 15:11:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 50639 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 802D922916 for ; Fri, 3 Jul 2015 15:12:11 +0000 (UTC) Received: by laer2 with SMTP id r2sf29355885lae.3 for ; Fri, 03 Jul 2015 08:12:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=12GuyhF/F9Q9NxCK+CeK4+iWaehBKOv7zzXScYECV5E=; b=O3SVMJfk9OgaWU0UOqucih4V9S+Wcw/2Hs8gyMLYKvkthZMciDAG+IjH8+IMij50rQ FnbwxmhX2v+eoVXfLQMipnar4eEoQQpO/TNJUJXTM+G0hJ6sg5qReCuGQWEoU3+U8DG+ DjQpNGLdqg52OGerYtl1+PEUjVL2e4gqjCIoYWvjmpDmatsbFJYlr8k6sU+b9Wsj35NH LnQAMUFjb3zwy1DTYykk60v5D+SbqbGmj3ZWDUkq6IH4+IqrnzW2rBEdfVJBy7Ev9yRE 36xzzDn/ZE+1fYkGxuFTmaJ0lcaMWVb+MSubFimLDW0+jXM19LoT6THnNgc4aGmbVYSi un1w== X-Gm-Message-State: ALoCoQlF/KhVJ3amJMcHUzEt4sUZKflK8CxgV2E56feZrr179c1kqw/1I1affw8rdyBcC34yqZPl X-Received: by 10.112.42.236 with SMTP id r12mr23092096lbl.2.1435936330449; Fri, 03 Jul 2015 08:12:10 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.29.7 with SMTP id f7ls460169lah.48.gmail; Fri, 03 Jul 2015 08:12:10 -0700 (PDT) X-Received: by 10.152.37.67 with SMTP id w3mr36448554laj.123.1435936330309; Fri, 03 Jul 2015 08:12:10 -0700 (PDT) Received: from mail-la0-f43.google.com (mail-la0-f43.google.com. [209.85.215.43]) by mx.google.com with ESMTPS id g1si7467456lbs.32.2015.07.03.08.12.10 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Jul 2015 08:12:10 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.43 as permitted sender) client-ip=209.85.215.43; Received: by lagc2 with SMTP id c2so88793352lag.3 for ; Fri, 03 Jul 2015 08:12:10 -0700 (PDT) X-Received: by 10.112.42.50 with SMTP id k18mr33445992lbl.76.1435936330166; Fri, 03 Jul 2015 08:12:10 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp94436lbb; Fri, 3 Jul 2015 08:12:09 -0700 (PDT) X-Received: by 10.70.124.134 with SMTP id mi6mr78778607pdb.104.1435936311934; Fri, 03 Jul 2015 08:11:51 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id y1si14779842pdf.127.2015.07.03.08.11.50 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 03 Jul 2015 08:11:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 2001:8b0:1d0::1 as permitted sender) client-ip=2001:8b0:1d0::1; Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1ZB2cx-0003zr-B2; Fri, 03 Jul 2015 16:11:43 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Paolo Bonzini , "Edgar E. Iglesias" Subject: [PATCH 1/3] exec.c: Don't call cpu_reload_memory_map() from cpu_exec_init() Date: Fri, 3 Jul 2015 16:11:41 +0100 Message-Id: <1435936303-15335-2-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1435936303-15335-1-git-send-email-peter.maydell@linaro.org> References: <1435936303-15335-1-git-send-email-peter.maydell@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.43 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Currently we call cpu_reload_memory_map() from cpu_exec_init(), but this is not necessary: * KVM doesn't use the data structures maintained by cpu_reload_memory_map() (the TLB and cpu->memory_dispatch) * for TCG, we will call this function via tcg_commit() either as soon as tcg_cpu_address_space_init() registers the listener, or when the first MemoryRegion is added to the AddressSpace if the AS is empty when we register the listener The unnecessary call is awkward for adding support for multiple address spaces per CPU, so drop it. Signed-off-by: Peter Maydell --- exec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/exec.c b/exec.c index f7883d2..2616394 100644 --- a/exec.c +++ b/exec.c @@ -534,7 +534,6 @@ void cpu_exec_init(CPUArchState *env) #ifndef CONFIG_USER_ONLY cpu->as = &address_space_memory; cpu->thread_id = qemu_get_thread_id(); - cpu_reload_memory_map(cpu); #endif QTAILQ_INSERT_TAIL(&cpus, cpu, node); #if defined(CONFIG_USER_ONLY)