From patchwork Thu May 28 12:08:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shannon Zhao X-Patchwork-Id: 49071 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f200.google.com (mail-lb0-f200.google.com [209.85.217.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 675C2218EC for ; Thu, 28 May 2015 12:16:15 +0000 (UTC) Received: by lbbqq2 with SMTP id qq2sf10050676lbb.0 for ; Thu, 28 May 2015 05:16:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:content-type:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=LIrffsZ0+zdEkRRaVAugVr/oIx8ZJqbMQ/HHwNXAxT4=; b=WnkNvP6xloCspU72N5HUFBTTyxcBZx/7Kp5tOYf5aLKBbduMCv3vKJi9MJTzWoQwPZ GONWnOYNjp01uKtOyaKxZqYY+LZ5KWoXEQYev2P0e5/58jEWE/j8qa0XbnDZ/xPwe9ed 75yA/aAHDWwp+oJRTbTUrFmestl40NF9tuJxLCBp+vsZP+grk1FdsvUZfXTw8eSnOzcd fMkG59DctfYViW0Khmv4Mj+GhEpG1qgGGB4hCBwVg3p9nw0fuuIm3xlAaxLphxhNc8Kl H2ZimkJOS8u9k5GRCzTqPCYH40K4HifXVuMQrPQYXvoQCmuI6ZYlXoV9N7kdWM32XuHy TCkA== X-Gm-Message-State: ALoCoQnByyVvONlIpN6nGmAN7cbeKtvpsOxJScj60wpqVJy0pmC+MvDWKCLUsV9ESoBCrnoO+meg X-Received: by 10.180.74.197 with SMTP id w5mr32974518wiv.5.1432815374243; Thu, 28 May 2015 05:16:14 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.153.8.171 with SMTP id dl11ls168170lad.55.gmail; Thu, 28 May 2015 05:16:14 -0700 (PDT) X-Received: by 10.112.54.225 with SMTP id m1mr2553736lbp.34.1432815374111; Thu, 28 May 2015 05:16:14 -0700 (PDT) Received: from mail-lb0-f173.google.com (mail-lb0-f173.google.com. [209.85.217.173]) by mx.google.com with ESMTPS id o2si1812805lbl.51.2015.05.28.05.16.13 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 May 2015 05:16:13 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.173 as permitted sender) client-ip=209.85.217.173; Received: by lbbuc2 with SMTP id uc2so26843503lbb.2 for ; Thu, 28 May 2015 05:16:13 -0700 (PDT) X-Received: by 10.112.204.6 with SMTP id ku6mr2458840lbc.73.1432815373840; Thu, 28 May 2015 05:16:13 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp1109320lbb; Thu, 28 May 2015 05:16:13 -0700 (PDT) X-Received: by 10.55.51.78 with SMTP id z75mr4395036qkz.101.1432815371105; Thu, 28 May 2015 05:16:11 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 143si2194526qhw.9.2015.05.28.05.16.10 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 28 May 2015 05:16:11 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:58343 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxwjK-0002U9-3f for patch@linaro.org; Thu, 28 May 2015 08:16:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58137) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxwe6-0002FE-7m for qemu-devel@nongnu.org; Thu, 28 May 2015 08:10:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yxwe1-0003Yp-Pj for qemu-devel@nongnu.org; Thu, 28 May 2015 08:10:45 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:45241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxwe1-0003Sd-5m; Thu, 28 May 2015 08:10:41 -0400 Received: from 172.24.2.119 (EHLO SZXEML429-HUB.china.huawei.com) ([172.24.2.119]) by szxrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id COP98094; Thu, 28 May 2015 20:10:29 +0800 (CST) Received: from HGHY1Z002260041.china.huawei.com (10.177.16.142) by SZXEML429-HUB.china.huawei.com (10.82.67.184) with Microsoft SMTP Server id 14.3.158.1; Thu, 28 May 2015 20:09:59 +0800 From: Shannon Zhao To: Date: Thu, 28 May 2015 20:08:31 +0800 Message-ID: <1432814932-12608-9-git-send-email-zhaoshenglong@huawei.com> X-Mailer: git-send-email 1.9.0.msysgit.0 In-Reply-To: <1432814932-12608-1-git-send-email-zhaoshenglong@huawei.com> References: <1432814932-12608-1-git-send-email-zhaoshenglong@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.177.16.142] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 58.251.152.64 Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, mjt@tls.msk.ru, shannon.zhao@linaro.org, peter.maydell@linaro.org Subject: [Qemu-devel] [PATCH 08/29] hw/intc/exynos4210_gic.c: Fix memory leak spotted by valgrind X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: patch@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.173 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Shannon Zhao valgrind complains about: ==17211== 784 (288 direct, 496 indirect) bytes in 4 blocks are definitely lost in loss record 3,018 of 3,201 ==17211== at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==17211== by 0x35478F: malloc_and_trace (vl.c:2556) ==17211== by 0x64C770E: g_malloc (in /usr/lib64/libglib-2.0.so.0.3600.3) ==17211== by 0x5148DD: object_new_with_type (object.c:428) ==17211== by 0x514939: object_new (object.c:439) ==17211== by 0x3EDA38: qemu_allocate_irq (irq.c:71) ==17211== by 0x3EDC2D: qemu_irq_split (irq.c:119) ==17211== by 0x23D231: exynos4210_init_board_irqs (exynos4210_gic.c:216) ==17211== by 0x293B00: exynos4210_init (exynos4210.c:250) ==17211== by 0x27915A: exynos4_boards_init_common (exynos4_boards.c:127) ==17211== by 0x2791D9: smdkc210_init (exynos4_boards.c:140) ==17211== by 0x358B5A: main (vl.c:4249) Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/intc/exynos4210_gic.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/intc/exynos4210_gic.c b/hw/intc/exynos4210_gic.c index 0590d5d..b2a4950 100644 --- a/hw/intc/exynos4210_gic.c +++ b/hw/intc/exynos4210_gic.c @@ -213,9 +213,6 @@ void exynos4210_init_board_irqs(Exynos4210Irq *s) uint32_t grp, bit, irq_id, n; for (n = 0; n < EXYNOS4210_MAX_EXT_COMBINER_IN_IRQ; n++) { - s->board_irqs[n] = qemu_irq_split(s->int_combiner_irq[n], - s->ext_combiner_irq[n]); - irq_id = 0; if (n == EXYNOS4210_COMBINER_GET_IRQ_NUM(1, 4) || n == EXYNOS4210_COMBINER_GET_IRQ_NUM(12, 4)) { @@ -230,8 +227,10 @@ void exynos4210_init_board_irqs(Exynos4210Irq *s) if (irq_id) { s->board_irqs[n] = qemu_irq_split(s->int_combiner_irq[n], s->ext_gic_irq[irq_id-32]); + } else { + s->board_irqs[n] = qemu_irq_split(s->int_combiner_irq[n], + s->ext_combiner_irq[n]); } - } for (; n < EXYNOS4210_MAX_INT_COMBINER_IN_IRQ; n++) { /* these IDs are passed to Internal Combiner and External GIC */