From patchwork Thu May 28 12:08:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shannon Zhao X-Patchwork-Id: 49090 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f200.google.com (mail-wi0-f200.google.com [209.85.212.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 34688218EC for ; Thu, 28 May 2015 12:28:33 +0000 (UTC) Received: by wixv7 with SMTP id v7sf13416138wix.0 for ; Thu, 28 May 2015 05:28:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:content-type:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=RGhtCg8rfPR4aTzeqEcM0oyheL0ZwBupBN0bV+yc7Bw=; b=bkflxmzoxqNGAFmWZR7c/9VCXtPQO+bNPkzXQ9q7LhnMYs36c0lAVMUQ9gt+eB242g wv3e/Cjb7081dYEJ1PAm/4GM04S2xZ6T3l/aDq4mksOMNc1txUOk01/IfmR5QecxruSm aZ9yWloRp2igeS35wpo5lt+zWo1OH8lc/REYVxTbyW0P2XtYkbGPu/XOzkqJ5CjRNPgl b9RgND2KGi5hHsWWehk3IbGTvxYVGBwdz/aA0xOgrVQAIdbSLMAbX6YGSSib/utXQ/gQ ANwZihktZJq6NBV1iTF5pZ2KX+rgEQO7OyqLKlXlkfMVbHAHQglzDUVPAdOSsukLUSch V0qA== X-Gm-Message-State: ALoCoQn0vMMp6pSb08/8mXqbA3dIQ9dUtUs8ZsUyF6HaCsVHOSZ290xG8akwznmddGW1/LCIveti X-Received: by 10.152.8.17 with SMTP id n17mr2519757laa.0.1432816112481; Thu, 28 May 2015 05:28:32 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.36.169 with SMTP id r9ls169162laj.86.gmail; Thu, 28 May 2015 05:28:32 -0700 (PDT) X-Received: by 10.152.6.105 with SMTP id z9mr2466790laz.98.1432816112362; Thu, 28 May 2015 05:28:32 -0700 (PDT) Received: from mail-la0-f48.google.com (mail-la0-f48.google.com. [209.85.215.48]) by mx.google.com with ESMTPS id y4si1805675lbj.161.2015.05.28.05.28.32 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 May 2015 05:28:32 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.48 as permitted sender) client-ip=209.85.215.48; Received: by labpy14 with SMTP id py14so18574136lab.0 for ; Thu, 28 May 2015 05:28:32 -0700 (PDT) X-Received: by 10.112.219.70 with SMTP id pm6mr2462286lbc.41.1432816111944; Thu, 28 May 2015 05:28:31 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp1118213lbb; Thu, 28 May 2015 05:28:31 -0700 (PDT) X-Received: by 10.140.130.196 with SMTP id 187mr2946959qhc.12.1432816110769; Thu, 28 May 2015 05:28:30 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id hg6si2182775qcb.46.2015.05.28.05.28.30 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 28 May 2015 05:28:30 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:58491 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxwvF-0002Eg-Ns for patch@linaro.org; Thu, 28 May 2015 08:28:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxwg5-0005lE-H7 for qemu-devel@nongnu.org; Thu, 28 May 2015 08:12:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yxwg1-0004XD-PP for qemu-devel@nongnu.org; Thu, 28 May 2015 08:12:49 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:42876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxwg1-0004Wy-7g; Thu, 28 May 2015 08:12:45 -0400 Received: from 172.24.2.119 (EHLO SZXEML429-HUB.china.huawei.com) ([172.24.2.119]) by szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CMA92694; Thu, 28 May 2015 20:12:35 +0800 (CST) Received: from HGHY1Z002260041.china.huawei.com (10.177.16.142) by SZXEML429-HUB.china.huawei.com (10.82.67.184) with Microsoft SMTP Server id 14.3.158.1; Thu, 28 May 2015 20:10:22 +0800 From: Shannon Zhao To: Date: Thu, 28 May 2015 20:08:50 +0800 Message-ID: <1432814932-12608-28-git-send-email-zhaoshenglong@huawei.com> X-Mailer: git-send-email 1.9.0.msysgit.0 In-Reply-To: <1432814932-12608-1-git-send-email-zhaoshenglong@huawei.com> References: <1432814932-12608-1-git-send-email-zhaoshenglong@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.177.16.142] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 119.145.14.65 Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, mjt@tls.msk.ru, shannon.zhao@linaro.org, peter.maydell@linaro.org Subject: [Qemu-devel] [PATCH 27/29] hw/arm/tosa.c: Fix memory leak spotted by valgrind X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: patch@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.48 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Shannon Zhao valgrind complains about: ==3169== 32 bytes in 1 blocks are definitely lost in loss record 1,705 of 2,779 ==3169== at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==3169== by 0x3547D3: malloc_and_trace (vl.c:2556) ==3169== by 0x64C770E: g_malloc (in /usr/lib64/libglib-2.0.so.0.3600.3) ==3169== by 0x3ED9CF: qemu_extend_irqs (irq.c:55) ==3169== by 0x3EDA5B: qemu_allocate_irqs (irq.c:64) ==3169== by 0x28B2C3: tosa_gpio_setup (tosa.c:93) ==3169== by 0x28B804: tosa_init (tosa.c:241) ==3169== by 0x358B9E: main (vl.c:4249) Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/tosa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/tosa.c b/hw/arm/tosa.c index 73572eb..83eb991 100644 --- a/hw/arm/tosa.c +++ b/hw/arm/tosa.c @@ -112,6 +112,7 @@ static void tosa_gpio_setup(PXA2xxState *cpu, qdev_connect_gpio_out(scp1, TOSA_GPIO_NOTE_LED, outsignals[1]); qdev_connect_gpio_out(scp1, TOSA_GPIO_CHRG_ERR_LED, outsignals[2]); qdev_connect_gpio_out(scp1, TOSA_GPIO_WLAN_LED, outsignals[3]); + g_free(outsignals); qdev_connect_gpio_out(scp1, TOSA_GPIO_TC6393XB_L3V_ON, tc6393xb_l3v_get(tmio));