From patchwork Thu May 28 12:08:40 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shannon Zhao X-Patchwork-Id: 49067 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f72.google.com (mail-la0-f72.google.com [209.85.215.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A5E70218EC for ; Thu, 28 May 2015 12:13:43 +0000 (UTC) Received: by lani11 with SMTP id i11sf10543644lan.3 for ; Thu, 28 May 2015 05:13:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:content-type:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=ZOngrLCrW68ge39KRqZ3KTPmq7pDaYOOVx6IE3fm98s=; b=QidCo9fyB4674JOaRrFrqo+8R5NTSBkLJ3owHK3bxNfxE+RtWYletCWjXWjGbQ6vb0 NGtdP+cSLq44VKgtxgzVTqIMGJookOm/pegpsX+CnqWlzcLNkMMQ2hUfeJJZJIbmS5cE U+s8LJ4qYhSw76RBg7Q612VJQXPEWmANI5OTMfTSC6x+BkSALo6KYV33v3kOu8evEwvv UZpoEdtO1jgQSahzWZbB84ixDCwNmbH8cOwpIlbHTC/whDq60dU76ptlh6VgTvl3ov3f DlG3a2otRmCjizEk4DlS0F1KUX5jSBiWI5vlEV0hvDbSr2jPU8uCEWEUUYT5l/uF/awT efDQ== X-Gm-Message-State: ALoCoQkEW2b66umM3yGyw25WxbY/7dRmg6MZfCSA2HL8+jrbgtX3tm1Mkxb0nsYUpqK76R9fzyqp X-Received: by 10.112.118.162 with SMTP id kn2mr2477547lbb.22.1432815222095; Thu, 28 May 2015 05:13:42 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.44.135 with SMTP id e7ls195866lam.79.gmail; Thu, 28 May 2015 05:13:42 -0700 (PDT) X-Received: by 10.152.45.9 with SMTP id i9mr2395176lam.87.1432815221983; Thu, 28 May 2015 05:13:41 -0700 (PDT) Received: from mail-la0-f46.google.com (mail-la0-f46.google.com. [209.85.215.46]) by mx.google.com with ESMTPS id cn6si1786482lbb.126.2015.05.28.05.13.41 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 May 2015 05:13:41 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.46 as permitted sender) client-ip=209.85.215.46; Received: by labko7 with SMTP id ko7so26394367lab.2 for ; Thu, 28 May 2015 05:13:41 -0700 (PDT) X-Received: by 10.152.4.72 with SMTP id i8mr2552073lai.32.1432815221568; Thu, 28 May 2015 05:13:41 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp1107398lbb; Thu, 28 May 2015 05:13:40 -0700 (PDT) X-Received: by 10.140.92.53 with SMTP id a50mr2735928qge.66.1432815220406; Thu, 28 May 2015 05:13:40 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v108si2188769qge.0.2015.05.28.05.13.39 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 28 May 2015 05:13:40 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:58321 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxwgt-0006S3-Ca for patch@linaro.org; Thu, 28 May 2015 08:13:39 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58135) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxwe6-0002FD-7G for qemu-devel@nongnu.org; Thu, 28 May 2015 08:10:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yxwe0-0003Wi-Tg for qemu-devel@nongnu.org; Thu, 28 May 2015 08:10:45 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:45246) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxwe0-0003VH-3o; Thu, 28 May 2015 08:10:40 -0400 Received: from 172.24.2.119 (EHLO SZXEML429-HUB.china.huawei.com) ([172.24.2.119]) by szxrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id COP98103; Thu, 28 May 2015 20:10:31 +0800 (CST) Received: from HGHY1Z002260041.china.huawei.com (10.177.16.142) by SZXEML429-HUB.china.huawei.com (10.82.67.184) with Microsoft SMTP Server id 14.3.158.1; Thu, 28 May 2015 20:10:09 +0800 From: Shannon Zhao To: Date: Thu, 28 May 2015 20:08:40 +0800 Message-ID: <1432814932-12608-18-git-send-email-zhaoshenglong@huawei.com> X-Mailer: git-send-email 1.9.0.msysgit.0 In-Reply-To: <1432814932-12608-1-git-send-email-zhaoshenglong@huawei.com> References: <1432814932-12608-1-git-send-email-zhaoshenglong@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.177.16.142] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 58.251.152.64 Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, mjt@tls.msk.ru, shannon.zhao@linaro.org, peter.maydell@linaro.org Subject: [Qemu-devel] [PATCH 17/29] hw/lm32/milkymist.c: Fix memory leak spotted by valgrind X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: patch@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.46 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Shannon Zhao valgrind complains about: ==20652== 8 bytes in 1 blocks are definitely lost in loss record 252 of 1,314 ==20652== at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==20652== by 0x1E77E7: malloc_and_trace (vl.c:2556) ==20652== by 0x64C770E: g_malloc (in /usr/lib64/libglib-2.0.so.0.3600.3) ==20652== by 0x238C43: qemu_extend_irqs (irq.c:55) ==20652== by 0x238CCF: qemu_allocate_irqs (irq.c:64) ==20652== by 0x1C49AD: milkymist_init (milkymist.c:133) ==20652== by 0x1EBBB2: main (vl.c:4249) Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/lm32/milkymist.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c index e0cec7d..4b8284f 100644 --- a/hw/lm32/milkymist.c +++ b/hw/lm32/milkymist.c @@ -86,7 +86,7 @@ milkymist_init(MachineState *machine) DriveInfo *dinfo; MemoryRegion *address_space_mem = get_system_memory(); MemoryRegion *phys_sdram = g_new(MemoryRegion, 1); - qemu_irq irq[32], *cpu_irq; + qemu_irq irq[32], cpu_irq; int i; char *bios_filename; ResetInfo *reset_info; @@ -130,8 +130,8 @@ milkymist_init(MachineState *machine) 2, 0x00, 0x89, 0x00, 0x1d, 1); /* create irq lines */ - cpu_irq = qemu_allocate_irqs(cpu_irq_handler, cpu, 1); - env->pic_state = lm32_pic_init(*cpu_irq); + cpu_irq = qemu_allocate_irq(cpu_irq_handler, cpu, 0); + env->pic_state = lm32_pic_init(cpu_irq); for (i = 0; i < 32; i++) { irq[i] = qdev_get_gpio_in(env->pic_state, i); }