From patchwork Thu May 28 12:08:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shannon Zhao X-Patchwork-Id: 49086 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f198.google.com (mail-wi0-f198.google.com [209.85.212.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 1F56B218EC for ; Thu, 28 May 2015 12:25:16 +0000 (UTC) Received: by wixv7 with SMTP id v7sf13391497wix.0 for ; Thu, 28 May 2015 05:25:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:content-type:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=L2tcrSNaEoGbcZyE7rc+Ah6QDysL2D+iyuNWinqEfKU=; b=G/PwPvkBWb8kyGVtUMeik/OT5uBAd2UKB4Y8eCdYLtnuoT9Uk/vK/wZDe8efC6Oldu KZNMbc2AQkg4UFMvkHO+fIXbd3b+T3m2+7NSYJQfdDgVqU9idW6YMBLmIAQeUT+jokUM KwOXejTB1zJS32wZYF53Q6PHPckZHC0/2CvQw629Z1AEm7CclgU4X8K3G2j+zsW39KNp 9207Dh0nSlfyiuelVnVoItPooxVPx9tf/2fHFt7MWrXDViG14aT8Caz3cDzLMZ5MOxny HvKFEu65jQL6wfOuTHM4E6Y/94fz4O/H04q7WfAUb3mO/cWEmMcCvJMdx8EB4m6rs4qP BHDg== X-Gm-Message-State: ALoCoQkoCBELVtXFtMunjIt/BZPW/OQZENyRCpe8WRlgsYOlG43RFkM8aqmrpOcnZGckStR+JJku X-Received: by 10.112.219.200 with SMTP id pq8mr2470983lbc.7.1432815915014; Thu, 28 May 2015 05:25:15 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.178.195 with SMTP id da3ls185242lac.43.gmail; Thu, 28 May 2015 05:25:14 -0700 (PDT) X-Received: by 10.152.203.233 with SMTP id kt9mr2503684lac.21.1432815914894; Thu, 28 May 2015 05:25:14 -0700 (PDT) Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com. [209.85.217.178]) by mx.google.com with ESMTPS id bq3si1809154lbb.128.2015.05.28.05.25.14 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 May 2015 05:25:14 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.178 as permitted sender) client-ip=209.85.217.178; Received: by lbbqq2 with SMTP id qq2so26944105lbb.3 for ; Thu, 28 May 2015 05:25:14 -0700 (PDT) X-Received: by 10.112.155.197 with SMTP id vy5mr2472571lbb.29.1432815914620; Thu, 28 May 2015 05:25:14 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp1115902lbb; Thu, 28 May 2015 05:25:13 -0700 (PDT) X-Received: by 10.55.23.130 with SMTP id 2mr4402026qkx.33.1432815913452; Thu, 28 May 2015 05:25:13 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 131si2196729qhw.45.2015.05.28.05.25.12 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 28 May 2015 05:25:13 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:58457 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxws4-0003zu-HH for patch@linaro.org; Thu, 28 May 2015 08:25:12 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58271) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YxweB-0002IA-Oj for qemu-devel@nongnu.org; Thu, 28 May 2015 08:10:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yxwe7-0003dQ-10 for qemu-devel@nongnu.org; Thu, 28 May 2015 08:10:51 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:45269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yxwe5-0003cQ-UY; Thu, 28 May 2015 08:10:46 -0400 Received: from 172.24.2.119 (EHLO SZXEML429-HUB.china.huawei.com) ([172.24.2.119]) by szxrg01-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id COP98096; Thu, 28 May 2015 20:10:30 +0800 (CST) Received: from HGHY1Z002260041.china.huawei.com (10.177.16.142) by SZXEML429-HUB.china.huawei.com (10.82.67.184) with Microsoft SMTP Server id 14.3.158.1; Thu, 28 May 2015 20:10:03 +0800 From: Shannon Zhao To: Date: Thu, 28 May 2015 20:08:34 +0800 Message-ID: <1432814932-12608-12-git-send-email-zhaoshenglong@huawei.com> X-Mailer: git-send-email 1.9.0.msysgit.0 In-Reply-To: <1432814932-12608-1-git-send-email-zhaoshenglong@huawei.com> References: <1432814932-12608-1-git-send-email-zhaoshenglong@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.177.16.142] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 58.251.152.64 Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com, mjt@tls.msk.ru, shannon.zhao@linaro.org, peter.maydell@linaro.org Subject: [Qemu-devel] [PATCH 11/29] hw/ppc/mac_oldworld.c: Fix memory leak spotted by valgrind X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: patch@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.178 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Shannon Zhao valgrind complains about: ==12412== 8 bytes in 1 blocks are definitely lost in loss record 448 of 3,760 ==12412== at 0x4C2845D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) ==12412== by 0x336F37: malloc_and_trace (vl.c:2556) ==12412== by 0x64C71F5: ??? (in /usr/lib64/libglib-2.0.so.0.3600.3) ==12412== by 0x64C7766: g_malloc0 (in /usr/lib64/libglib-2.0.so.0.3600.3) ==12412== by 0x26D448: ppc_heathrow_init (mac_oldworld.c:238) ==12412== by 0x33B302: main (vl.c:4249) Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/ppc/mac_oldworld.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c index f26133d..f66b8aa 100644 --- a/hw/ppc/mac_oldworld.c +++ b/hw/ppc/mac_oldworld.c @@ -263,6 +263,7 @@ static void ppc_heathrow_init(MachineState *machine) hw_error("Only 6xx bus is supported on heathrow machine\n"); } pic = heathrow_pic_init(&pic_mem, 1, heathrow_irqs); + g_free(heathrow_irqs); pci_bus = pci_grackle_init(0xfec00000, pic, get_system_memory(), get_system_io());