From patchwork Mon Dec 15 23:09:44 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Bellows X-Patchwork-Id: 42302 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5D36326C6C for ; Mon, 15 Dec 2014 23:15:55 +0000 (UTC) Received: by mail-la0-f70.google.com with SMTP id hs14sf7938438lab.9 for ; Mon, 15 Dec 2014 15:15:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=vm7mIXB2WwR5dfZhJ91pOxlfZKTPZhEN38OH0BUu5ww=; b=Zi5njVN9czJ3jbx8f0GoKU+0+28dJ+N01nZV9m9hMiGRqiW0c2B4VB73y/5X5MjERy QOn0ZZykF/TokUBEdPNBD1obC8UmsduhlEJXAcjbAgPrnx7NFJ2zeuG9gXV/FdTuSHBP dtlTQZBkhkIqD6OzMjWZtYz9Gg5CCgmRaXq9ZklOZBo9NmWxHQ3dOAmweOlUqPcEmizh belED+lZoUTs22HrWjXULoLndCKXfR2QIMv90BRFVRiXjMvd15T/jAUp22JbH2zUINmx E6QsdqcyfsPXQqzYNWDnOpLEvw82PuuftHTjG9V6ShjnMibmVFAaJE3BXct1wWwU4sok JVkQ== X-Gm-Message-State: ALoCoQlDS+AYk9uyUGSZwVKWmxBJxD1cc9xA+zoKK2BTqvJM7fl0QtDbFdYHT/OsOBOiyulEgjYs X-Received: by 10.112.169.101 with SMTP id ad5mr5080754lbc.1.1418685354310; Mon, 15 Dec 2014 15:15:54 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.205.66 with SMTP id le2ls756141lac.90.gmail; Mon, 15 Dec 2014 15:15:54 -0800 (PST) X-Received: by 10.152.25.129 with SMTP id c1mr33272783lag.9.1418685353996; Mon, 15 Dec 2014 15:15:53 -0800 (PST) Received: from mail-lb0-f179.google.com (mail-lb0-f179.google.com. [209.85.217.179]) by mx.google.com with ESMTPS id n4si11864901lan.14.2014.12.15.15.15.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 15 Dec 2014 15:15:53 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.179 as permitted sender) client-ip=209.85.217.179; Received: by mail-lb0-f179.google.com with SMTP id z11so9858270lbi.24 for ; Mon, 15 Dec 2014 15:15:53 -0800 (PST) X-Received: by 10.112.135.197 with SMTP id pu5mr32498167lbb.22.1418685353914; Mon, 15 Dec 2014 15:15:53 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.142.69 with SMTP id ru5csp867041lbb; Mon, 15 Dec 2014 15:15:52 -0800 (PST) X-Received: by 10.224.114.133 with SMTP id e5mr58992560qaq.48.1418685352020; Mon, 15 Dec 2014 15:15:52 -0800 (PST) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id b90si12445999qgb.50.2014.12.15.15.15.51 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 15 Dec 2014 15:15:52 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:42359 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0erm-0003e3-VS for patch@linaro.org; Mon, 15 Dec 2014 18:15:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0emS-0003d4-LA for qemu-devel@nongnu.org; Mon, 15 Dec 2014 18:10:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0emM-0000fw-Ln for qemu-devel@nongnu.org; Mon, 15 Dec 2014 18:10:20 -0500 Received: from mail-pd0-f177.google.com ([209.85.192.177]:38808) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0emM-0000fs-Dw for qemu-devel@nongnu.org; Mon, 15 Dec 2014 18:10:14 -0500 Received: by mail-pd0-f177.google.com with SMTP id ft15so12540474pdb.36 for ; Mon, 15 Dec 2014 15:10:14 -0800 (PST) X-Received: by 10.70.35.227 with SMTP id l3mr55530587pdj.33.1418685014010; Mon, 15 Dec 2014 15:10:14 -0800 (PST) Received: from gbellows-linaro.qualcomm.com (rrcs-67-52-129-61.west.biz.rr.com. [67.52.129.61]) by mx.google.com with ESMTPSA id uq15sm10402467pab.8.2014.12.15.15.10.12 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 15 Dec 2014 15:10:13 -0800 (PST) From: Greg Bellows To: qemu-devel@nongnu.org, serge.fdrv@gmail.com, edgar.iglesias@gmail.com, aggelerf@ethz.ch, peter.maydell@linaro.org Date: Mon, 15 Dec 2014 17:09:44 -0600 Message-Id: <1418684992-8996-8-git-send-email-greg.bellows@linaro.org> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1418684992-8996-1-git-send-email-greg.bellows@linaro.org> References: <1418684992-8996-1-git-send-email-greg.bellows@linaro.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.192.177 Cc: Greg Bellows Subject: [Qemu-devel] [PATCH v4 07/15] target-arm: Add virt machine secure property X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: greg.bellows@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.179 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Add "secure" virt machine specific property to allow override of the default secure state configuration. By default, when using the QEMU -kernel command line argument, virt machines boot into NS/SVC. When using the QEMU -bios command line argument, virt machines boot into S/SVC. The secure state can be changed from the default specifying the secure state as a machine property. For example, the below command line would disable security extensions on a -kernel Linux boot: aarch64-softmmu/qemu-system-aarch64 -machine type=virt,secure=off -kernel ... Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- v1 -> v2 - Adapt the machine secure property to Marcel's new dynamic registration - Change the default machine secure property to true (on). v3 -> v4 - Revise machine secure property description --- hw/arm/virt.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index b6bb914..73c68c7 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -93,6 +93,7 @@ typedef struct { typedef struct { MachineState parent; + bool secure; } VirtMachineState; #define TYPE_VIRT_MACHINE "virt" @@ -632,6 +633,34 @@ static void machvirt_init(MachineState *machine) arm_load_kernel(ARM_CPU(first_cpu), &vbi->bootinfo); } +static bool virt_get_secure(Object *obj, Error **errp) +{ + VirtMachineState *vms = VIRT_MACHINE(obj); + + return vms->secure; +} + +static void virt_set_secure(Object *obj, bool value, Error **errp) +{ + VirtMachineState *vms = VIRT_MACHINE(obj); + + vms->secure = value; +} + +static void virt_instance_init(Object *obj) +{ + VirtMachineState *vms = VIRT_MACHINE(obj); + + /* EL3 is enabled by default on virt */ + vms->secure = true; + object_property_add_bool(obj, "secure", virt_get_secure, + virt_set_secure, NULL); + object_property_set_description(obj, "secure", + "Set on/off to enable/disable the ARM " + "Security Extensions (TrustZone)", + NULL); +} + static void virt_class_init(ObjectClass *oc, void *data) { MachineClass *mc = MACHINE_CLASS(oc); @@ -646,6 +675,7 @@ static const TypeInfo machvirt_info = { .name = TYPE_VIRT_MACHINE, .parent = TYPE_MACHINE, .instance_size = sizeof(VirtMachineState), + .instance_init = virt_instance_init, .class_size = sizeof(VirtMachineClass), .class_init = virt_class_init, };