From patchwork Mon Dec 15 23:09:41 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Bellows X-Patchwork-Id: 42299 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f199.google.com (mail-wi0-f199.google.com [209.85.212.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 20F1726C6C for ; Mon, 15 Dec 2014 23:14:00 +0000 (UTC) Received: by mail-wi0-f199.google.com with SMTP id bs8sf4200073wib.6 for ; Mon, 15 Dec 2014 15:13:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=JScbUrUQwjqKbVANvRxeHknXWK7MiB6gZqsONPEEK68=; b=iruSzEGpexu1qapZrMwepTrZhHeW8ji4eypKN28m83g+tGVSR93Z16E3gKpm9imbKk vWWnvhz4WlIZovKgmubwu1PCCKJttxQtebfqTo2O1p5x1GSFeQGmZuGJOsRqwa0X/N/I 4ZYUHqCYlMFhL+qBMq24aviOgCkiA/BYyqCDdw4GUm59q5H0qROyFhUcN07nfdog/EbK TjoCf7BEsOfH29elrxVj49ia8+1+lP4BBDgBJDslQf8CGR3gs/KPV1faAJXvYjaETFHz 51H14G/3YK1Wg72TksuYL03LcXw5vrUho1Zeyhl/MUD1ncCdsP/qHzoJICQtwR4Tm3Rw +lXQ== X-Gm-Message-State: ALoCoQlJbRvu8QpcuW5+tBcnXoTX6fqSGLN/WH+kr0D9P2hyIVLfP0cLosoNy6s4p7KUSMxJHAWH X-Received: by 10.112.14.2 with SMTP id l2mr5026379lbc.5.1418685239329; Mon, 15 Dec 2014 15:13:59 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.6.134 with SMTP id b6ls680338laa.27.gmail; Mon, 15 Dec 2014 15:13:58 -0800 (PST) X-Received: by 10.112.150.102 with SMTP id uh6mr33340170lbb.50.1418685238958; Mon, 15 Dec 2014 15:13:58 -0800 (PST) Received: from mail-la0-f44.google.com (mail-la0-f44.google.com. [209.85.215.44]) by mx.google.com with ESMTPS id ea3si11779712lbc.123.2014.12.15.15.13.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 15 Dec 2014 15:13:58 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.44 as permitted sender) client-ip=209.85.215.44; Received: by mail-la0-f44.google.com with SMTP id gd6so10354891lab.31 for ; Mon, 15 Dec 2014 15:13:58 -0800 (PST) X-Received: by 10.152.23.38 with SMTP id j6mr25083632laf.81.1418685238869; Mon, 15 Dec 2014 15:13:58 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.142.69 with SMTP id ru5csp866618lbb; Mon, 15 Dec 2014 15:13:58 -0800 (PST) X-Received: by 10.224.19.130 with SMTP id a2mr10459076qab.41.1418685237401; Mon, 15 Dec 2014 15:13:57 -0800 (PST) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id o45si12480632qgd.14.2014.12.15.15.13.56 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 15 Dec 2014 15:13:57 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:42333 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0epw-0008T9-9A for patch@linaro.org; Mon, 15 Dec 2014 18:13:56 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0emP-0003X8-8C for qemu-devel@nongnu.org; Mon, 15 Dec 2014 18:10:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0emH-0000eZ-Eq for qemu-devel@nongnu.org; Mon, 15 Dec 2014 18:10:17 -0500 Received: from mail-pd0-f174.google.com ([209.85.192.174]:59169) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0emH-0000eT-9V for qemu-devel@nongnu.org; Mon, 15 Dec 2014 18:10:09 -0500 Received: by mail-pd0-f174.google.com with SMTP id fp1so12496938pdb.5 for ; Mon, 15 Dec 2014 15:10:08 -0800 (PST) X-Received: by 10.68.180.193 with SMTP id dq1mr42788856pbc.58.1418685008792; Mon, 15 Dec 2014 15:10:08 -0800 (PST) Received: from gbellows-linaro.qualcomm.com (rrcs-67-52-129-61.west.biz.rr.com. [67.52.129.61]) by mx.google.com with ESMTPSA id uq15sm10402467pab.8.2014.12.15.15.10.07 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 15 Dec 2014 15:10:08 -0800 (PST) From: Greg Bellows To: qemu-devel@nongnu.org, serge.fdrv@gmail.com, edgar.iglesias@gmail.com, aggelerf@ethz.ch, peter.maydell@linaro.org Date: Mon, 15 Dec 2014 17:09:41 -0600 Message-Id: <1418684992-8996-5-git-send-email-greg.bellows@linaro.org> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1418684992-8996-1-git-send-email-greg.bellows@linaro.org> References: <1418684992-8996-1-git-send-email-greg.bellows@linaro.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.85.192.174 Cc: Greg Bellows Subject: [Qemu-devel] [PATCH v4 04/15] target-arm: Add vexpress machine secure property X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: greg.bellows@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.44 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Add "secure" Vexpress machine specific property to allow override of the default secure state configuration. By default, when using the QEMU -kernel command line argument, Vexpress machines boot into NS/SVC. When using the QEMU -bios command line argument, Vexpress machines boot into S/SVC. The secure state can be changed from the default specifying the secure state as a machine property. For example, the below command line would disable security extensions on a -kernel Linux boot: aarch64-softmmu/qemu-system-aarch64 -machine type=vexpress-a15,secure=off -kernel ... Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell --- v1 -> v2 - Adapt the machine secure property to Marcel's new dynamic registration - Change the default machine secure property to true (on). v3 -> v4 - Revise machine secure property description --- hw/arm/vexpress.c | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/hw/arm/vexpress.c b/hw/arm/vexpress.c index a03cb52..8b05d47 100644 --- a/hw/arm/vexpress.c +++ b/hw/arm/vexpress.c @@ -164,6 +164,7 @@ typedef struct { typedef struct { MachineState parent; + bool secure; } VexpressMachineState; #define TYPE_VEXPRESS_MACHINE "vexpress" @@ -701,6 +702,34 @@ static void vexpress_common_init(MachineState *machine) arm_load_kernel(ARM_CPU(first_cpu), &daughterboard->bootinfo); } +static bool vexpress_get_secure(Object *obj, Error **errp) +{ + VexpressMachineState *vms = VEXPRESS_MACHINE(obj); + + return vms->secure; +} + +static void vexpress_set_secure(Object *obj, bool value, Error **errp) +{ + VexpressMachineState *vms = VEXPRESS_MACHINE(obj); + + vms->secure = value; +} + +static void vexpress_instance_init(Object *obj) +{ + VexpressMachineState *vms = VEXPRESS_MACHINE(obj); + + /* EL3 is enabled by default on vexpress */ + vms->secure = true; + object_property_add_bool(obj, "secure", vexpress_get_secure, + vexpress_set_secure, NULL); + object_property_set_description(obj, "secure", + "Set on/off to enable/disable the ARM " + "Security Extensions (TrustZone)", + NULL); +} + static void vexpress_class_init(ObjectClass *oc, void *data) { MachineClass *mc = MACHINE_CLASS(oc); @@ -739,6 +768,7 @@ static const TypeInfo vexpress_info = { .parent = TYPE_MACHINE, .abstract = true, .instance_size = sizeof(VexpressMachineState), + .instance_init = vexpress_instance_init, .class_size = sizeof(VexpressMachineClass), .class_init = vexpress_class_init, };