From patchwork Fri Sep 12 14:55:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 37347 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f197.google.com (mail-lb0-f197.google.com [209.85.217.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 48C4B206A5 for ; Fri, 12 Sep 2014 14:56:29 +0000 (UTC) Received: by mail-lb0-f197.google.com with SMTP id p9sf566431lbv.8 for ; Fri, 12 Sep 2014 07:56:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:cc:subject:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:errors-to:sender :x-original-sender:x-original-authentication-results:mailing-list; bh=ayNbMa+ZLmxhU4Yrp+Uwn9oswnkvqh85nb4eKzIr6go=; b=jdQG8Js/0imkYnKUAvaEVCGBhQB09ZGTzHKJKdLRQ3yOV267Y5jfcI68INzYeV1ZEj 8wWqIa1WlZ9O0VWGj6xsRZ7QIadHM7fiHW4m2Jafi+zmJBT2sniMjJvUid5cEQl6GqNF 9AQg1diaYWUEkhbAw3AUz3iAW8AsireTTqJBlBVxx1zRjq0ISLnx58jbhqjSPEhTtEUz z/AfxCng9DUQJ/2yctWfx73PJggwmoY0VgqhYsw6ij88XIaBVhgaBcn8Tm81F3owhzzZ iklIxGgSiIjsLDP66b8ZxDa0CRjOCvXynZMZW6a+5uzCUz3wDbAIjWXRCz0dCUnOYKhw 3kxg== X-Gm-Message-State: ALoCoQmuOBcayAyypYr6aa63OOOyk1QsWEF9y7qnrH5a/t2mA67s8Vrg98XwI1DMVinYzou1kfuT X-Received: by 10.180.99.74 with SMTP id eo10mr803661wib.2.1410533786667; Fri, 12 Sep 2014 07:56:26 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.44.229 with SMTP id h5ls188464lam.4.gmail; Fri, 12 Sep 2014 07:56:26 -0700 (PDT) X-Received: by 10.112.130.41 with SMTP id ob9mr9053646lbb.12.1410533786508; Fri, 12 Sep 2014 07:56:26 -0700 (PDT) Received: from mail-la0-f49.google.com (mail-la0-f49.google.com [209.85.215.49]) by mx.google.com with ESMTPS id f12si6881768lbo.96.2014.09.12.07.56.26 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 12 Sep 2014 07:56:26 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.49 as permitted sender) client-ip=209.85.215.49; Received: by mail-la0-f49.google.com with SMTP id pv20so1115546lab.22 for ; Fri, 12 Sep 2014 07:56:26 -0700 (PDT) X-Received: by 10.112.62.200 with SMTP id a8mr9048813lbs.34.1410533786288; Fri, 12 Sep 2014 07:56:26 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.141.42 with SMTP id rl10csp749337lbb; Fri, 12 Sep 2014 07:56:25 -0700 (PDT) X-Received: by 10.224.123.9 with SMTP id n9mr12836826qar.84.1410533785005; Fri, 12 Sep 2014 07:56:25 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id l15si5891437qaa.122.2014.09.12.07.56.24 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 12 Sep 2014 07:56:24 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:45553 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSSGu-0008FI-6n for patch@linaro.org; Fri, 12 Sep 2014 10:56:24 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSSGL-0007uY-BW for qemu-devel@nongnu.org; Fri, 12 Sep 2014 10:55:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XSSGD-0004aq-S5 for qemu-devel@nongnu.org; Fri, 12 Sep 2014 10:55:49 -0400 Received: from mnementh.archaic.org.uk ([81.2.115.146]:46963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XSSGD-0004aZ-Ha for qemu-devel@nongnu.org; Fri, 12 Sep 2014 10:55:41 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1XSSGB-0003bd-0l; Fri, 12 Sep 2014 15:55:39 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Date: Fri, 12 Sep 2014 15:55:38 +0100 Message-Id: <1410533739-13836-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 81.2.115.146 Cc: Alexander Graf , patches@linaro.org Subject: [Qemu-devel] [PATCH] configure: Build GDB XML for 32 bit ARM CPUs into qemu aarch64 binaries X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.49 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 The qemu-aarch64 and qemu-system-aarch64 binaries include support for all the 32 bit ARM CPUs as well as the 64 bit ones. This means we need to build in the GDB XML files for the 32 bit CPUs too. Otherwise gdb will complain: warning: while parsing target description (at line 1): Could not load XML document "arm-core.xml" when you try to connect to our gdbserver to debug a 32 bit CPU running in a qemu-aarch64 or qemu-system-aarch64 binary. Signed-off-by: Peter Maydell --- I'm pretty sure PPC also has this bug, except that it's kind of masked by the other bug where you set cc->gdb_core_xml_file based on the compile-time TARGET_PPC64 define rather than the runtime question of whether the CPU is 32 bit or not. Or maybe I've misunderstood how PPC works here... configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 961bf6f..4551fc4 100755 --- a/configure +++ b/configure @@ -5016,7 +5016,7 @@ case "$target_name" in aarch64) TARGET_BASE_ARCH=arm bflt="yes" - gdb_xml_files="aarch64-core.xml aarch64-fpu.xml" + gdb_xml_files="aarch64-core.xml aarch64-fpu.xml arm-core.xml arm-vfp.xml arm-vfp3.xml arm-neon.xml" ;; cris) ;;