From patchwork Wed Apr 16 11:29:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 28455 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pb0-f72.google.com (mail-pb0-f72.google.com [209.85.160.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2D049206A6 for ; Wed, 16 Apr 2014 11:29:46 +0000 (UTC) Received: by mail-pb0-f72.google.com with SMTP id jt11sf40463555pbb.7 for ; Wed, 16 Apr 2014 04:29:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list:content-type :content-transfer-encoding; bh=fho2nou4vXmvUDEauBjDd86j/jdOeIu7zfWVevaM7+o=; b=bmO9JahYXL51/xGsDSNVJ09JysuwUh/+b6xeGIeVbD5aG5c5faV+DSEDd6/oG06lIE UFs8pq+OvQ4eOG/U5isOh1rCB/EysCusLEgk7pq+T4KqqS4FwBh5aAgHNuZpzaee7yUK hMs376xRkXxcBSly4tyViOSltxr9fNnnknBn0XLMYHyIaZCzJOefy15w+lXTaAh8yKAO iv09QQNu3Vk8ENSMKZevSmOhSPZ6DEieJdfma3BRTOOAgInypEdBbCrV+pPhaewhdUcm QQwZGlYePfxffvm+qitxspLmeYebkk4oQgj64/lB4ScHoG0Qolp87/Fd6GTHLvXXMaVB blPA== X-Gm-Message-State: ALoCoQm6dq4gNUcRbo2QARCTfMWqHvSkBA5ylk0ZdnFZccGXuh9X41QdTbGnRy3c5F8vSHR0mJi9 X-Received: by 10.66.121.136 with SMTP id lk8mr3504154pab.34.1397647785443; Wed, 16 Apr 2014 04:29:45 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.20.22 with SMTP id 22ls510632qgi.63.gmail; Wed, 16 Apr 2014 04:29:45 -0700 (PDT) X-Received: by 10.58.38.166 with SMTP id h6mr1641334vek.22.1397647785278; Wed, 16 Apr 2014 04:29:45 -0700 (PDT) Received: from mail-vc0-f179.google.com (mail-vc0-f179.google.com [209.85.220.179]) by mx.google.com with ESMTPS id de9si3823233vcb.213.2014.04.16.04.29.45 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 16 Apr 2014 04:29:45 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.179; Received: by mail-vc0-f179.google.com with SMTP id ij19so10448374vcb.38 for ; Wed, 16 Apr 2014 04:29:45 -0700 (PDT) X-Received: by 10.220.250.203 with SMTP id mp11mr2566688vcb.2.1397647785204; Wed, 16 Apr 2014 04:29:45 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp304326vcb; Wed, 16 Apr 2014 04:29:44 -0700 (PDT) X-Received: by 10.229.198.2 with SMTP id em2mr1616575qcb.21.1397647784854; Wed, 16 Apr 2014 04:29:44 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id s3si3220292qas.66.2014.04.16.04.29.44 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 16 Apr 2014 04:29:44 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:54026 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WaO2C-0007oU-GW for patch@linaro.org; Wed, 16 Apr 2014 07:29:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58982) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WaO1d-0006t9-FR for qemu-devel@nongnu.org; Wed, 16 Apr 2014 07:29:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WaO1Z-000826-1d for qemu-devel@nongnu.org; Wed, 16 Apr 2014 07:29:09 -0400 Received: from static.88-198-71-155.clients.your-server.de ([88.198.71.155]:53031 helo=socrates.bennee.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WaO1Y-000821-Sm for qemu-devel@nongnu.org; Wed, 16 Apr 2014 07:29:05 -0400 Received: from localhost ([127.0.0.1] helo=zen.linaro.local) by socrates.bennee.com with esmtp (Exim 4.80) (envelope-from ) id 1WaO2A-0007XL-JR; Wed, 16 Apr 2014 13:29:42 +0200 From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Date: Wed, 16 Apr 2014 12:29:39 +0100 Message-Id: <1397647779-29287-1-git-send-email-alex.bennee@linaro.org> X-Mailer: git-send-email 1.9.2 In-Reply-To: <20140416080421.17349.87781.malonedeb@chaenomeles.canonical.com> References: <20140416080421.17349.87781.malonedeb@chaenomeles.canonical.com> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: alex.bennee@linaro.org X-SA-Exim-Scanned: No (on socrates.bennee.com); SAEximRunCond expanded to false X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 88.198.71.155 Cc: peter.maydell@linaro.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [Qemu-devel] [PATCH] target-arm: A64: fix unallocated test of scalar SQXTUN X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: alex.bennee@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.179 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 The test for the U bit was incorrectly inverted in the scalar case of SQXTUN. This doesn't affect the vector case as the U bit is used to select XTN(2). Reported-by: Hao Liu Signed-off-by: Alex Bennée Reviewed-by: Claudio Fontana Reviewed-by: Peter Maydell --- target-arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index a74128c..0adffbb 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -7553,7 +7553,7 @@ static void disas_simd_scalar_two_reg_misc(DisasContext *s, uint32_t insn) } break; case 0x12: /* SQXTUN */ - if (u) { + if (!u) { unallocated_encoding(s); return; }