From patchwork Fri Apr 4 19:27:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Wolf X-Patchwork-Id: 27868 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f197.google.com (mail-ie0-f197.google.com [209.85.223.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 0F7F420490 for ; Fri, 4 Apr 2014 19:33:40 +0000 (UTC) Received: by mail-ie0-f197.google.com with SMTP id rd18sf13485244iec.4 for ; Fri, 04 Apr 2014 12:33:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=uHpMj6I/1q5a8UAnlvvL3yVXPEqkN/vs7xJt5RKktZ8=; b=BWeMf8Vi1JwlcatndwOHBqfRNCMv7dBnqwv5onqSMBq0AEiM6L+YBg1II1X5KkOVaH BqsYXjf9VKY9AHtM8ffCTvCwPUSd3qRBjqX5X8Do72JHbdPR+L3DEAJ/mYzHJEA51oSO WdPoK+Aa52rmzpU6BONGIPi0vsRtId/uoAx174bZT/YmOlLtkjC1BlxIiEAhpUITo3Dk bjhqAL43I10dY/pn4Ti/t2yQE3GYBUYBkw0YMf9xlCeaGwMqxMtkrNWKMQtG24Lrg/PB sKDtKJQWIcsxjxQsVETyPDXNmZwwwJUpuzjGoL1CFL9pNnwMM5G/h39FYMB3Udaw3JMq l3gg== X-Gm-Message-State: ALoCoQnz1jBw7deb+UrEF8fBEwZVMhP/IT7bydn3OyuXpvbkU4daZNcfpak4WqSM8wkhUIEvAcPb X-Received: by 10.43.139.66 with SMTP id iv2mr8454756icc.17.1396640020540; Fri, 04 Apr 2014 12:33:40 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.51.137 with SMTP id u9ls1116170qga.81.gmail; Fri, 04 Apr 2014 12:33:40 -0700 (PDT) X-Received: by 10.52.163.145 with SMTP id yi17mr815611vdb.46.1396640020437; Fri, 04 Apr 2014 12:33:40 -0700 (PDT) Received: from mail-ve0-f170.google.com (mail-ve0-f170.google.com [209.85.128.170]) by mx.google.com with ESMTPS id ww7si887684vec.102.2014.04.04.12.33.40 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 04 Apr 2014 12:33:40 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.170 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.170; Received: by mail-ve0-f170.google.com with SMTP id pa12so1846332veb.1 for ; Fri, 04 Apr 2014 12:33:40 -0700 (PDT) X-Received: by 10.220.83.4 with SMTP id d4mr736033vcl.39.1396640020365; Fri, 04 Apr 2014 12:33:40 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.12.8 with SMTP id v8csp138988vcv; Fri, 4 Apr 2014 12:33:39 -0700 (PDT) X-Received: by 10.229.136.135 with SMTP id r7mr16798783qct.17.1396640019341; Fri, 04 Apr 2014 12:33:39 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id x7si3853074qaj.255.2014.04.04.12.33.39 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 04 Apr 2014 12:33:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:51901 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW9ru-0001ae-UZ for patch@linaro.org; Fri, 04 Apr 2014 15:33:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW9md-0007S6-6N for qemu-devel@nongnu.org; Fri, 04 Apr 2014 15:28:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WW9mY-0007gM-CW for qemu-devel@nongnu.org; Fri, 04 Apr 2014 15:28:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40585) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WW9mY-0007gI-5W for qemu-devel@nongnu.org; Fri, 04 Apr 2014 15:28:06 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s34JS5XI016177 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 4 Apr 2014 15:28:05 -0400 Received: from noname.redhat.com (ovpn-116-80.ams2.redhat.com [10.36.116.80]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s34JRoIe011901; Fri, 4 Apr 2014 15:28:04 -0400 From: Kevin Wolf To: qemu-devel@nongnu.org Date: Fri, 4 Apr 2014 21:27:47 +0200 Message-Id: <1396639669-24348-9-git-send-email-kwolf@redhat.com> In-Reply-To: <1396639669-24348-1-git-send-email-kwolf@redhat.com> References: <1396639669-24348-1-git-send-email-kwolf@redhat.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.27 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 Cc: kwolf@redhat.com Subject: [Qemu-devel] [PULL 08/10] dma-helpers: Initialize DMAAIOCB in_cancel flag X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: kwolf@redhat.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.170 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Peter Maydell Initialize the dbs->in_cancel flag in dma_bdrv_io(), since qemu_aio_get() does not return zero-initialized memory. Spotted by the clang sanitizer (which complained when the value loaded in dma_complete() was not valid for a bool type); this might have resulted in leaking the AIO block. Signed-off-by: Peter Maydell Signed-off-by: Kevin Wolf --- dma-helpers.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dma-helpers.c b/dma-helpers.c index c9620a5..5f421e9 100644 --- a/dma-helpers.c +++ b/dma-helpers.c @@ -213,6 +213,7 @@ BlockDriverAIOCB *dma_bdrv_io( dbs->sg_cur_index = 0; dbs->sg_cur_byte = 0; dbs->dir = dir; + dbs->in_cancel = false; dbs->io_func = io_func; dbs->bh = NULL; qemu_iovec_init(&dbs->iov, sg->nsg);