From patchwork Thu Mar 27 14:13:28 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 27192 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f71.google.com (mail-pa0-f71.google.com [209.85.220.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 84C4B202FA for ; Thu, 27 Mar 2014 14:27:34 +0000 (UTC) Received: by mail-pa0-f71.google.com with SMTP id kq14sf8549855pab.10 for ; Thu, 27 Mar 2014 07:27:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=jUmw6ojwon7txLPzNizWCaRSJXsNMIRM9PwyEplxDJQ=; b=ZSASEclYifKHn//RmAh+KoaI4FMB6ZBgDOYpXWHzSp4q/OKc/82W+s6z9AL8AlcWlQ HuJfp65gyXc4sWQcUKCGDs3Tv3/BGqe2g3PXy3NlGU3hKhI0sxdJu7EoK7/olY1yRWza vFCBn6RAS/h8a4LZS8sPmqhRkd85iTcJ7xOS8QYVJ/B8DkpZnkLCRPh0MrPW9TjTrPDp yWUvRlpQraGyZr96+qM0QvXKePsQih6ea3c3W7aYLGHuuiOJqqVFkUbPsd99kdST2Ml7 rSoK45y1hoTBCleXQ/HvUG7fUIz9P3GankgsZ6LvbHnIM/8jIJHY7jUYRnRLEpVMyCFk W79Q== X-Gm-Message-State: ALoCoQmz0xgGxrX/M1D/kBVIuVTLYE/hYjgnSOtS7Pha203ZwbRQroXvukZfgwZ2BiJOzYWLIHjG X-Received: by 10.68.134.233 with SMTP id pn9mr827296pbb.5.1395930453222; Thu, 27 Mar 2014 07:27:33 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.28.137 with SMTP id 9ls1097875qgz.14.gmail; Thu, 27 Mar 2014 07:27:33 -0700 (PDT) X-Received: by 10.59.9.38 with SMTP id dp6mr1755814ved.24.1395930453106; Thu, 27 Mar 2014 07:27:33 -0700 (PDT) Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by mx.google.com with ESMTPS id w10si570098vei.178.2014.03.27.07.27.33 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 27 Mar 2014 07:27:33 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.173; Received: by mail-vc0-f173.google.com with SMTP id il7so4237431vcb.4 for ; Thu, 27 Mar 2014 07:27:33 -0700 (PDT) X-Received: by 10.58.152.142 with SMTP id uy14mr1734046veb.4.1395930452991; Thu, 27 Mar 2014 07:27:32 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp32229vck; Thu, 27 Mar 2014 07:27:32 -0700 (PDT) X-Received: by 10.224.75.5 with SMTP id w5mr2478338qaj.52.1395930452610; Thu, 27 Mar 2014 07:27:32 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id s10si1071774qak.152.2014.03.27.07.27.32 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 27 Mar 2014 07:27:32 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:54001 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTBHI-00053P-4h for patch@linaro.org; Thu, 27 Mar 2014 10:27:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTBGf-0004QR-Ij for qemu-devel@nongnu.org; Thu, 27 Mar 2014 10:26:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WTBGe-0005QP-Im for qemu-devel@nongnu.org; Thu, 27 Mar 2014 10:26:53 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:47166) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WTBGe-0005Pt-Cb for qemu-devel@nongnu.org; Thu, 27 Mar 2014 10:26:52 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WTB3h-0000Cq-JF; Thu, 27 Mar 2014 14:13:29 +0000 From: Peter Maydell To: Anthony Liguori Date: Thu, 27 Mar 2014 14:13:28 +0000 Message-Id: <1395929609-764-2-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395929609-764-1-git-send-email-peter.maydell@linaro.org> References: <1395929609-764-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Cc: qemu-devel@nongnu.org Subject: [Qemu-devel] [PULL 1/2] hw/arm: Stop specifying integratorcp as the default board X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Currently for both qemu-system-arm and qemu-system-aarch64 the default board model if the user doesn't specify one is the 'integratorcp'. This is a totally arbitrary historical accident since it was the first board to be modelled. That board is now just one target among many for us, and is a very poor choice of default: * it's an ancient board that is now only found in the junkpiles of longtime ARM/Linux hackers, if at all * it's an ARMv5 CPU, when most distros are now assuming ARMv7 * it's pretty much unmaintained in QEMU * it doesn't even have versatilepb's advantage of supporting PCI Making it or any other board the default serves only to confuse people new to ARM who expect something more like the x86 monoculture. Remove the is_default marker from integratorcp, and don't set it for any other board, to give users a nudge that they need to think about which board they want a QEMU model of. (QEMU will produce the admittedly slightly cryptic error "No machine found.") Signed-off-by: Peter Maydell Reviewed-by: Paolo Bonzini --- hw/arm/integratorcp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/arm/integratorcp.c b/hw/arm/integratorcp.c index a759689..912af96 100644 --- a/hw/arm/integratorcp.c +++ b/hw/arm/integratorcp.c @@ -534,7 +534,6 @@ static QEMUMachine integratorcp_machine = { .name = "integratorcp", .desc = "ARM Integrator/CP (ARM926EJ-S)", .init = integratorcp_init, - .is_default = 1, }; static void integratorcp_machine_init(void)