From patchwork Mon Mar 10 19:10:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 26002 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f197.google.com (mail-ie0-f197.google.com [209.85.223.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 748222054B for ; Mon, 10 Mar 2014 19:10:57 +0000 (UTC) Received: by mail-ie0-f197.google.com with SMTP id rd18sf29921437iec.4 for ; Mon, 10 Mar 2014 12:10:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=JfWBy2LEDmJM7zUmf0CYvwb/9SyhjQgdO8Ismvdk0Qg=; b=fTVWVXtDHUDg6MPiAmksg3kIQzQ5VWj7LwXd6RzhgYMqFchyEiuiz5/YuBLL9asUhj i1MzqfQVtnCP/tqsJKCtz/ZDEnw3YPWNEkZehL9ivV7DoTPDpUcvgu5ehVywbC6v1HE0 v6v3LeEJgjwy3mIwZH/7htFO+R4mDOGRap0Jll/Z2C2ZK5anyMFIapZ4+7gxV3C37PPj 2sNlJAZvw0ik3qwYzWYjIeYnlfLu1bvaEBp+HtvtOH/l5VAjw6rfOoud4JuQFjtngzbk 6FDs2SVrXK9ixZlNSmZOdTeOUyswwwuQxi04SkkUJROPSX76ROTYahLL0P5vmIFIoBy1 1Big== X-Gm-Message-State: ALoCoQnO6ArIIWF35N+iSz3Z+L/odmPOUF9NKFb6jkrO7/0HS5nS8fRustiT6pHug0juaE2R0t2P X-Received: by 10.182.98.230 with SMTP id el6mr14935498obb.10.1394478656464; Mon, 10 Mar 2014 12:10:56 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.107.7 with SMTP id g7ls796244qgf.53.gmail; Mon, 10 Mar 2014 12:10:56 -0700 (PDT) X-Received: by 10.58.49.129 with SMTP id u1mr24631907ven.0.1394478656325; Mon, 10 Mar 2014 12:10:56 -0700 (PDT) Received: from mail-ve0-f180.google.com (mail-ve0-f180.google.com [209.85.128.180]) by mx.google.com with ESMTPS id fi2si5708624vdb.23.2014.03.10.12.10.56 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 10 Mar 2014 12:10:56 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.180; Received: by mail-ve0-f180.google.com with SMTP id jz11so7359343veb.39 for ; Mon, 10 Mar 2014 12:10:56 -0700 (PDT) X-Received: by 10.220.12.140 with SMTP id x12mr23617296vcx.19.1394478656031; Mon, 10 Mar 2014 12:10:56 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.78.9 with SMTP id i9csp141955vck; Mon, 10 Mar 2014 12:10:55 -0700 (PDT) X-Received: by 10.194.185.148 with SMTP id fc20mr32990647wjc.27.1394478655317; Mon, 10 Mar 2014 12:10:55 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id ln4si19568977wjb.50.2014.03.10.12.10.54 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 10 Mar 2014 12:10:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 2001:8b0:1d0::1 as permitted sender) client-ip=2001:8b0:1d0::1; Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WN5b7-0002TB-6T; Mon, 10 Mar 2014 19:10:49 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, qemu-trivial@nongnu.org, qemu-ppc@nongnu.org Subject: [PATCH 04/12] hw/i386/acpi_build.c: Avoid shifting left into sign bit Date: Mon, 10 Mar 2014 19:10:40 +0000 Message-Id: <1394478649-9453-5-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1394478649-9453-1-git-send-email-peter.maydell@linaro.org> References: <1394478649-9453-1-git-send-email-peter.maydell@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Add U suffix to avoid undefined behaviour. Signed-off-by: Peter Maydell Reviewed-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index b1a7ebb..46d4e60 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -813,7 +813,7 @@ static void build_pci_bus_end(PCIBus *bus, void *bus_state) build_append_byte(notify, 0x7B); /* AndOp */ build_append_byte(notify, 0x68); /* Arg0Op */ - build_append_int(notify, 0x1 << i); + build_append_int(notify, 0x1U << i); build_append_byte(notify, 0x00); /* NullName */ build_append_byte(notify, 0x86); /* NotifyOp */ build_append_nameseg(notify, "S%.02X_", PCI_DEVFN(i, 0));