From patchwork Mon Mar 10 19:10:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 26006 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f72.google.com (mail-oa0-f72.google.com [209.85.219.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9F3DC2054B for ; Mon, 10 Mar 2014 19:16:41 +0000 (UTC) Received: by mail-oa0-f72.google.com with SMTP id g12sf30264158oah.11 for ; Mon, 10 Mar 2014 12:16:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=axMg+qZzEKZ3NJZogDWXkr6VXoMANmaM3lCLpA1AHUI=; b=BYenrBPlNZ96yjb1QgtGZS15txyeg52EPnnBOnvPAWaQE5vRfhNefmI7jU49k/Cyyj N4LgcNI8oKV8ZlqPTGTeUjTyXg1pYeJxmJX/9OqB75tTTSb2KD+mq16xNJNSm654Y4Gz R2o7UdxL7kma2aR5V2jJj6t3Z7glpiAd8j4sxMkl4pa0Pz6BOedGxvh6jQkoXhl5+k7W 2L/6jfmRhHBPWDff1QbY4G5WEp7RS2ldWx9HZ4sETS72ca3R6KN38pe5gIao6MEcK+BF moMyjtQ7CUVRf3Q0O4jbqyAzvwX/grbC4jvtaA2KaFh1hbVwq+mBPcWfwQaNflYFrrXp IP0A== X-Gm-Message-State: ALoCoQkHedYUoIjg1VYVjNXUSUTb1uuUem0OcfgvuV6cVv13kbzAFazf275P3z90xbrWFfSKY+EO X-Received: by 10.182.19.231 with SMTP id i7mr14039833obe.25.1394479001150; Mon, 10 Mar 2014 12:16:41 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.81.209 with SMTP id f75ls2354950qgd.48.gmail; Mon, 10 Mar 2014 12:16:40 -0700 (PDT) X-Received: by 10.220.103.141 with SMTP id k13mr2862475vco.25.1394479000952; Mon, 10 Mar 2014 12:16:40 -0700 (PDT) Received: from mail-ve0-f182.google.com (mail-ve0-f182.google.com [209.85.128.182]) by mx.google.com with ESMTPS id b20si5029141veu.144.2014.03.10.12.16.40 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 10 Mar 2014 12:16:40 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.182 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.182; Received: by mail-ve0-f182.google.com with SMTP id jw12so7660805veb.13 for ; Mon, 10 Mar 2014 12:16:40 -0700 (PDT) X-Received: by 10.58.188.78 with SMTP id fy14mr3710054vec.23.1394479000889; Mon, 10 Mar 2014 12:16:40 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp142289vck; Mon, 10 Mar 2014 12:16:40 -0700 (PDT) X-Received: by 10.14.6.1 with SMTP id 1mr1048471eem.71.1394478999834; Mon, 10 Mar 2014 12:16:39 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 46si36382790eem.109.2014.03.10.12.16.39 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 10 Mar 2014 12:16:39 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:50831 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WN5gk-0004hi-CO for patch@linaro.org; Mon, 10 Mar 2014 15:16:38 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57284) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WN5bP-00052L-T9 for qemu-devel@nongnu.org; Mon, 10 Mar 2014 15:11:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WN5bA-0003Jp-Bh for qemu-devel@nongnu.org; Mon, 10 Mar 2014 15:11:07 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:46636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WN5b9-0003JG-S3; Mon, 10 Mar 2014 15:10:52 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WN5b7-0002Td-Fx; Mon, 10 Mar 2014 19:10:49 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Date: Mon, 10 Mar 2014 19:10:47 +0000 Message-Id: <1394478649-9453-12-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1394478649-9453-1-git-send-email-peter.maydell@linaro.org> References: <1394478649-9453-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Cc: qemu-trivial@nongnu.org, qemu-ppc@nongnu.org, patches@linaro.org Subject: [Qemu-devel] [PATCH 11/12] hw/intc/xilinx_intc: Avoid shifting left into sign bit X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.182 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Avoid undefined behaviour shifting left into the sign bit. Signed-off-by: Peter Maydell --- hw/intc/xilinx_intc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/intc/xilinx_intc.c b/hw/intc/xilinx_intc.c index 4a10398..1b228ff 100644 --- a/hw/intc/xilinx_intc.c +++ b/hw/intc/xilinx_intc.c @@ -71,8 +71,9 @@ static void update_irq(struct xlx_pic *p) /* Update the vector register. */ for (i = 0; i < 32; i++) { - if (p->regs[R_IPR] & (1 << i)) + if (p->regs[R_IPR] & (1U << i)) { break; + } } if (i == 32) i = ~0;