From patchwork Mon Mar 10 15:09:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 25981 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f198.google.com (mail-ob0-f198.google.com [209.85.214.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 6DD452055F for ; Mon, 10 Mar 2014 15:12:10 +0000 (UTC) Received: by mail-ob0-f198.google.com with SMTP id wn1sf28422202obc.1 for ; Mon, 10 Mar 2014 08:12:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=zecfNLUkPAHxNIuYLG1Tq9Jw5pV+tMiXkQqZ7oer8WQ=; b=hytjLsiyI1xhhE6ht4WlfGnbjl8NeeGPw5/z47pdEOqufhFPUtXTM4F2PEXOIx3h5U KktLu1kRX3GRmxg+D2Do1eHcarI/4n+cPcPeaI9jkt5HkqMZDCN+cCsYJ9U2W69ql/Et Kt0NGEg1Zk5r6y5x6bCFBTTcTrI1CSrI4dsjeDtxO6gs+bUVvXVGiaGmYvg5HxwXuzfa /7dIVdhTlR4j1xXQUzBZJ+yoXjTyx7EFBP8UJAF9v5N/Q7A7C13x9AIrT5clZBxfEWLz JmTrGUT2g7wlbmV9pr9tBqA+tzKOPuH4p7AHUG6ZDVHO1xlQKbqtJiyqWx/oVpxIE4mV TbMA== X-Gm-Message-State: ALoCoQnV5ER2PczMzoZVJvkwYZ/Qg1cxlEUBisH8w7E2hEPL/tUAnQc/Veo5cEnrWgXjvQW5vp8K X-Received: by 10.43.101.202 with SMTP id db10mr3534728icc.9.1394464328977; Mon, 10 Mar 2014 08:12:08 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.90.80 with SMTP id w74ls2130006qgd.95.gmail; Mon, 10 Mar 2014 08:12:08 -0700 (PDT) X-Received: by 10.52.81.66 with SMTP id y2mr22874895vdx.23.1394464328819; Mon, 10 Mar 2014 08:12:08 -0700 (PDT) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) by mx.google.com with ESMTPS id a5si4822759vez.6.2014.03.10.08.12.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 10 Mar 2014 08:12:08 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.171 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.171; Received: by mail-vc0-f171.google.com with SMTP id lg15so748082vcb.16 for ; Mon, 10 Mar 2014 08:12:08 -0700 (PDT) X-Received: by 10.220.103.141 with SMTP id k13mr1947547vco.25.1394464328710; Mon, 10 Mar 2014 08:12:08 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp125749vck; Mon, 10 Mar 2014 08:12:07 -0700 (PDT) X-Received: by 10.140.50.46 with SMTP id r43mr39172094qga.22.1394464325537; Mon, 10 Mar 2014 08:12:05 -0700 (PDT) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id 107si9567312qgn.108.2014.03.10.08.12.05 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 10 Mar 2014 08:12:05 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:49302 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WN1s5-0003HP-0E for patch@linaro.org; Mon, 10 Mar 2014 11:12:05 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WN1pa-0008JY-Il for qemu-devel@nongnu.org; Mon, 10 Mar 2014 11:09:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WN1pZ-0004XT-MT for qemu-devel@nongnu.org; Mon, 10 Mar 2014 11:09:30 -0400 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:46617) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WN1pZ-0004XG-GV for qemu-devel@nongnu.org; Mon, 10 Mar 2014 11:09:29 -0400 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WN1pQ-0002NG-G3; Mon, 10 Mar 2014 15:09:20 +0000 From: Peter Maydell To: Anthony Liguori Date: Mon, 10 Mar 2014 15:09:18 +0000 Message-Id: <1394464160-9074-8-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1394464160-9074-1-git-send-email-peter.maydell@linaro.org> References: <1394464160-9074-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Cc: Blue Swirl , qemu-devel@nongnu.org, Aurelien Jarno Subject: [Qemu-devel] [PULL 7/9] hw/ssi/xilinx_spips.c: Avoid shifting left into sign bit X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.171 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 Add missing 'U' suffix to avoid shifting left into sign bit of a signed integer. Signed-off-by: Peter Maydell Message-id: 1392988008-15938-4-git-send-email-peter.maydell@linaro.org --- hw/ssi/xilinx_spips.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 6a28746..8977243 100644 --- a/hw/ssi/xilinx_spips.c +++ b/hw/ssi/xilinx_spips.c @@ -43,7 +43,7 @@ /* config register */ #define R_CONFIG (0x00 / 4) -#define IFMODE (1 << 31) +#define IFMODE (1U << 31) #define ENDIAN (1 << 26) #define MODEFAIL_GEN_EN (1 << 17) #define MAN_START_COM (1 << 16) @@ -87,7 +87,7 @@ #define R_LQSPI_CFG (0xa0 / 4) #define R_LQSPI_CFG_RESET 0x03A002EB -#define LQSPI_CFG_LQ_MODE (1 << 31) +#define LQSPI_CFG_LQ_MODE (1U << 31) #define LQSPI_CFG_TWO_MEM (1 << 30) #define LQSPI_CFG_SEP_BUS (1 << 30) #define LQSPI_CFG_U_PAGE (1 << 28)