From patchwork Fri Feb 28 01:37:21 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 25498 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ie0-f198.google.com (mail-ie0-f198.google.com [209.85.223.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 6288F20447 for ; Fri, 28 Feb 2014 01:38:19 +0000 (UTC) Received: by mail-ie0-f198.google.com with SMTP id at1sf11662656iec.9 for ; Thu, 27 Feb 2014 17:38:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:cc:subject:precedence:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:errors-to:sender :x-original-sender:x-original-authentication-results:mailing-list; bh=X1mASdexomKd5ziw0cjIgdXCLKXaqQCA5FKSiXFfZag=; b=bYIwwN+Q6QL2d/fCV15w7t9H7nQ3JUEVIz3byNmsDU1O1P4Gd+X1t9M13op2mNKa3R SPdyc8ql1768LHZijCIzAMtdQhGmxVS8A4wVpYkDhyaaTBkFrY9PTA2PnYrQfnI2hBne NrFuW2Kd6sGjIwZ3P/T4EQ7NB3Iw1grgm7ltoG+zzbztCGYrqqwrBmWwt0yFLhFXuPV5 6GROSq+73bU99AhFBZCohhwFwOIXE1IdO61AM0QvFHBJhxvihuBn1+d67PdzgWYJQ1GM DQ1IiF7Ub04Bex8GByMhpbMMz+608MuRCU1I1V1sEgHysd1u3ibiwHDHa+KwbfSDBo9/ b7mg== X-Gm-Message-State: ALoCoQlXv1PCsxoElxagSAFNcnY4H0JREaxqFdxAtmjHCZME9SFNKZu/gsrF12jPXPuYyaxznWrF X-Received: by 10.182.19.231 with SMTP id i7mr5552119obe.25.1393551498699; Thu, 27 Feb 2014 17:38:18 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.105.230 with SMTP id c93ls886669qgf.35.gmail; Thu, 27 Feb 2014 17:38:18 -0800 (PST) X-Received: by 10.58.200.168 with SMTP id jt8mr144110vec.30.1393551498586; Thu, 27 Feb 2014 17:38:18 -0800 (PST) Received: from mail-ve0-x233.google.com (mail-ve0-x233.google.com [2607:f8b0:400c:c01::233]) by mx.google.com with ESMTPS id we7si256035vcb.7.2014.02.27.17.38.18 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 27 Feb 2014 17:38:18 -0800 (PST) Received-SPF: neutral (google.com: 2607:f8b0:400c:c01::233 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c01::233; Received: by mail-ve0-f179.google.com with SMTP id db12so59261veb.24 for ; Thu, 27 Feb 2014 17:38:18 -0800 (PST) X-Received: by 10.220.191.134 with SMTP id dm6mr157068vcb.16.1393551498439; Thu, 27 Feb 2014 17:38:18 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.130.193 with SMTP id u1csp18849vcs; Thu, 27 Feb 2014 17:38:18 -0800 (PST) X-Received: by 10.224.53.198 with SMTP id n6mr109389qag.41.1393551498027; Thu, 27 Feb 2014 17:38:18 -0800 (PST) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id g88si65856qgf.26.2014.02.27.17.38.17 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 27 Feb 2014 17:38:18 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:48800 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJCP3-0002Kr-Mb for patch@linaro.org; Thu, 27 Feb 2014 20:38:17 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60578) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJCOc-00023P-MP for qemu-devel@nongnu.org; Thu, 27 Feb 2014 20:37:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJCOX-0003s2-Ak for qemu-devel@nongnu.org; Thu, 27 Feb 2014 20:37:50 -0500 Received: from mail-oa0-x233.google.com ([2607:f8b0:4003:c02::233]:49544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJCOX-0003rm-2d for qemu-devel@nongnu.org; Thu, 27 Feb 2014 20:37:45 -0500 Received: by mail-oa0-f51.google.com with SMTP id j17so3358580oag.24 for ; Thu, 27 Feb 2014 17:37:44 -0800 (PST) X-Received: by 10.182.34.196 with SMTP id b4mr11014543obj.13.1393551464347; Thu, 27 Feb 2014 17:37:44 -0800 (PST) Received: from localhost.localdomain (72-48-77-163.dyn.grandenetworks.net. [72.48.77.163]) by mx.google.com with ESMTPSA id qh4sm14653854obc.4.2014.02.27.17.37.43 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 27 Feb 2014 17:37:43 -0800 (PST) From: Rob Herring To: qemu-devel@nongnu.org Date: Thu, 27 Feb 2014 19:37:21 -0600 Message-Id: <1393551441-18041-1-git-send-email-robherring2@gmail.com> X-Mailer: git-send-email 1.8.3.2 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c02::233 Cc: Peter Maydell , Christoffer Dall , Rob Herring Subject: [Qemu-devel] [PATCH] pl011: fix corrupting the UARTCR value X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Original-Sender: robherring2@gmail.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c01::233 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=fail header.i=@gmail.com; dmarc=fail (p=NONE dis=NONE) header.from=gmail.com Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 From: Rob Herring Offset 4 is UARTRSR/UARTECR, not the UARTCR. As framing and parity errors will never occur, we can ignore writes to this register. Signed-off-by: Rob Herring --- hw/char/pl011.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/pl011.c b/hw/char/pl011.c index a8ae6f4..8ced7cd 100644 --- a/hw/char/pl011.c +++ b/hw/char/pl011.c @@ -146,8 +146,8 @@ static void pl011_write(void *opaque, hwaddr offset, s->int_level |= PL011_INT_TX; pl011_update(s); break; - case 1: /* UARTCR */ - s->cr = value; + case 1: /* UARTRSR/UARTECR */ + /* Writes to Rx Status / Error Clear register are ignored. */ break; case 6: /* UARTFR */ /* Writes to Flag register are ignored. */