From patchwork Wed Feb 26 18:01:55 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 25380 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f69.google.com (mail-pa0-f69.google.com [209.85.220.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 2659F20636 for ; Wed, 26 Feb 2014 18:13:30 +0000 (UTC) Received: by mail-pa0-f69.google.com with SMTP id fa1sf3164011pad.8 for ; Wed, 26 Feb 2014 10:13:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list:content-type :content-transfer-encoding; bh=F/VpQT1OyOJnKdElexK4wdZh8JmEnFn5gy4MMRGd9yQ=; b=WTWm3/rQYbxXAnKhIygm+kzK2jyIxuZG/PhqaHLPYydkRUfUPF8SyFUK3FO37f/axI cw83hnfiSluIjdQn0tjNB56XrzqfZ685Tr5w7ZErWeYYhYJ0S1akmlvkA1p4WfAXiYs8 6xUgNTNgaCCGLps4XnKoPTnzzK7XRRyi310qBIvAURJr6si78ZuVdkmBMI+I3K3r3zbf bvIJT28jOhpH5thm7iO3OiFi/BShzEODxkNU9rCUQOEIDA1Faz985p+OzIafbJW/Q3zr 3dOKNeq2X/SGVFhI8wn28puSZUpBDaAyxY5ygN7MJPk5ZRS8hCp/A1YXdET9vjHEY7Jb yrgw== X-Gm-Message-State: ALoCoQlTv0B8/5CJ1wd3GyiTB7X/8F5gwz7eBp5NvMCG4aBRzerslOQ9+D/8/DgrZAAv2zJXPpXO X-Received: by 10.66.6.1 with SMTP id w1mr3804785paw.6.1393438409371; Wed, 26 Feb 2014 10:13:29 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.88.203 with SMTP id t69ls352127qgd.87.gmail; Wed, 26 Feb 2014 10:13:29 -0800 (PST) X-Received: by 10.220.188.70 with SMTP id cz6mr19881vcb.59.1393438409096; Wed, 26 Feb 2014 10:13:29 -0800 (PST) Received: from mail-ve0-f170.google.com (mail-ve0-f170.google.com [209.85.128.170]) by mx.google.com with ESMTPS id zp2si434428vec.84.2014.02.26.10.13.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 26 Feb 2014 10:13:29 -0800 (PST) Received-SPF: neutral (google.com: 209.85.128.170 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.170; Received: by mail-ve0-f170.google.com with SMTP id pa12so1025864veb.1 for ; Wed, 26 Feb 2014 10:13:29 -0800 (PST) X-Received: by 10.52.22.105 with SMTP id c9mr132939vdf.57.1393438409010; Wed, 26 Feb 2014 10:13:29 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.174.196 with SMTP id u4csp45110vcz; Wed, 26 Feb 2014 10:13:28 -0800 (PST) X-Received: by 10.140.93.130 with SMTP id d2mr1097910qge.41.1393438408423; Wed, 26 Feb 2014 10:13:28 -0800 (PST) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id r105si471640qgr.50.2014.02.26.10.13.28 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 26 Feb 2014 10:13:28 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:42234 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIiz1-0006CH-RW for patch@linaro.org; Wed, 26 Feb 2014 13:13:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIioo-0000vp-9x for qemu-devel@nongnu.org; Wed, 26 Feb 2014 13:02:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WIion-0007P3-Ge for qemu-devel@nongnu.org; Wed, 26 Feb 2014 13:02:54 -0500 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:46191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WIion-0007Eu-B5 for qemu-devel@nongnu.org; Wed, 26 Feb 2014 13:02:53 -0500 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WIioV-00069D-Ih; Wed, 26 Feb 2014 18:02:35 +0000 From: Peter Maydell To: Anthony Liguori Date: Wed, 26 Feb 2014 18:01:55 +0000 Message-Id: <1393437755-23586-6-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1393437755-23586-1-git-send-email-peter.maydell@linaro.org> References: <1393437755-23586-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Cc: Blue Swirl , qemu-devel@nongnu.org, Aurelien Jarno Subject: [Qemu-devel] [PULL 05/45] hw/intc/exynos4210_combiner: Don't overrun output_irq array in init X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.170 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 The Exynos4210 combiner has IIC_NIRQ inputs and IIC_NGRP outputs; use the correct constant in the loop initializing our output sysbus IRQs so that we don't overrun the output_irq[] array. Signed-off-by: Peter Maydell Message-id: 1392659611-8439-1-git-send-email-peter.maydell@linaro.org Reviewed-by: Andreas Färber Cc: qemu-stable@nongnu.org --- hw/intc/exynos4210_combiner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/exynos4210_combiner.c b/hw/intc/exynos4210_combiner.c index ef5e8eb..3287479 100644 --- a/hw/intc/exynos4210_combiner.c +++ b/hw/intc/exynos4210_combiner.c @@ -418,7 +418,7 @@ static int exynos4210_combiner_init(SysBusDevice *sbd) qdev_init_gpio_in(dev, exynos4210_combiner_handler, IIC_NIRQ); /* Connect SysBusDev irqs to device specific irqs */ - for (i = 0; i < IIC_NIRQ; i++) { + for (i = 0; i < IIC_NGRP; i++) { sysbus_init_irq(sbd, &s->output_irq[i]); }