From patchwork Thu Feb 20 11:17:29 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 25048 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f200.google.com (mail-ob0-f200.google.com [209.85.214.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A7227203C6 for ; Thu, 20 Feb 2014 11:47:17 +0000 (UTC) Received: by mail-ob0-f200.google.com with SMTP id wo20sf6515643obc.7 for ; Thu, 20 Feb 2014 03:47:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=ZpLdVovfD4/K2nFHGE+PsR6CGA+42EfninU47z8K+ZQ=; b=Lk1v8P8K+bDLOprfxgSrbh/Sov8J50lgiluTUKctmTZS9PJBVAe5D/XdLCSaGLu1lm QOYK9t8cZuOhwZDHlVCKOvD0v9byp3ZgR7uTRIDHP6nNHPgcm4ojFq2ig1tY6PZRnwoB k/+EezTkEN4iz/TeQCTAoaGSum2tUO3zELAUcoi2P9frNn3XZclym7JNRAcBS97WVr6I aTcsM7qnyrDvcWB7Eal23ie2UEHzsPDJM9Ab3tjhrCAOXXYruFORjafj172Pap7lvBTU Q0bg79SNk7Q/xZOQuytxtEFqkG5PlCAg0tSKnIY/dxPr4mBRdLiRKZEj4QyTo+0sRQj+ 1OTg== X-Gm-Message-State: ALoCoQlNcEgKIb+EcaaZ9fFzDdDIKQo9IkXo1I92UFoaY27OEkFqQNH9SO+ZesGeVMTyphRg2hxN X-Received: by 10.182.66.137 with SMTP id f9mr555449obt.3.1392896837113; Thu, 20 Feb 2014 03:47:17 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.89.136 with SMTP id v8ls491621qgd.17.gmail; Thu, 20 Feb 2014 03:47:17 -0800 (PST) X-Received: by 10.52.22.105 with SMTP id c9mr585727vdf.57.1392896836966; Thu, 20 Feb 2014 03:47:16 -0800 (PST) Received: from mail-vc0-f180.google.com (mail-vc0-f180.google.com [209.85.220.180]) by mx.google.com with ESMTPS id kl10si1340118vdb.142.2014.02.20.03.47.16 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 20 Feb 2014 03:47:16 -0800 (PST) Received-SPF: neutral (google.com: 209.85.220.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.180; Received: by mail-vc0-f180.google.com with SMTP id ks9so1729213vcb.11 for ; Thu, 20 Feb 2014 03:47:16 -0800 (PST) X-Received: by 10.220.81.71 with SMTP id w7mr678655vck.71.1392896836900; Thu, 20 Feb 2014 03:47:16 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.174.196 with SMTP id u4csp52109vcz; Thu, 20 Feb 2014 03:47:16 -0800 (PST) X-Received: by 10.236.10.6 with SMTP id 6mr2249962yhu.35.1392896836492; Thu, 20 Feb 2014 03:47:16 -0800 (PST) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v30si4107586yhe.49.2014.02.20.03.47.16 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 20 Feb 2014 03:47:16 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:37593 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGRkI-0004Vo-D9 for patch@linaro.org; Thu, 20 Feb 2014 06:24:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGReI-0003Jp-GC for qemu-devel@nongnu.org; Thu, 20 Feb 2014 06:18:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGReH-0004sl-LT for qemu-devel@nongnu.org; Thu, 20 Feb 2014 06:18:38 -0500 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:46031) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGReH-0004sf-Ez for qemu-devel@nongnu.org; Thu, 20 Feb 2014 06:18:37 -0500 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WGRdI-0003Ur-67; Thu, 20 Feb 2014 11:17:36 +0000 From: Peter Maydell To: Anthony Liguori Date: Thu, 20 Feb 2014 11:17:29 +0000 Message-Id: <1392895054-13232-26-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1392895054-13232-1-git-send-email-peter.maydell@linaro.org> References: <1392895054-13232-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Cc: Blue Swirl , qemu-devel@nongnu.org, Aurelien Jarno Subject: [Qemu-devel] [PULL 25/30] target-arm: A64: Add opcode comments to disas_simd_three_reg_diff X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 The opcode switch in disas_simd_three_reg_diff() is missing the customary comments indicating which cases correspond to which instructions. Add them. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target-arm/translate-a64.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c index 3de9cad..d4e7a20 100644 --- a/target-arm/translate-a64.c +++ b/target-arm/translate-a64.c @@ -7091,24 +7091,24 @@ static void disas_simd_three_reg_diff(DisasContext *s, uint32_t insn) /* 128 x 128 -> 64 */ unsupported_encoding(s, insn); break; - case 9: - case 11: - case 13: - case 14: + case 9: /* SQDMLAL, SQDMLAL2 */ + case 11: /* SQDMLSL, SQDMLSL2 */ + case 13: /* SQDMULL, SQDMULL2 */ + case 14: /* PMULL, PMULL2 */ if (is_u) { unallocated_encoding(s); return; } /* fall through */ - case 0: - case 2: + case 0: /* SADDL, SADDL2, UADDL, UADDL2 */ + case 2: /* SSUBL, SSUBL2, USUBL, USUBL2 */ unsupported_encoding(s, insn); break; - case 5: - case 7: - case 8: - case 10: - case 12: + case 5: /* SABAL, SABAL2, UABAL, UABAL2 */ + case 7: /* SABDL, SABDL2, UABDL, UABDL2 */ + case 8: /* SMLAL, SMLAL2, UMLAL, UMLAL2 */ + case 10: /* SMLSL, SMLSL2, UMLSL, UMLSL2 */ + case 12: /* SMULL, SMULL2, UMULL, UMULL2 */ /* 64 x 64 -> 128 */ if (size == 3) { unallocated_encoding(s);