From patchwork Thu Feb 20 11:17:27 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 25023 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f69.google.com (mail-oa0-f69.google.com [209.85.219.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 11691203BE for ; Thu, 20 Feb 2014 11:28:34 +0000 (UTC) Received: by mail-oa0-f69.google.com with SMTP id h16sf6790391oag.8 for ; Thu, 20 Feb 2014 03:28:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:date :message-id:in-reply-to:references:cc:subject:precedence:list-id :list-unsubscribe:list-archive:list-post:list-help:list-subscribe :errors-to:sender:x-original-sender :x-original-authentication-results:mailing-list; bh=XxofozU2nRaetVECy+sCKRbGFfBr2D5zwye5Yi9S6Zg=; b=JV5CWhcmC9+cJRsqr9SkQw3fyVbSOr6OhjUK7BbFd52NjP4frC/B1ZH1zPoq5OyL9H /Kh3oxEjoAQPlsX9z6X5BfrR6mXMB3IkQmN6cuIClQ4u4r0eodnKd/Plg0fEqUwyrzLR f5tsXqs06A1RzBYy5bIO5jNkV+zGOKkhuHr9ShocJqVfOmPCDJD5jG8Ud9fL2fvIOvV5 1geYdRG3sPY8XiuPLtIEl9BnQbAx8lsP5H9PrXRVIuHhoXK3fXSwJyWZ0ps6q6idkS+H QlOnipWb555g9KM/I1dNVRDWypKi9JtIyFczrTYsADB9jDw3+U2d4H0CUo5uWGYFo3ma dwag== X-Gm-Message-State: ALoCoQn7hdRXz7uKTVnkvu6MKXGA3pDe8mrkwYy0GaCf2kNoY0/s/TFIWdxBkcczhbp2/ag39uyv X-Received: by 10.50.26.65 with SMTP id j1mr865710igg.7.1392895714334; Thu, 20 Feb 2014 03:28:34 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.91.180 with SMTP id z49ls486648qgd.59.gmail; Thu, 20 Feb 2014 03:28:34 -0800 (PST) X-Received: by 10.52.95.233 with SMTP id dn9mr577312vdb.3.1392895714143; Thu, 20 Feb 2014 03:28:34 -0800 (PST) Received: from mail-ve0-f172.google.com (mail-ve0-f172.google.com [209.85.128.172]) by mx.google.com with ESMTPS id av10si1325422ved.150.2014.02.20.03.28.34 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 20 Feb 2014 03:28:34 -0800 (PST) Received-SPF: neutral (google.com: 209.85.128.172 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.172; Received: by mail-ve0-f172.google.com with SMTP id c14so1701935vea.31 for ; Thu, 20 Feb 2014 03:28:34 -0800 (PST) X-Received: by 10.220.225.71 with SMTP id ir7mr699948vcb.50.1392895714048; Thu, 20 Feb 2014 03:28:34 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.174.196 with SMTP id u4csp50775vcz; Thu, 20 Feb 2014 03:28:33 -0800 (PST) X-Received: by 10.140.97.73 with SMTP id l67mr792447qge.56.1392895713625; Thu, 20 Feb 2014 03:28:33 -0800 (PST) Received: from lists.gnu.org (lists.gnu.org. [2001:4830:134:3::11]) by mx.google.com with ESMTPS id v62si1672722qge.28.2014.02.20.03.28.33 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 20 Feb 2014 03:28:33 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 2001:4830:134:3::11 as permitted sender) client-ip=2001:4830:134:3::11; Received: from localhost ([::1]:37631 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGRnt-0001Og-6F for patch@linaro.org; Thu, 20 Feb 2014 06:28:33 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58766) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGReW-0003jT-Hv for qemu-devel@nongnu.org; Thu, 20 Feb 2014 06:18:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGReS-0004uC-Su for qemu-devel@nongnu.org; Thu, 20 Feb 2014 06:18:52 -0500 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:46033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGReS-0004u8-MC for qemu-devel@nongnu.org; Thu, 20 Feb 2014 06:18:48 -0500 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WGRdI-0003Ua-1i; Thu, 20 Feb 2014 11:17:36 +0000 From: Peter Maydell To: Anthony Liguori Date: Thu, 20 Feb 2014 11:17:27 +0000 Message-Id: <1392895054-13232-24-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1392895054-13232-1-git-send-email-peter.maydell@linaro.org> References: <1392895054-13232-1-git-send-email-peter.maydell@linaro.org> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:8b0:1d0::1 Cc: Blue Swirl , qemu-devel@nongnu.org, Aurelien Jarno Subject: [Qemu-devel] [PULL 23/30] target-arm: Fix incorrect type for value argument to write_raw_cp_reg X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: , List-Help: , List-Subscribe: , Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: qemu-devel-bounces+patch=linaro.org@nongnu.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.172 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 The write_raw_cp_reg's value argument should be a uint64_t, since that's what all its callers hand it and what all the functions it calls take. A (harmless) typo meant we were accidentally declaring it as int64_t. Signed-off-by: Peter Maydell Reviewed-by: Peter Crosthwaite --- target-arm/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 59db883..1b111b6 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -141,7 +141,7 @@ static uint64_t read_raw_cp_reg(CPUARMState *env, const ARMCPRegInfo *ri) } static void write_raw_cp_reg(CPUARMState *env, const ARMCPRegInfo *ri, - int64_t v) + uint64_t v) { /* Raw write of a coprocessor register (as needed for migration, etc). * Note that constant registers are treated as write-ignored; the