From patchwork Mon Feb 17 18:55:32 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 24790 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-yk0-f198.google.com (mail-yk0-f198.google.com [209.85.160.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 60D6620143 for ; Mon, 17 Feb 2014 18:55:40 +0000 (UTC) Received: by mail-yk0-f198.google.com with SMTP id 131sf55771676ykp.1 for ; Mon, 17 Feb 2014 10:55:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=Ku74K+jZmhHoeZD4Ehvf9ARKfvrxmGQjo19oZ/Q0I7g=; b=I9qTVOPvQ9PlHs6thIJ6YUIMwvOJwyWtpZIZKTpMXgLpbCUjI2ljY3Z1e90aCVRZyk EUlJ3q1SphJW7tTbw3WZTHO0XN67bRZnzEImJFu5sRb5nn4tQezvyMMx5cJDS++9DtM1 ul5tb584qhSa9CsYIdWXgsomT/8SqRKl7eaUmoo6DFW1Vw/fNctULxmbqhJMXC+cQK6V Af0yyN5t1u/ctjGP7CnITATIe9w664p2uxpFF/aTWhTCzp8BpZTD/RYRVYTIGUpA/1yZ ACOHmq7o69CQ4W9iwWIj+AxTD7pdQ8/QyM46gsbZeGIlpbdrQZdjs0WQpH1cF6fDq+C6 2i6A== X-Gm-Message-State: ALoCoQlxjHX46m3Fe/f+Q6WClQ9c8U/rbvJzYVWtX9jlVsagk/TtGoQ1Bv5hjgRwa3NVrSSaR9cZ X-Received: by 10.236.190.199 with SMTP id e47mr7505152yhn.53.1392663339478; Mon, 17 Feb 2014 10:55:39 -0800 (PST) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.101.70 with SMTP id t64ls1064243qge.1.gmail; Mon, 17 Feb 2014 10:55:39 -0800 (PST) X-Received: by 10.52.65.207 with SMTP id z15mr26753vds.61.1392663339391; Mon, 17 Feb 2014 10:55:39 -0800 (PST) Received: from mail-ve0-f173.google.com (mail-ve0-f173.google.com [209.85.128.173]) by mx.google.com with ESMTPS id y6si4678985veb.101.2014.02.17.10.55.39 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 17 Feb 2014 10:55:39 -0800 (PST) Received-SPF: neutral (google.com: 209.85.128.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.173; Received: by mail-ve0-f173.google.com with SMTP id jw12so5175581veb.4 for ; Mon, 17 Feb 2014 10:55:39 -0800 (PST) X-Received: by 10.52.166.103 with SMTP id zf7mr11227800vdb.30.1392663339315; Mon, 17 Feb 2014 10:55:39 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp160329vcz; Mon, 17 Feb 2014 10:55:38 -0800 (PST) X-Received: by 10.204.16.3 with SMTP id m3mr193150bka.65.1392663336913; Mon, 17 Feb 2014 10:55:36 -0800 (PST) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id cm8si2460487bkc.75.2014.02.17.10.55.36 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 17 Feb 2014 10:55:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 2001:8b0:1d0::1 as permitted sender) client-ip=2001:8b0:1d0::1; Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1WFTLr-0002EZ-1g; Mon, 17 Feb 2014 18:55:35 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Riku Voipio Subject: [PATCH 2/4] linux-user/signal.c: Don't pass sigaction uninitialised sa_flags Date: Mon, 17 Feb 2014 18:55:32 +0000 Message-Id: <1392663334-8555-3-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1392663334-8555-1-git-send-email-peter.maydell@linaro.org> References: <1392663334-8555-1-git-send-email-peter.maydell@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.173 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , When forcing a fatal signal, we weren't initialising the sa_flags field in the struct sigaction we used to reset the signal handler to SIG_DFL. Signed-off-by: Peter Maydell --- linux-user/signal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/signal.c b/linux-user/signal.c index 82e8592..04638e2 100644 --- a/linux-user/signal.c +++ b/linux-user/signal.c @@ -420,6 +420,7 @@ static void QEMU_NORETURN force_sig(int target_sig) * it to arrive. */ sigfillset(&act.sa_mask); act.sa_handler = SIG_DFL; + act.sa_flags = 0; sigaction(host_sig, &act, NULL); /* For some reason raise(host_sig) doesn't send the signal when