From patchwork Mon Oct 21 20:03:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 21203 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f72.google.com (mail-pa0-f72.google.com [209.85.220.72]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id DC9A6244DE for ; Mon, 21 Oct 2013 20:03:10 +0000 (UTC) Received: by mail-pa0-f72.google.com with SMTP id bj1sf12872570pad.7 for ; Mon, 21 Oct 2013 13:03:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=mime-version:x-gm-message-state:delivered-to:from:to:cc:subject :date:message-id:sender:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=uTr8XYPrtveEEqY1lUfy96K4lQWgGRaa4UFMifB0ZiU=; b=Hrvkc5ZVU7SDamTWhqgMmBPms6npWE8yj3SchBxLsVjPzZydy6aeDXs4Zm1rvdy5Rp ueBAp8FFlSqMQ0lTlWP5eZrCdIbgRLndmnKTbU08HAQB4mKuTDDcuCP+29S7Eg7g8g2X w1wRpN/qZUbfGWkAhFO6FZxxfobzf1I4Kj+1kC4/V0L7+eTZlaLkRW39IQMm/iln/aGs shZa7JcfePOJtFUuqsZL0RpevmQUID1Z5sd3T/VzMqhOP/uA8gvdxIyqPhwao+7Wslzm U8dp3xF53DuXKbUGiRSCQfpxKHby2rGX7SdZuAbeCWn9fuzQJX43KhRGOEiyYgG/zik1 K76w== X-Received: by 10.66.20.100 with SMTP id m4mr7173253pae.36.1382385789347; Mon, 21 Oct 2013 13:03:09 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.13.9 with SMTP id d9ls2217436qec.26.gmail; Mon, 21 Oct 2013 13:03:09 -0700 (PDT) X-Received: by 10.52.165.131 with SMTP id yy3mr1935471vdb.25.1382385789170; Mon, 21 Oct 2013 13:03:09 -0700 (PDT) Received: from mail-vc0-f177.google.com (mail-vc0-f177.google.com [209.85.220.177]) by mx.google.com with ESMTPS id dt10si4803134vdb.151.2013.10.21.13.03.09 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 21 Oct 2013 13:03:09 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.177 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.177; Received: by mail-vc0-f177.google.com with SMTP id ib11so744249vcb.8 for ; Mon, 21 Oct 2013 13:03:09 -0700 (PDT) X-Gm-Message-State: ALoCoQk05efw1DFPOZfc5QyDSLqy5mjr2s6Jn4g2OYzoP7kSGGEYVg8l+z6IkhPeEgKqPklXw9D5 X-Received: by 10.221.54.129 with SMTP id vu1mr2344942vcb.20.1382385788989; Mon, 21 Oct 2013 13:03:08 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp176940vcz; Mon, 21 Oct 2013 13:03:08 -0700 (PDT) X-Received: by 10.180.75.232 with SMTP id f8mr11464161wiw.26.1382385787770; Mon, 21 Oct 2013 13:03:07 -0700 (PDT) Received: from chiark.greenend.org.uk (v6.chiark.greenend.org.uk. [2001:ba8:1e3::]) by mx.google.com with ESMTPS id vt5si5469439wjc.113.2013.10.21.13.03.07 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 21 Oct 2013 13:03:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of pmaydell@chiark.greenend.org.uk designates 2001:ba8:1e3:: as permitted sender) client-ip=2001:ba8:1e3::; Received: by chiark.greenend.org.uk (Debian Exim 4.72 #1) with local (return-path pmaydell@chiark.greenend.org.uk) id 1VYLgw-0002OS-KZ; Mon, 21 Oct 2013 21:03:06 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Ken Moffat , Anthony Liguori Subject: [PATCH for-1.7] configure: Explicitly set ARFLAGS so we can build with GNU Make 4.0 Date: Mon, 21 Oct 2013 21:03:06 +0100 Message-Id: <1382385786-9178-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 Sender: Peter Maydell X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.177 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Our rules.mak adds '-rR' to MAKEFLAGS to indicate that we will be explicitly specifying everything and not relying on any default variables or rules. However we were accidentally relying on the default ARFLAGS ("rv"). This went unnoticed because of a bug in GNU Make 3.82 and earlier which meant that adding -rR to MAKEFLAGS only affected submakes, not the currently running instance. Explicitly set ARFLAGS in config-host.mak, in the same way we handle CFLAGS and LDFLAGS; this will allow us to work with Make 4.0. Thanks to Paul Smith for analyzing this bug for us. Reported-by: Ken Moffat Signed-off-by: Peter Maydell Reviewed-by: Alex Bennée --- Ken: I think this should work (and it doesn't break building with old makes), but I don't have a make 4.0 to hand; if you could test it I'd appreciate it. configure | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 57ee62a..4eb3a07 100755 --- a/configure +++ b/configure @@ -308,6 +308,9 @@ query_pkg_config() { pkg_config=query_pkg_config sdl_config="${SDL_CONFIG-${cross_prefix}sdl-config}" +# If the user hasn't specified ARFLAGS, default to 'rv', just as make does. +ARFLAGS="${ARFLAGS-rv}" + # default flags for all hosts QEMU_CFLAGS="-fno-strict-aliasing $QEMU_CFLAGS" QEMU_CFLAGS="-Wall -Wundef -Wwrite-strings -Wmissing-prototypes $QEMU_CFLAGS" @@ -3664,6 +3667,7 @@ echo "C compiler $cc" echo "Host C compiler $host_cc" echo "C++ compiler $cxx" echo "Objective-C compiler $objcc" +echo "ARFLAGS $ARFLAGS" echo "CFLAGS $CFLAGS" echo "QEMU_CFLAGS $QEMU_CFLAGS" echo "LDFLAGS $LDFLAGS" @@ -4239,6 +4243,7 @@ echo "HOST_CC=$host_cc" >> $config_host_mak echo "CXX=$cxx" >> $config_host_mak echo "OBJCC=$objcc" >> $config_host_mak echo "AR=$ar" >> $config_host_mak +echo "ARFLAGS=$ARFLAGS" >> $config_host_mak echo "AS=$as" >> $config_host_mak echo "CPP=$cpp" >> $config_host_mak echo "OBJCOPY=$objcopy" >> $config_host_mak