From patchwork Mon Jul 29 10:31:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 18625 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-qc0-f199.google.com (mail-qc0-f199.google.com [209.85.216.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 6593A2395F for ; Mon, 29 Jul 2013 10:31:59 +0000 (UTC) Received: by mail-qc0-f199.google.com with SMTP id j10sf829751qcx.2 for ; Mon, 29 Jul 2013 03:31:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-beenthere:x-forwarded-to:x-forwarded-for :delivered-to:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=YcjOvI8AvhEfZ42RMpsRDYg/sP5uLLIEcNQA6egE7yM=; b=Be4LmjFF2RQe3UpyKrHQAniyUJcmE++TDR/N/gaCMHp+tME7EZzguFRIn3PCXdAJI2 RaO8/yLrWPEL1aUfrpGi3HgETqgmIYUYIcjoogZ2Q/dok6lhom2X2PSkWt/W/5ceu8kx Kh7lJFQEe/JjLMjYNiF1FCkrYd1m47Le9y4tpTi/1ZEQH+RHk/roRMOVTQXpHY3436lz tJ1smCF+bUHoIN18vjGeypbhWWs5Dm+xDNMXhLcCCa9nLVY2teKBzlEcjSoUOX3xzx0i ejnuUFXeOTSmTBN7TgqSYBr2DZ9p8tWz+kbioX1R0o1GVutLQyop6Ovfy2/G1NrqgavC SXig== X-Received: by 10.236.63.37 with SMTP id z25mr29196030yhc.49.1375093918988; Mon, 29 Jul 2013 03:31:58 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.73.137 with SMTP id l9ls1929511qev.0.gmail; Mon, 29 Jul 2013 03:31:58 -0700 (PDT) X-Received: by 10.52.163.71 with SMTP id yg7mr15002519vdb.110.1375093918878; Mon, 29 Jul 2013 03:31:58 -0700 (PDT) Received: from mail-vc0-f172.google.com (mail-vc0-f172.google.com [209.85.220.172]) by mx.google.com with ESMTPS id ix2si3180938vdb.72.2013.07.29.03.31.58 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Jul 2013 03:31:58 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.172 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.172; Received: by mail-vc0-f172.google.com with SMTP id m17so1952910vca.17 for ; Mon, 29 Jul 2013 03:31:58 -0700 (PDT) X-Received: by 10.52.164.16 with SMTP id ym16mr21033636vdb.32.1375093918808; Mon, 29 Jul 2013 03:31:58 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.11.8 with SMTP id pc8csp108739vcb; Mon, 29 Jul 2013 03:31:58 -0700 (PDT) X-Received: by 10.180.107.167 with SMTP id hd7mr6476378wib.33.1375093917686; Mon, 29 Jul 2013 03:31:57 -0700 (PDT) Received: from mnementh.archaic.org.uk (1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.d.1.0.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id f5si27380706wjx.46.2013.07.29.03.31.57 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 29 Jul 2013 03:31:57 -0700 (PDT) Received-SPF: neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) client-ip=2001:8b0:1d0::1; Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1V3kk1-0003Yg-7Z; Mon, 29 Jul 2013 11:31:49 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Riku Voipio , Laurent Vivier , Anthony Liguori Subject: [PATCH for-1.6] linux-user: Return success from m68k set_thread_area syscall Date: Mon, 29 Jul 2013 11:31:49 +0100 Message-Id: <1375093909-13653-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 X-Gm-Message-State: ALoCoQk2G3ZLmzXzlIW5Is4rmrnOR7wwHyWLkXu7uYm4dJJS1Qj3SD8iuXvvNATj/HLlpWXfwwWJ X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.172 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The m68k set_thread_area syscall implementation failed to set the return value. Correctly set it zero, since this syscall will always succeed. Signed-off-by: Peter Maydell --- Oops. Spotted by clang. linux-user/syscall.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index 3f6db4b..f986548 100644 --- a/linux-user/syscall.c +++ b/linux-user/syscall.c @@ -8523,6 +8523,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1, { TaskState *ts = ((CPUArchState *)cpu_env)->opaque; ts->tp_value = arg1; + ret = 0; break; } #else