From patchwork Thu Jul 18 15:42:01 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 18421 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-gh0-f200.google.com (mail-gh0-f200.google.com [209.85.160.200]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id ECC7220E0B for ; Thu, 18 Jul 2013 15:42:08 +0000 (UTC) Received: by mail-gh0-f200.google.com with SMTP id 10sf3800557ghy.7 for ; Thu, 18 Jul 2013 08:42:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-beenthere:x-forwarded-to:x-forwarded-for :delivered-to:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=6M0HquNAoCF893dbHip0DVXUBJxqXtisLV4Naplt7FA=; b=elMUoZcRkSOTy/ZLwHfp6Q+gCv+W7xupYmB8I+xB0o66xvRJoAsFuKT698MvlUJiAv 2N2PRnlaO+XKWbTc4S4CCIU8KJlNHQoTdgt/rB/2tj3pARjBzUh1mZwjkwGBhL6oG1EW Cd8uUtkvJ/bTmBwXm90unRR/Rz0kwwgoWU7zMBDbeyitXvwp2kicZS8spx0IXO8FKBNI X/zNas1NwlZwhgDNQ9nGpiLZ7GAdnM50k/L+F1lot2CjWQQLHBrxrOdyzOAyOUBJ9qt8 U7ozLc+I+U5+rgD/GraBHoVjk7Yot75M6Pu27ZdhRbiwLaj7awlMy3xwVtQh0SsE2RU7 PNLw== X-Received: by 10.236.123.70 with SMTP id u46mr6572517yhh.20.1374162128397; Thu, 18 Jul 2013 08:42:08 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.17.201 with SMTP id q9ls1502107qed.48.gmail; Thu, 18 Jul 2013 08:42:08 -0700 (PDT) X-Received: by 10.58.155.37 with SMTP id vt5mr4292302veb.41.1374162128228; Thu, 18 Jul 2013 08:42:08 -0700 (PDT) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by mx.google.com with ESMTPS id o7si2939683vet.17.2013.07.18.08.42.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 18 Jul 2013 08:42:08 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.174; Received: by mail-vc0-f174.google.com with SMTP id kw10so2481688vcb.33 for ; Thu, 18 Jul 2013 08:42:08 -0700 (PDT) X-Received: by 10.221.21.74 with SMTP id qr10mr6488vcb.25.1374162128080; Thu, 18 Jul 2013 08:42:08 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.149.77 with SMTP id s13csp231202vcv; Thu, 18 Jul 2013 08:42:07 -0700 (PDT) X-Received: by 10.180.77.231 with SMTP id v7mr8610209wiw.49.1374162126944; Thu, 18 Jul 2013 08:42:06 -0700 (PDT) Received: from mnementh.archaic.org.uk (1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.d.1.0.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id ly4si4707726wjb.1.2013.07.18.08.42.05 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 18 Jul 2013 08:42:06 -0700 (PDT) Received-SPF: neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) client-ip=2001:8b0:1d0::1; Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1UzqLB-0008Dr-SI; Thu, 18 Jul 2013 16:42:01 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Anthony Liguori , qemu-trivial@nongnu.org Subject: [PATCH] configure: Provide more helpful message if libvte not present Date: Thu, 18 Jul 2013 16:42:01 +0100 Message-Id: <1374162121-31582-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 X-Gm-Message-State: ALoCoQn3yTNLBEZ2txzoU6N9AqbGeB93tupTW22Y9TB7pvvloFABtWOZX7jZx3mfmKwp9jE8p1WQ X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , If the system has GTK but not libvte, it's more helpful to tell the user that libvte is missing than to simply say that GTK is not present. Signed-off-by: Peter Maydell --- Since this confused me today and also iggy on IRC, it seems worth making the message a little more specific about what's needed. configure | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/configure b/configure index cb0f870..9e1cd19 100755 --- a/configure +++ b/configure @@ -1697,19 +1697,23 @@ if test "$gtk" != "no"; then vtepackage="vte" vteversion="0.24.0" fi - if $pkg_config --exists "$gtkpackage >= $gtkversion" && \ - $pkg_config --exists "$vtepackage >= $vteversion"; then + if ! $pkg_config --exists "$gtkpackage >= $gtkversion"; then + if test "$gtk" = "yes" ; then + feature_not_found "gtk" + fi + gtk="no" + elif ! $pkg_config --exists "$vtepackage >= $vteversion"; then + if test "$gtk" = "yes" ; then + error_exit "libvte not found (required for gtk support)" + fi + gtk="no" + else gtk_cflags=`$pkg_config --cflags $gtkpackage 2>/dev/null` gtk_libs=`$pkg_config --libs $gtkpackage 2>/dev/null` vte_cflags=`$pkg_config --cflags $vtepackage 2>/dev/null` vte_libs=`$pkg_config --libs $vtepackage 2>/dev/null` libs_softmmu="$gtk_libs $vte_libs $libs_softmmu" gtk="yes" - else - if test "$gtk" = "yes" ; then - feature_not_found "gtk" - fi - gtk="no" fi fi