From patchwork Fri Jun 21 13:00:17 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 18048 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vb0-f71.google.com (mail-vb0-f71.google.com [209.85.212.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 221D025A2B for ; Fri, 21 Jun 2013 13:00:23 +0000 (UTC) Received: by mail-vb0-f71.google.com with SMTP id f12sf10361914vbg.2 for ; Fri, 21 Jun 2013 06:00:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-beenthere:x-forwarded-to:x-forwarded-for :delivered-to:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe; bh=oIPxwJzaCFMnS/Ji8v0fHKRlvbRAj+p0rjWkueRoQ+4=; b=Qn/bWBZSdNKanVOzG37Y8o2E38Nx4rr3hMHJMwo/S7Rh3wiGE50Ovbd10JibUH/w6p 1VFbigiH0O6fv7uSs2P569kaQFOViQLUym2QNkfRMr6NzeykRhNOuh8Gj1+5kdc7PsTb nU7ncX9NYDFIbY79avoXMpV9J4SXt5NRWdYfANOTflj+5v9H21I4BGMZlPmZie0a+T5W LxhPfUJpnWS/AcP8voZeGqbPmk25abVFiZvkPepMT9T8sWIySqkifsridk7KS8xgHhNx ykvo8aWbIjG+UB3+JNAgcZBXHytwL2/rg0sMLxp92Q5ztUDCYWJHKsA8trV5M30/KpMN 2i8w== X-Received: by 10.224.57.65 with SMTP id b1mr13148513qah.2.1371819622435; Fri, 21 Jun 2013 06:00:22 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.116.197 with SMTP id jy5ls1131642qeb.10.gmail; Fri, 21 Jun 2013 06:00:22 -0700 (PDT) X-Received: by 10.52.94.83 with SMTP id da19mr4692470vdb.101.1371819622272; Fri, 21 Jun 2013 06:00:22 -0700 (PDT) Received: from mail-ve0-x22f.google.com (mail-ve0-x22f.google.com [2607:f8b0:400c:c01::22f]) by mx.google.com with ESMTPS id tn5si1483598vdc.117.2013.06.21.06.00.22 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 21 Jun 2013 06:00:22 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c01::22f is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c01::22f; Received: by mail-ve0-f175.google.com with SMTP id da11so6211990veb.20 for ; Fri, 21 Jun 2013 06:00:22 -0700 (PDT) X-Received: by 10.58.215.200 with SMTP id ok8mr5692191vec.21.1371819622113; Fri, 21 Jun 2013 06:00:22 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.58.165.8 with SMTP id yu8csp60576veb; Fri, 21 Jun 2013 06:00:21 -0700 (PDT) X-Received: by 10.194.122.103 with SMTP id lr7mr9041742wjb.15.1371819621109; Fri, 21 Jun 2013 06:00:21 -0700 (PDT) Received: from mnementh.archaic.org.uk (1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.d.1.0.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id z15si3387149wib.61.2013.06.21.06.00.20 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 21 Jun 2013 06:00:21 -0700 (PDT) Received-SPF: neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) client-ip=2001:8b0:1d0::1; Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1Uq0wr-00075h-2J; Fri, 21 Jun 2013 14:00:17 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Peter Crosthwaite , David Gibson , qemu-trivial@nongnu.org Subject: [PATCH] Makefile: pass include directives to dtc via CPPFLAGS, not CFLAGS Date: Fri, 21 Jun 2013 14:00:17 +0100 Message-Id: <1371819617-27232-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.10.4 X-Gm-Message-State: ALoCoQnYwwOc9zoyBZiEhFO37E7PZ33JT2TRymphFPNLATnBuTUXTgEfclUXvjcaivxn/hMDnCWw X-Original-Sender: peter.maydell@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c01::22f is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The dtc submodule's makefile expects -I include directives to be in CPPFLAGS, not CFLAGS. Getting this wrong meant that the include directive would not be applied when generating the dependency .d files. This in turn meant that we couldn't build libfdt when doing an out of tree build with clang. (gcc's dependency output is slightly different from clang in this situation so it happened to work.) Signed-off-by: Peter Maydell --- Tracking this down was not made any easier by make bug http://savannah.gnu.org/bugs/index.php?15110 which meant that make silently exited without saying anything about what was wrong... Makefile | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 3cfa7d0..c06bfab 100644 --- a/Makefile +++ b/Makefile @@ -146,10 +146,11 @@ $(SRC_PATH)/pixman/configure: (cd $(SRC_PATH)/pixman; autoreconf -v --install) DTC_MAKE_ARGS=-I$(SRC_PATH)/dtc VPATH=$(SRC_PATH)/dtc -C dtc V="$(V)" LIBFDT_srcdir=$(SRC_PATH)/dtc/libfdt -DTC_CFLAGS=$(CFLAGS) $(QEMU_CFLAGS) -I$(BUILD_DIR)/dtc -I$(SRC_PATH)/dtc -I$(SRC_PATH)/dtc/libfdt +DTC_CFLAGS=$(CFLAGS) $(QEMU_CFLAGS) +DTC_CPPFLAGS=-I$(BUILD_DIR)/dtc -I$(SRC_PATH)/dtc -I$(SRC_PATH)/dtc/libfdt subdir-dtc:dtc/libfdt dtc/tests - $(call quiet-command,$(MAKE) $(DTC_MAKE_ARGS) CFLAGS="$(DTC_CFLAGS)" LDFLAGS="$(LDFLAGS)" ARFLAGS="$(ARFLAGS)" CC="$(CC)" AR="$(AR)" LD="$(LD)" $(SUBDIR_MAKEFLAGS) libfdt/libfdt.a,) + $(call quiet-command,$(MAKE) $(DTC_MAKE_ARGS) CPPFLAGS="$(DTC_CPPFLAGS)" CFLAGS="$(DTC_CFLAGS)" LDFLAGS="$(LDFLAGS)" ARFLAGS="$(ARFLAGS)" CC="$(CC)" AR="$(AR)" LD="$(LD)" $(SUBDIR_MAKEFLAGS) libfdt/libfdt.a,) dtc/%: mkdir -p $@