From patchwork Mon Jan 21 12:50:51 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 14179 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 4780A23DFE for ; Mon, 21 Jan 2013 13:12:29 +0000 (UTC) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by fiordland.canonical.com (Postfix) with ESMTP id EE216A19215 for ; Mon, 21 Jan 2013 13:12:28 +0000 (UTC) Received: by mail-vc0-f174.google.com with SMTP id n11so3649703vch.19 for ; Mon, 21 Jan 2013 05:12:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:x-gm-message-state; bh=MqwPNLGKr9zsGBc26EL0D6GqY1760FexWDWlVyEorbA=; b=GcoWcmCd5n+WWPg2rAZQRa0zYh0Wb5EVDYE7y9tORN4KwzfPYqUFTO+xXfdsF2b3Jm 9RUCsOAIcn3FiWNSzDivDur6AnsImJATA+ntn6XH7aLRdxUVTJKf70/i7CVcXzXvumtF pzdQtG2NOGIlpIAjgMDODEqtWf4fTpv9tpZrHNjRW9AownGNTzd3DiSeLI7PEHybQ8xU B91vObiMHKjkly/V55jykNhg2EIo/U33iSUqaH8lpvHrYLgu4KqrQSERcpPpf/ITIWtq TNTbIUejJY9TYbAyEvW6wINWVU6vQMVqDrIfExZkKfdV4T0VihJvnz99ZLswS12EnDMh IMPQ== X-Received: by 10.221.0.79 with SMTP id nl15mr19360951vcb.41.1358773948478; Mon, 21 Jan 2013 05:12:28 -0800 (PST) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.58.145.101 with SMTP id st5csp200435veb; Mon, 21 Jan 2013 05:12:27 -0800 (PST) X-Received: by 10.194.238.5 with SMTP id vg5mr26175680wjc.40.1358773947303; Mon, 21 Jan 2013 05:12:27 -0800 (PST) Received: from mnementh.archaic.org.uk (1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.d.1.0.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id fg7si3868221wib.89.2013.01.21.05.12.26 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 21 Jan 2013 05:12:27 -0800 (PST) Received-SPF: neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) client-ip=2001:8b0:1d0::1; Authentication-Results: mx.google.com; spf=neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) smtp.mail=pm215@archaic.org.uk Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1TxGq0-0001vv-UX; Mon, 21 Jan 2013 12:50:56 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Blue Swirl Subject: [PATCH 1/6] hw/arm_sysctl.c: Add missing 'break' statements Date: Mon, 21 Jan 2013 12:50:51 +0000 Message-Id: <1358772656-7406-2-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1358772656-7406-1-git-send-email-peter.maydell@linaro.org> References: <1358772656-7406-1-git-send-email-peter.maydell@linaro.org> X-Gm-Message-State: ALoCoQkcadztIkB8J32q5s37vZsZUEiaTgFthXI+WvYAWIhtgd4OFeGiUztxwa8Xov1SmcH6QfFw Add some break statements that were accidentally omitted from some cases of arm_sysctl_write(). The omission was harmless because in both cases the following case did an immediate break, but adding the breaks explicitly placates static analysers and avoids weird behaviour if the following register is ever implemented as something other than a no-op. Signed-off-by: Peter Maydell --- hw/arm_sysctl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm_sysctl.c b/hw/arm_sysctl.c index a196fcc..6d99f9c 100644 --- a/hw/arm_sysctl.c +++ b/hw/arm_sysctl.c @@ -199,6 +199,7 @@ static void arm_sysctl_write(void *opaque, hwaddr offset, switch (offset) { case 0x08: /* LED */ s->leds = val; + break; case 0x0c: /* OSC0 */ case 0x10: /* OSC1 */ case 0x14: /* OSC2 */ @@ -295,6 +296,7 @@ static void arm_sysctl_write(void *opaque, hwaddr offset, /* On VExpress this register is unimplemented and will RAZ/WI */ break; } + break; case 0x54: /* CLCDSER */ case 0x64: /* DMAPSR0 */ case 0x68: /* DMAPSR1 */