From patchwork Thu Oct 25 12:57:47 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 12513 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 87B7F23EFB for ; Thu, 25 Oct 2012 12:57:54 +0000 (UTC) Received: from mail-ia0-f180.google.com (mail-ia0-f180.google.com [209.85.210.180]) by fiordland.canonical.com (Postfix) with ESMTP id 39899A18FEB for ; Thu, 25 Oct 2012 12:57:54 +0000 (UTC) Received: by mail-ia0-f180.google.com with SMTP id f6so1219552iag.11 for ; Thu, 25 Oct 2012 05:57:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=ELk1P6skDlVRn+TNsTcir5TMEehvyjAzw40NAx/irqc=; b=mGFq6AOxVW2DMkrlaL25K3cxTKCxBNAsJYj4lXT5tOqd0Bhy36nzUiUysXaYkz2Okq 9AV9FJdZmePD0J/grhkW9QlOHQXMJjJRFOSYYrBqHVkZ9pB4CXKwAGNpqMJEbMqf+a75 L6Id3wMsq3K1trq7CebF8IRT49ACSQfvs+ihDhcnC/ByuoxAhQzKC56CEGrM0+nvyVEI 7dGtaHOO47py3eEM4f5Q0idy9AZMaD+fBoxU3Cank/8MEC3Ow8NOUBZCQWpIDpk0cgD0 9q+tUNOKJFu1QhE5CEWbegT6dH09KiRMS5JftJ9iQ/mhaFBgbVezkGR5Om1hrxoKP4+k Q4Jg== Received: by 10.50.91.195 with SMTP id cg3mr4261334igb.57.1351169873906; Thu, 25 Oct 2012 05:57:53 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp42928igt; Thu, 25 Oct 2012 05:57:52 -0700 (PDT) Received: by 10.152.103.18 with SMTP id fs18mr17448903lab.32.1351169871543; Thu, 25 Oct 2012 05:57:51 -0700 (PDT) Received: from mnementh.archaic.org.uk (1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.d.1.0.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id r7si13123468lbd.78.2012.10.25.05.57.50 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 25 Oct 2012 05:57:51 -0700 (PDT) Received-SPF: neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) client-ip=2001:8b0:1d0::1; Authentication-Results: mx.google.com; spf=neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) smtp.mail=pm215@archaic.org.uk Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1TRN0O-0001Qz-1o; Thu, 25 Oct 2012 13:57:48 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org Subject: [PATCH 12/12] hw/versatile_i2c: Use LOG_GUEST_ERROR Date: Thu, 25 Oct 2012 13:57:47 +0100 Message-Id: <1351169867-5466-13-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1351169867-5466-1-git-send-email-peter.maydell@linaro.org> References: <1351169867-5466-1-git-send-email-peter.maydell@linaro.org> X-Gm-Message-State: ALoCoQmQ8fz+6pMeuKlxEzhxDDAGOpknHqHP0t5dlAtvP1E5Wnlts+RobnIw0pveUOJHtoymlUxk Use LOG_GUEST_ERROR to report bad guest accesses. Signed-off-by: Peter Maydell --- hw/versatile_i2c.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/versatile_i2c.c b/hw/versatile_i2c.c index 44e7e40..ad71e9d 100644 --- a/hw/versatile_i2c.c +++ b/hw/versatile_i2c.c @@ -40,7 +40,8 @@ static uint64_t versatile_i2c_read(void *opaque, hwaddr offset, if (offset == 0) { return (s->out & 1) | (s->in << 1); } else { - hw_error("%s: Bad offset 0x%x\n", __func__, (int)offset); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad offset 0x%x\n", __func__, (int)offset); return -1; } } @@ -58,7 +59,8 @@ static void versatile_i2c_write(void *opaque, hwaddr offset, s->out &= ~value; break; default: - hw_error("%s: Bad offset 0x%x\n", __func__, (int)offset); + qemu_log_mask(LOG_GUEST_ERROR, + "%s: Bad offset 0x%x\n", __func__, (int)offset); } bitbang_i2c_set(s->bitbang, BITBANG_I2C_SCL, (s->out & 1) != 0); s->in = bitbang_i2c_set(s->bitbang, BITBANG_I2C_SDA, (s->out & 2) != 0);