From patchwork Fri Oct 19 14:23:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 12377 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 7F86B23EFB for ; Fri, 19 Oct 2012 14:23:10 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 2B21FA18A74 for ; Fri, 19 Oct 2012 14:23:10 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so650948iej.11 for ; Fri, 19 Oct 2012 07:23:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:x-gm-message-state; bh=6Lh8JdsVsP4GylK7kwN9Q0evccOxHyBFJ5vbcpvhHOg=; b=f92F30GP8kaD4P2esloweIJgWL579RUI+29DLuSizB1Oe9l76HxUPfIGhstBtdqrUp xFcSohm9gvlaTgaVUlTCkEfcmvZt6ZijpZGGeONsxBskT++ytinlsPPcg0rIirZ18spJ 3h+Rqt3snggfKbtF3rFrGMIsg6r/0P1r6U3jxP1PKD7+38K8YPzw8WfS/geujXVkJScx nc/QnVTKBgsBrYOMBjgEJJ1zhWqrxAeC9XajuisVbo5IIpLxecxyuGGR/MShLwUgCZtJ B0j5Y3+cSwEbgaw3gzLajZwZChWPWOGQLFAmt9kzE1S7zh+/qE4ZMGo0djTOqI5B+8gm PE5g== Received: by 10.50.46.226 with SMTP id y2mr1427131igm.62.1350656589531; Fri, 19 Oct 2012 07:23:09 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp96199igt; Fri, 19 Oct 2012 07:23:08 -0700 (PDT) Received: by 10.180.104.97 with SMTP id gd1mr3670151wib.4.1350656587689; Fri, 19 Oct 2012 07:23:07 -0700 (PDT) Received: from mnementh.archaic.org.uk (1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.d.1.0.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id i20si2010096wej.51.2012.10.19.07.23.06 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 19 Oct 2012 07:23:07 -0700 (PDT) Received-SPF: neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) client-ip=2001:8b0:1d0::1; Authentication-Results: mx.google.com; spf=neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) smtp.mail=pm215@archaic.org.uk Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1TPDTd-0006nt-VT; Fri, 19 Oct 2012 15:23:05 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, qemu-trivial@nongnu.org Subject: [PATCH] target-arm: Remove out of date FIXME regarding saturating arithmetic Date: Fri, 19 Oct 2012 15:23:05 +0100 Message-Id: <1350656585-26130-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 X-Gm-Message-State: ALoCoQmzRwFjx4XCE6ZmUZxd5FKOPKjPJVgC/s0uYtk6IpnSOiVs4VXfrLW8ZrKZxv5j3GbQAmQr Remove an out of date FIXME regarding the saturating arithmetic helpers: we now do pass a pointer to CPUARMState to these helpers, and since the AREG0 changes went in there is no difference between helper.c and op_helper.c and therefore no point in moving the functions. Signed-off-by: Peter Maydell --- target-arm/op_helper.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/target-arm/op_helper.c b/target-arm/op_helper.c index aef592a..6e3ab90 100644 --- a/target-arm/op_helper.c +++ b/target-arm/op_helper.c @@ -93,8 +93,6 @@ void tlb_fill(CPUARMState *env, target_ulong addr, int is_write, int mmu_idx, } #endif -/* FIXME: Pass an explicit pointer to QF to CPUARMState, and move saturating - instructions into helper.c */ uint32_t HELPER(add_setq)(CPUARMState *env, uint32_t a, uint32_t b) { uint32_t res = a + b;