From patchwork Thu Oct 18 13:11:41 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 12339 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 530B723DE2 for ; Thu, 18 Oct 2012 13:11:55 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id 05E08A18611 for ; Thu, 18 Oct 2012 13:11:54 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so13185440iej.11 for ; Thu, 18 Oct 2012 06:11:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=EeiL+Je9J8IShZBlsMJFyZQs+s7Q8BWtRVPBT9mByVI=; b=K7POup6iPjGfsUC4oJgp2pAKqWck2XuE6Uk7aeveQR/et+dUlqXj4OjFWO7bs2K3ba WoE07/g0f9tOU0T3YEPzWA8nuupJGP5W8NSopgcxiai5mMj6TwPCtFZVOuYYSbeWcupk 4cGP251f685TTAvGhnKbjsdKbKedbQvLkEWUO+vs5Il4d4xnJdxfuN7ULoD6ccWurlPV gmJ99YOEOjWy711Cg2bRzKagOCPEj69hgzaxaGtM2YXYuJfpx9ed/JESlU6Cd54X3y4Q sKm6i/Yi0AFsLxPrvzawfME52tUOCuof5EMcuf5CF5VuqQGfZWwF5k6NoNblAf2oCHAI o7pQ== Received: by 10.50.152.137 with SMTP id uy9mr4584973igb.62.1350565914793; Thu, 18 Oct 2012 06:11:54 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.67.148 with SMTP id n20csp1069437igt; Thu, 18 Oct 2012 06:11:53 -0700 (PDT) Received: by 10.216.204.138 with SMTP id h10mr13157333weo.168.1350565913167; Thu, 18 Oct 2012 06:11:53 -0700 (PDT) Received: from mnementh.archaic.org.uk (1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.d.1.0.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id dl4si31596830wib.31.2012.10.18.06.11.52 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 18 Oct 2012 06:11:53 -0700 (PDT) Received-SPF: neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) client-ip=2001:8b0:1d0::1; Authentication-Results: mx.google.com; spf=neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) smtp.mail=pm215@archaic.org.uk Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1TOpt0-0006En-NW; Thu, 18 Oct 2012 14:11:42 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, Blue Swirl Subject: [PATCH v2 7/8] hw/pl022: Use LOG_UNIMP and LOG_GUEST_ERROR Date: Thu, 18 Oct 2012 14:11:41 +0100 Message-Id: <1350565902-23940-8-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1350565902-23940-1-git-send-email-peter.maydell@linaro.org> References: <1350565902-23940-1-git-send-email-peter.maydell@linaro.org> X-Gm-Message-State: ALoCoQnq6HmSm1GnKpvn8Pg+SpFfsbrYeuFitYbyZBzaHzjshkOtgQkb9BiRjWljn69Iwb9KxzB9 Use LOG_UNIMP and LOG_GUEST_ERROR where appropriate rather than hw_error(). Signed-off-by: Peter Maydell --- hw/pl022.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/pl022.c b/hw/pl022.c index 60e35da..e2ae315 100644 --- a/hw/pl022.c +++ b/hw/pl022.c @@ -168,7 +168,8 @@ static uint64_t pl022_read(void *opaque, target_phys_addr_t offset, /* Not implemented. */ return 0; default: - hw_error("pl022_read: Bad offset %x\n", (int)offset); + qemu_log_mask(LOG_GUEST_ERROR, + "pl022_read: Bad offset %x\n", (int)offset); return 0; } } @@ -211,11 +212,12 @@ static void pl022_write(void *opaque, target_phys_addr_t offset, break; case 0x20: /* DMACR */ if (value) { - hw_error("pl022: DMA not implemented\n"); + qemu_log_mask(LOG_UNIMP, "pl022: DMA not implemented\n"); } break; default: - hw_error("pl022_write: Bad offset %x\n", (int)offset); + qemu_log_mask(LOG_GUEST_ERROR, + "pl022_write: Bad offset %x\n", (int)offset); } }