From patchwork Fri Sep 28 15:05:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 11853 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 85B9E23EFF for ; Fri, 28 Sep 2012 15:06:01 +0000 (UTC) Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com [209.85.223.180]) by fiordland.canonical.com (Postfix) with ESMTP id C0C1EA18D2A for ; Fri, 28 Sep 2012 15:06:00 +0000 (UTC) Received: by mail-ie0-f180.google.com with SMTP id e10so7123143iej.11 for ; Fri, 28 Sep 2012 08:06:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:x-gm-message-state; bh=sjM8u8VyA6hRSRQo89W/oC+fAuU0guuycjE7n+0oaWQ=; b=a6IK1DGshKXdIY3dAMwUFyIbT2quh5vhujYam0DDz80zr3tEjijR2HNrVCVkQD/hnw xaL64zsuP+CNIy84k7QbY5OjnlLlYbc3v0LKGox+0ZbhbCqLBRUO7sBhKRIK4naZ3zjH Ga/LHMdpejTK/oc1l/rOL2HLkUg1OKTPjfVN2mAHdirPDwqZiF0kPGSRTuXeTjzzvVk9 R97tW4bZjF/Qzk0hXBsSzXflqKNFRFq4kq53rA0L1GMnF6jqEkZCwpBfNxTXvF7SCA8+ POTiXOS7eYV4SjBgHJBJfIIWXujb8ka+VI015kLUyc9HY9SAPYUTszWuelDqb44bBJLr 0wZA== Received: by 10.50.194.136 with SMTP id hw8mr1423375igc.28.1348844760487; Fri, 28 Sep 2012 08:06:00 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.184.232 with SMTP id ex8csp476952igc; Fri, 28 Sep 2012 08:05:59 -0700 (PDT) Received: by 10.216.144.92 with SMTP id m70mr3821139wej.222.1348844757021; Fri, 28 Sep 2012 08:05:57 -0700 (PDT) Received: from mnementh.archaic.org.uk (1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.d.1.0.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:1d0::1]) by mx.google.com with ESMTPS id q52si11156594wea.68.2012.09.28.08.05.55 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 28 Sep 2012 08:05:56 -0700 (PDT) Received-SPF: neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) client-ip=2001:8b0:1d0::1; Authentication-Results: mx.google.com; spf=neutral (google.com: 2001:8b0:1d0::1 is neither permitted nor denied by best guess record for domain of pm215@archaic.org.uk) smtp.mail=pm215@archaic.org.uk Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1THc8K-0005Df-VF; Fri, 28 Sep 2012 16:05:40 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: Alexander Graf , Aurelien Jarno , Richard Henderson , patches@linaro.org Subject: [PATCH] tcg/arm: Use tcg_out_mov_reg rather than inline equivalent code Date: Fri, 28 Sep 2012 16:05:40 +0100 Message-Id: <1348844740-20038-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 X-Gm-Message-State: ALoCoQld3CIgottINUVhm9R5ecytKsk4V49Dg/iRT9ApiZqUbWGutIakOyVfFvRaSBg4azqyQ1KW Use the recently introduced tcg_out_mov_reg() function rather than the equivalent inline code. Signed-off-by: Peter Maydell --- This is a minor follow-on cleanup patch after commit 9716ef3b1. tcg/arm/tcg-target.c | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 2bad0a2..5e8dbdd 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -1197,20 +1197,11 @@ static inline void tcg_out_qemu_ld(TCGContext *s, const TCGArg *args, int opc) case 1: case 2: default: - if (data_reg != TCG_REG_R0) { - tcg_out_dat_reg(s, COND_AL, ARITH_MOV, - data_reg, 0, TCG_REG_R0, SHIFT_IMM_LSL(0)); - } + tcg_out_mov_reg(s, COND_AL, data_reg, TCG_REG_R0); break; case 3: - if (data_reg != TCG_REG_R0) { - tcg_out_dat_reg(s, COND_AL, ARITH_MOV, - data_reg, 0, TCG_REG_R0, SHIFT_IMM_LSL(0)); - } - if (data_reg2 != TCG_REG_R1) { - tcg_out_dat_reg(s, COND_AL, ARITH_MOV, - data_reg2, 0, TCG_REG_R1, SHIFT_IMM_LSL(0)); - } + tcg_out_mov_reg(s, COND_AL, data_reg, TCG_REG_R0); + tcg_out_mov_reg(s, COND_AL, data_reg2, TCG_REG_R1); break; }