From patchwork Sat Sep 17 18:51:49 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 4155 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 5186723EFC for ; Sat, 17 Sep 2011 18:51:55 +0000 (UTC) Received: from mail-fx0-f52.google.com (mail-fx0-f52.google.com [209.85.161.52]) by fiordland.canonical.com (Postfix) with ESMTP id 475C2A18171 for ; Sat, 17 Sep 2011 18:51:55 +0000 (UTC) Received: by mail-fx0-f52.google.com with SMTP id 23so3841576fxe.11 for ; Sat, 17 Sep 2011 11:51:55 -0700 (PDT) Received: by 10.223.94.134 with SMTP id z6mr1694705fam.8.1316285515146; Sat, 17 Sep 2011 11:51:55 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.152.11.8 with SMTP id m8cs171031lab; Sat, 17 Sep 2011 11:51:55 -0700 (PDT) Received: by 10.216.171.72 with SMTP id q50mr794992wel.76.1316285514686; Sat, 17 Sep 2011 11:51:54 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk [81.2.115.146]) by mx.google.com with ESMTPS id x19si14806145wec.130.2011.09.17.11.51.53 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 17 Sep 2011 11:51:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 81.2.115.146 as permitted sender) client-ip=81.2.115.146; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 81.2.115.146 as permitted sender) smtp.mail=pm215@archaic.org.uk Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1R4zzR-0001Lr-Ki; Sat, 17 Sep 2011 19:51:49 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: Andrzej Zaborowski , patches@linaro.org Subject: [PATCH 2/2] hw/omap_gpmc: Modify correct field when writing IRQSTATUS register Date: Sat, 17 Sep 2011 19:51:49 +0100 Message-Id: <1316285509-5170-2-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1316285509-5170-1-git-send-email-peter.maydell@linaro.org> References: <1316285509-5170-1-git-send-email-peter.maydell@linaro.org> Writing to IRQSTATUS should affect irqst, not irqen -- error spotted by Andrzej Zaborowski. Signed-off-by: Peter Maydell --- hw/omap_gpmc.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/omap_gpmc.c b/hw/omap_gpmc.c index e27b93c..7fc82a2 100644 --- a/hw/omap_gpmc.c +++ b/hw/omap_gpmc.c @@ -639,7 +639,7 @@ static void omap_gpmc_write(void *opaque, target_phys_addr_t addr, break; case 0x018: /* GPMC_IRQSTATUS */ - s->irqen &= ~value; + s->irqst &= ~value; omap_gpmc_int_update(s); break;