From patchwork Thu Sep 15 11:15:56 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 4092 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 7B8AD23EF9 for ; Thu, 15 Sep 2011 11:21:46 +0000 (UTC) Received: from mail-ey0-f180.google.com (mail-ey0-f180.google.com [209.85.215.180]) by fiordland.canonical.com (Postfix) with ESMTP id 66DBBA1888A for ; Thu, 15 Sep 2011 11:21:46 +0000 (UTC) Received: by eyb6 with SMTP id 6so1485380eyb.11 for ; Thu, 15 Sep 2011 04:21:46 -0700 (PDT) Received: by 10.223.74.89 with SMTP id t25mr676236faj.65.1316085360729; Thu, 15 Sep 2011 04:16:00 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.152.11.8 with SMTP id m8cs88462lab; Thu, 15 Sep 2011 04:16:00 -0700 (PDT) Received: by 10.216.136.216 with SMTP id w66mr486229wei.94.1316085359564; Thu, 15 Sep 2011 04:15:59 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk [81.2.115.146]) by mx.google.com with ESMTPS id e43si7530980wed.131.2011.09.15.04.15.57 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Sep 2011 04:15:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 81.2.115.146 as permitted sender) client-ip=81.2.115.146; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 81.2.115.146 as permitted sender) smtp.mail=pm215@archaic.org.uk Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1R49vA-0000Ae-6s; Thu, 15 Sep 2011 12:15:56 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org, qemu-trivial@nongnu.org Subject: [PATCH] configure: Make missing pkg-config an error rather than a warning Date: Thu, 15 Sep 2011 12:15:56 +0100 Message-Id: <1316085356-632-1-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 If pkg-config doesn't exist then make configure fail immediately with a useful error message. Now that glib is a required dependency, proceeding despite the missing pkg-config will just cause us to fail later with a misleading message about glib not being present. Signed-off-by: Peter Maydell --- configure | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 0875f95..6c2839d 100755 --- a/configure +++ b/configure @@ -1339,8 +1339,8 @@ fi # pkg-config probe if ! has $pkg_config; then - echo warning: proceeding without "$pkg_config" >&2 - pkg_config=/bin/false + echo "Error: pkg-config binary '$pkg_config' not found" + exit 1 fi ##########################################