From patchwork Fri Jul 22 10:51:21 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 3046 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 41BAD23F3D for ; Fri, 22 Jul 2011 10:51:27 +0000 (UTC) Received: from mail-qw0-f52.google.com (mail-qw0-f52.google.com [209.85.216.52]) by fiordland.canonical.com (Postfix) with ESMTP id 10F20A181BA for ; Fri, 22 Jul 2011 10:51:26 +0000 (UTC) Received: by mail-qw0-f52.google.com with SMTP id 8so1523633qwb.11 for ; Fri, 22 Jul 2011 03:51:26 -0700 (PDT) Received: by 10.229.217.3 with SMTP id hk3mr1247745qcb.38.1311331886815; Fri, 22 Jul 2011 03:51:26 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.229.217.78 with SMTP id hl14cs11341qcb; Fri, 22 Jul 2011 03:51:26 -0700 (PDT) Received: by 10.14.94.70 with SMTP id m46mr167980eef.114.1311331884654; Fri, 22 Jul 2011 03:51:24 -0700 (PDT) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk [81.2.115.146]) by mx.google.com with ESMTPS id z41si2796568eef.66.2011.07.22.03.51.22 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 22 Jul 2011 03:51:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 81.2.115.146 as permitted sender) client-ip=81.2.115.146; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 81.2.115.146 as permitted sender) smtp.mail=pm215@archaic.org.uk Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.72) (envelope-from ) id 1QkDKD-0003Mk-J8; Fri, 22 Jul 2011 11:51:21 +0100 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org Subject: [PATCH 3/3] target-arm: Don't print debug messages for various UNDEF cases Date: Fri, 22 Jul 2011 11:51:21 +0100 Message-Id: <1311331881-12909-4-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.2.5 In-Reply-To: <1311331881-12909-1-git-send-email-peter.maydell@linaro.org> References: <1311331881-12909-1-git-send-email-peter.maydell@linaro.org> Remove some stray printfs for cases which don't generally happen (some VFP UNDEF cases, reads and writes to unknown cp14 registers); we should simply generate an UNDEF when the instruction is executed. Signed-off-by: Peter Maydell --- target-arm/translate.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index a9a70e5..6b84cf6 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -3273,12 +3273,10 @@ static int disas_vfp_insn(CPUState * env, DisasContext *s, uint32_t insn) gen_vfp_toul(dp, 32 - rm, 0); break; default: /* undefined */ - printf ("rn:%d\n", rn); return 1; } break; default: /* undefined */ - printf ("op:%d\n", op); return 1; } @@ -6357,8 +6355,6 @@ static int disas_cp14_read(CPUState * env, DisasContext *s, uint32_t insn) return 0; } } - fprintf(stderr, "Unknown cp14 read op1:%d crn:%d crm:%d op2:%d\n", - op1, crn, crm, op2); return 1; } @@ -6390,8 +6386,6 @@ static int disas_cp14_write(CPUState * env, DisasContext *s, uint32_t insn) return 0; } } - fprintf(stderr, "Unknown cp14 write op1:%d crn:%d crm:%d op2:%d\n", - op1, crn, crm, op2); return 1; }