From patchwork Fri Feb 11 12:26:47 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Maydell X-Patchwork-Id: 122 Return-Path: Delivered-To: unknown Received: from imap.gmail.com (74.125.159.109) by localhost6.localdomain6 with IMAP4-SSL; 08 Jun 2011 14:40:10 -0000 Delivered-To: patches@linaro.org Received: by 10.147.124.5 with SMTP id b5cs214942yan; Fri, 11 Feb 2011 04:26:53 -0800 (PST) Received: by 10.42.218.72 with SMTP id hp8mr504520icb.345.1297427212954; Fri, 11 Feb 2011 04:26:52 -0800 (PST) Received: from mnementh.archaic.org.uk (mnementh.archaic.org.uk [81.2.115.146]) by mx.google.com with ESMTPS id z4si1676590wfd.35.2011.02.11.04.26.51 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 11 Feb 2011 04:26:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 81.2.115.146 as permitted sender) client-ip=81.2.115.146; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of pm215@archaic.org.uk designates 81.2.115.146 as permitted sender) smtp.mail=pm215@archaic.org.uk Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.69) (envelope-from ) id 1Pns5I-0004R6-8D; Fri, 11 Feb 2011 12:26:48 +0000 From: Peter Maydell To: qemu-devel@nongnu.org Cc: patches@linaro.org Subject: [PATCH 1/2] target-arm: Refactor handling of VQDMULL Date: Fri, 11 Feb 2011 12:26:47 +0000 Message-Id: <1297427208-17029-2-git-send-email-peter.maydell@linaro.org> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1297427208-17029-1-git-send-email-peter.maydell@linaro.org> References: <1297427208-17029-1-git-send-email-peter.maydell@linaro.org> Refactor the handling of VQDMULL so that it is dealt with in its own if() case rather than together with the accumulating instructions. Signed-off-by: Peter Maydell --- target-arm/translate.c | 16 ++++++---------- 1 files changed, 6 insertions(+), 10 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 3087a5d..cf5c3f0 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -5129,16 +5129,16 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn) default: /* 15 is RESERVED. */ return 1; } - if (op == 5 || op == 13 || (op >= 8 && op <= 11)) { + if (op == 13) { + /* VQDMULL */ + gen_neon_addl_saturate(cpu_V0, cpu_V0, size); + neon_store_reg64(cpu_V0, rd + pass); + } else if (op == 5 || (op >= 8 && op <= 11)) { /* Accumulate. */ if (op == 10 || op == 11) { gen_neon_negl(cpu_V0, size); } - - if (op != 13) { - neon_load_reg64(cpu_V1, rd + pass); - } - + neon_load_reg64(cpu_V1, rd + pass); switch (op) { case 5: case 8: case 10: /* VABAL, VMLAL, VMLSL */ gen_neon_addl(size); @@ -5147,10 +5147,6 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn) gen_neon_addl_saturate(cpu_V0, cpu_V0, size); gen_neon_addl_saturate(cpu_V0, cpu_V1, size); break; - /* Fall through. */ - case 13: /* VQDMULL */ - gen_neon_addl_saturate(cpu_V0, cpu_V0, size); - break; default: abort(); }